a78ab77b6b
Summary: Inalloca parameters require special handling in some optimizations. This change causes globalopt to strip the inalloca attribute from function parameters when it is safe to do so, removes the special handling for inallocas from argpromotion, and replaces it with a simple check that causes argpromotion to skip functions that receive inallocas (for when the pass is invoked on code that didn't run through globalopt first). This also avoids a case where argpromotion would incorrectly try to pass an inalloca in a register. Fixes PR41658. Reviewers: rnk, efriedma Reviewed By: rnk Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D61286 llvm-svn: 359743
56 lines
1.3 KiB
LLVM
56 lines
1.3 KiB
LLVM
; RUN: opt < %s -globalopt -S | FileCheck %s
|
|
|
|
define internal i32 @f(i32* %m) {
|
|
; CHECK-LABEL: define internal fastcc i32 @f
|
|
%v = load i32, i32* %m
|
|
ret i32 %v
|
|
}
|
|
|
|
define internal x86_thiscallcc i32 @g(i32* %m) {
|
|
; CHECK-LABEL: define internal fastcc i32 @g
|
|
%v = load i32, i32* %m
|
|
ret i32 %v
|
|
}
|
|
|
|
; Leave this one alone, because the user went out of their way to request this
|
|
; convention.
|
|
define internal coldcc i32 @h(i32* %m) {
|
|
; CHECK-LABEL: define internal coldcc i32 @h
|
|
%v = load i32, i32* %m
|
|
ret i32 %v
|
|
}
|
|
|
|
define internal i32 @j(i32* %m) {
|
|
; CHECK-LABEL: define internal i32 @j
|
|
%v = load i32, i32* %m
|
|
ret i32 %v
|
|
}
|
|
|
|
define internal i32 @inalloca(i32* inalloca %p) {
|
|
; CHECK-LABEL: define internal fastcc i32 @inalloca(i32* %p)
|
|
%rv = load i32, i32* %p
|
|
ret i32 %rv
|
|
}
|
|
|
|
define void @call_things() {
|
|
%m = alloca i32
|
|
call i32 @f(i32* %m)
|
|
call x86_thiscallcc i32 @g(i32* %m)
|
|
call coldcc i32 @h(i32* %m)
|
|
call i32 @j(i32* %m)
|
|
%args = alloca inalloca i32
|
|
call i32 @inalloca(i32* inalloca %args)
|
|
ret void
|
|
}
|
|
|
|
@llvm.used = appending global [1 x i8*] [
|
|
i8* bitcast (i32(i32*)* @j to i8*)
|
|
], section "llvm.metadata"
|
|
|
|
; CHECK-LABEL: define void @call_things()
|
|
; CHECK: call fastcc i32 @f
|
|
; CHECK: call fastcc i32 @g
|
|
; CHECK: call coldcc i32 @h
|
|
; CHECK: call i32 @j
|
|
; CHECK: call fastcc i32 @inalloca(i32* %args)
|