Files
clang-p2996/llvm/test/tools/llvm-objcopy/ELF/basic-relocations.test
George Rimar 6da44ad75d [yaml2obj][obj2yaml] - Change how symbol's binding is descibed when parsing/dumping.
Currently, YAML has the following syntax for describing the symbols:

Symbols:
  Local:
    LocalSymbol1:
    ...
    LocalSymbol2:
    ...
  ...
  Global:
    GlobalSymbol1:
  ...
  Weak:
  ...
  GNUUnique:

I.e. symbols are grouped by their bindings. That is not very convenient,
because:

It does not allow to set a custom binding, what can be useful for producing
broken/special outputs for test cases. Adding a new binding would require to
change a syntax (what we observed when added GNUUnique recently).

It does not allow to change the order of the symbols in .symtab/.dynsym,
i.e. currently all Local symbols are placed first, then Global, Weak and GNUUnique
are following, but we are not able to change the order.

It is not consistent. Binding is just one of the properties of the symbol,
we do not group them by other properties.

It makes the code more complex that it can be. This patch shows it can be simplified
with the change performed.

The patch changes the syntax to just:

Symbols:
  Symbol1:
  ...
  Symbol2:
  ...
...

With that, we are able to work with the binding field just like with any other symbol property.

Differential revision: https://reviews.llvm.org/D60122

llvm-svn: 357595
2019-04-03 14:53:42 +00:00

96 lines
2.4 KiB
Plaintext

# RUN: yaml2obj %s > %t
# RUN: llvm-objcopy %t %t2
# RUN: llvm-readobj --relocations %t2 | FileCheck %s
!ELF
FileHeader:
Class: ELFCLASS64
Data: ELFDATA2LSB
Type: ET_EXEC
Machine: EM_X86_64
Sections:
- Name: .text
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
Address: 0x1000
AddressAlign: 0x0000000000000010
Content: "0000000000000000"
- Name: .rel.text
Type: SHT_REL
Link: .symtab
Info: .text
Relocations:
- Offset: 0x1000
Symbol: foo
Type: R_X86_64_PC32
- Name: .data
Type: SHT_PROGBITS
Flags: [ SHF_ALLOC ]
Address: 0x2000
AddressAlign: 0x0000000000000010
Content: "0000000000000000"
- Name: .rel.data
Type: SHT_REL
Link: .symtab
Info: .data
Relocations:
- Offset: 0x2000
Symbol: bar
Type: R_X86_64_PC32
- Name: .rela.data
Type: SHT_RELA
Link: .symtab
Info: .data
Relocations:
- Offset: 0x2000
Symbol: barA
Type: R_X86_64_PC32
Addend: 0x17
- Name: .rela.text
Type: SHT_RELA
Link: .symtab
Info: .text
Relocations:
- Offset: 0x1000
Symbol: fooA
Type: R_X86_64_PC32
Addend: 0x13
Symbols:
- Name: _start
Type: STT_FUNC
Section: .text
Value: 0x1000
Size: 4
Binding: STB_GLOBAL
- Name: foo
Type: STT_FUNC
Size: 4
Binding: STB_GLOBAL
- Name: fooA
Type: STT_FUNC
Size: 4
Binding: STB_GLOBAL
- Name: bar
Type: STT_OBJECT
Size: 4
Binding: STB_GLOBAL
- Name: barA
Type: STT_OBJECT
Size: 4
Binding: STB_GLOBAL
# CHECK: Relocations [
# CHECK-NEXT: Section (2) .rel.text {
# CHECK-NEXT: 0x1000 R_X86_64_PC32 foo 0x0
# CHECK-NEXT: }
# CHECK-NEXT: Section (4) .rel.data {
# CHECK-NEXT: 0x2000 R_X86_64_PC32 bar 0x0
# CHECK-NEXT: }
# CHECK-NEXT: Section (5) .rela.data {
# CHECK-NEXT: 0x2000 R_X86_64_PC32 barA 0x17
# CHECK-NEXT: }
# CHECK-NEXT: Section (6) .rela.text {
# CHECK-NEXT: 0x1000 R_X86_64_PC32 fooA 0x13
# CHECK-NEXT: }
# CHECK-NEXT:]