Summary:
The purpose of this patch is to make identifying missing dependencies clearer to the user.
`find_package` will report if a package is not found, that output, combined with the exiting
status message, is clearer than not having the additional verbosity.
If the SWIG dependency is required {LLDB_ENABLE_PYTHON, LLDB_ENABLE_LUA}
and SWIG is not available, fail the configuration step. Terminate the
configure early rather than later with a clear error message.
We could possibly modify:
`llvm-project/lldb/cmake/modules/FindPythonInterpAndLibs.cmake`
However, the patch here seems clear in my opinion.
Reviewers: aadsm, hhb, JDevlieghere
Reviewed By: JDevlieghere
Subscribers: labath, jrm, mgorny, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74917
32 lines
900 B
CMake
32 lines
900 B
CMake
#.rst:
|
|
# FindLuaAndSwig
|
|
# --------------
|
|
#
|
|
# Find Lua and SWIG as a whole.
|
|
|
|
if(LUA_LIBRARIES AND LUA_INCLUDE_DIR AND SWIG_EXECUTABLE)
|
|
set(LUAANDSWIG_FOUND TRUE)
|
|
else()
|
|
find_package(SWIG 2.0)
|
|
if (SWIG_FOUND)
|
|
find_package(Lua)
|
|
if(LUA_FOUND AND SWIG_FOUND)
|
|
mark_as_advanced(
|
|
LUA_LIBRARIES
|
|
LUA_INCLUDE_DIR
|
|
SWIG_EXECUTABLE)
|
|
endif()
|
|
else()
|
|
message(STATUS "SWIG 2 or later is required for Lua support in LLDB but could not be found")
|
|
endif()
|
|
|
|
include(FindPackageHandleStandardArgs)
|
|
find_package_handle_standard_args(LuaAndSwig
|
|
FOUND_VAR
|
|
LUAANDSWIG_FOUND
|
|
REQUIRED_VARS
|
|
LUA_LIBRARIES
|
|
LUA_INCLUDE_DIR
|
|
SWIG_EXECUTABLE)
|
|
endif()
|