b3a0c4d7dc
Summary:
The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue.
This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals.
This patch was mostly written by a shell script with some manual verification afterwards:
```
lang=python
import sys
def sanitize_line(line):
if line.strip().startswith("self.assertTrue(") and " == " in line:
line = line.replace("self.assertTrue(", "self.assertEquals(")
line = line.replace(" == ", ", ", 1)
if line.strip().startswith("self.assertTrue(") and " != " in line:
line = line.replace("self.assertTrue(", "self.assertNotEqual(")
line = line.replace(" != ", ", ", 1)
return line
for a in sys.argv[1:]:
with open(a, "r") as f:
lines = f.readlines()
with open(a, "w") as f:
for line in lines:
f.write(sanitize_line(line))
```
Reviewers: labath, JDevlieghere
Reviewed By: labath
Subscribers: abidh, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74475
104 lines
3.7 KiB
Python
104 lines
3.7 KiB
Python
"""
|
|
Test calling a function that throws an ObjC exception, make sure that it doesn't propagate the exception.
|
|
"""
|
|
|
|
|
|
|
|
import lldb
|
|
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class ExprCommandWithThrowTestCase(TestBase):
|
|
|
|
mydir = TestBase.compute_mydir(__file__)
|
|
|
|
def setUp(self):
|
|
# Call super's setUp().
|
|
TestBase.setUp(self)
|
|
|
|
self.main_source = "call-throws.m"
|
|
self.main_source_spec = lldb.SBFileSpec(self.main_source)
|
|
|
|
@skipUnlessDarwin
|
|
def test(self):
|
|
"""Test calling a function that throws and ObjC exception."""
|
|
self.build()
|
|
self.call_function()
|
|
|
|
def check_after_call(self):
|
|
# Check that we are back where we were before:
|
|
frame = self.thread.GetFrameAtIndex(0)
|
|
self.assertTrue(
|
|
self.orig_frame_pc == frame.GetPC(),
|
|
"Restored the zeroth frame correctly")
|
|
|
|
def call_function(self):
|
|
"""Test calling function that throws."""
|
|
(target, process, self.thread, bkpt) = lldbutil.run_to_source_breakpoint(self,
|
|
'I am about to throw.', self.main_source_spec)
|
|
|
|
options = lldb.SBExpressionOptions()
|
|
options.SetUnwindOnError(True)
|
|
|
|
frame = self.thread.GetFrameAtIndex(0)
|
|
# Store away the PC to check that the functions unwind to the right
|
|
# place after calls
|
|
self.orig_frame_pc = frame.GetPC()
|
|
|
|
value = frame.EvaluateExpression("[my_class callMeIThrow]", options)
|
|
self.assertTrue(value.IsValid())
|
|
self.assertEquals(value.GetError().Success(), False)
|
|
|
|
self.check_after_call()
|
|
|
|
# Okay, now try with a breakpoint in the called code in the case where
|
|
# we are ignoring breakpoint hits.
|
|
handler_bkpt = target.BreakpointCreateBySourceRegex(
|
|
"I felt like it", self.main_source_spec)
|
|
self.assertTrue(handler_bkpt.GetNumLocations() > 0)
|
|
options.SetIgnoreBreakpoints(True)
|
|
options.SetUnwindOnError(True)
|
|
|
|
value = frame.EvaluateExpression("[my_class callMeIThrow]", options)
|
|
|
|
self.assertTrue(
|
|
value.IsValid() and value.GetError().Success() == False)
|
|
self.check_after_call()
|
|
|
|
# Now set the ObjC language breakpoint and make sure that doesn't
|
|
# interfere with the call:
|
|
exception_bkpt = target.BreakpointCreateForException(
|
|
lldb.eLanguageTypeObjC, False, True)
|
|
self.assertTrue(exception_bkpt.GetNumLocations() > 0)
|
|
|
|
options.SetIgnoreBreakpoints(True)
|
|
options.SetUnwindOnError(True)
|
|
|
|
value = frame.EvaluateExpression("[my_class callMeIThrow]", options)
|
|
|
|
self.assertTrue(
|
|
value.IsValid() and value.GetError().Success() == False)
|
|
self.check_after_call()
|
|
|
|
# Now turn off exception trapping, and call a function that catches the exceptions,
|
|
# and make sure the function actually completes, and we get the right
|
|
# value:
|
|
options.SetTrapExceptions(False)
|
|
value = frame.EvaluateExpression("[my_class iCatchMyself]", options)
|
|
self.assertTrue(value.IsValid())
|
|
self.assertTrue(value.GetError().Success())
|
|
self.assertEquals(value.GetValueAsUnsigned(), 57)
|
|
self.check_after_call()
|
|
options.SetTrapExceptions(True)
|
|
|
|
# Now set this unwind on error to false, and make sure that we stop
|
|
# where the exception was thrown
|
|
options.SetUnwindOnError(False)
|
|
value = frame.EvaluateExpression("[my_class callMeIThrow]", options)
|
|
|
|
self.assertTrue(
|
|
value.IsValid() and value.GetError().Success() == False)
|
|
self.check_after_call()
|