Summary:
Around a third of our test sources have LLVM license headers. This patch removes those headers from all test
sources and also fixes any tests that depended on the length of the license header.
The reasons for this are:
* A few tests verify line numbers and will start failing if the number of lines in the LLVM license header changes. Once I landed my patch for valid SourceLocations in debug info we will probably have even more tests that verify line numbers.
* No other LLVM project is putting license headers in its test files to my knowledge.
* They make the test sources much more verbose than they have to be. Several tests have longer license headers than the actual test source.
For the record, the following tests had their line numbers changed to pass with the removal of the license header:
lldb-api :: functionalities/breakpoint/breakpoint_by_line_and_column/TestBreakpointByLineAndColumn.py
lldb-shell :: Reproducer/TestGDBRemoteRepro.test
lldb-shell :: Reproducer/TestMultipleTargets.test
lldb-shell :: Reproducer/TestReuseDirectory.test
lldb-shell :: ExecControl/StopHook/stop-hook-threads.test
lldb-shell :: ExecControl/StopHook/stop-hook.test
lldb-api :: lang/objc/exceptions/TestObjCExceptions.py
Reviewers: #lldb, espindola, JDevlieghere
Reviewed By: #lldb, JDevlieghere
Subscribers: emaste, aprantl, arphaman, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D74839
71 lines
1.5 KiB
C++
71 lines
1.5 KiB
C++
// This test is intended to create a situation in which one thread will be
|
|
// created while the debugger is stepping in another thread.
|
|
|
|
#include "pseudo_barrier.h"
|
|
#include <thread>
|
|
|
|
#define do_nothing()
|
|
|
|
pseudo_barrier_t g_barrier;
|
|
|
|
volatile int g_thread_created = 0;
|
|
volatile int g_test = 0;
|
|
|
|
void *
|
|
step_thread_func ()
|
|
{
|
|
g_test = 0; // Set breakpoint here
|
|
|
|
while (!g_thread_created)
|
|
g_test++;
|
|
|
|
// One more time to provide a continue point
|
|
g_test++; // Continue from here
|
|
|
|
// Return
|
|
return NULL;
|
|
}
|
|
|
|
void *
|
|
create_thread_func (void *input)
|
|
{
|
|
std::thread *step_thread = (std::thread*)input;
|
|
|
|
// Wait until the main thread knows this thread is started.
|
|
pseudo_barrier_wait(g_barrier);
|
|
|
|
// Wait until the other thread is done.
|
|
step_thread->join();
|
|
|
|
// Return
|
|
return NULL;
|
|
}
|
|
|
|
int main ()
|
|
{
|
|
// Use a simple count to simulate a barrier.
|
|
pseudo_barrier_init(g_barrier, 2);
|
|
|
|
// Create a thread to hit the breakpoint.
|
|
std::thread thread_1(step_thread_func);
|
|
|
|
// Wait until the step thread is stepping
|
|
while (g_test < 1)
|
|
do_nothing();
|
|
|
|
// Create a thread to exit while we're stepping.
|
|
std::thread thread_2(create_thread_func, &thread_1);
|
|
|
|
// Wait until that thread is started
|
|
pseudo_barrier_wait(g_barrier);
|
|
|
|
// Let the stepping thread know the other thread is there
|
|
g_thread_created = 1;
|
|
|
|
// Wait for the threads to finish.
|
|
thread_2.join();
|
|
thread_1.join();
|
|
|
|
return 0;
|
|
}
|