Vassil Vassilev 4d75e8d676 [modules] Prefer more complete array types. ...

If we import a module that has a complete array type and one that has an
incomplete array type, the declaration found by name lookup might be the one with
the incomplete type, possibly resulting in rejects-valid.

Now, the name lookup prefers decls with a complete array types. Also,
diagnose cases when the redecl chain has array bound, different from the merge
candidate.

Reviewed by Richard Smith.

llvm-svn: 262189

2016-02-28 19:08:24 +00:00

..

AddRemovePrivate.framework

Verify all the module map files for a pcm are the same on load

2014-08-12 16:42:33 +00:00

AlsoDependsOnModule.framework/Headers

…

anon-namespace

[modules] Fix bug where an anonymous namespace could cause the containing

2015-03-17 02:23:11 +00:00

attr-unavailable

Fix bogus 'method is unavailable' errors with modules

2015-01-12 19:27:00 +00:00

auto-import-unavailable

[modules] PR20507: Avoid silent textual inclusion.

2015-08-17 16:39:30 +00:00

AutolinkTBD.framework

Fix auto-link for text-based dynamic library SDKs.

2015-11-13 19:08:07 +00:00

available-is-better

[modules] PR20507: Avoid silent textual inclusion.

2015-08-17 16:39:30 +00:00

CmdLine.framework/Headers

…

Conflicts

…

cxx-dtor

[modules] Don't clobber a destructor's operator delete when adding another one;

2015-03-10 01:41:22 +00:00

cxx-lookup

[modules] When determining whether a name from a module replaces a name we

2015-02-10 03:28:10 +00:00

declare-use

[modules] PR20507: Avoid silent textual inclusion.

2015-08-17 16:39:30 +00:00

deferred-lookup

[modules] Don't accidentally trigger deserialization from DeclContext::noload_lookup.

2015-02-07 00:45:52 +00:00

DependsOnModule.framework

Add cc1 option '-fmodule-feature' to add custom values for 'requires' decls

2015-02-02 21:56:15 +00:00

elsewhere

…

empty

[Modules] Start making explicit modules produce deterministic output.

2015-03-24 21:18:10 +00:00

exclude-header

…

explicit-build

[modules] Flatten -fmodule-name= and -fmodule-implementation-of= into a single

2016-02-19 22:25:36 +00:00

explicit-build-overlap

[modules] Tests for r245390.

2015-08-18 23:42:50 +00:00

explicit-build-prefer-self

[modules] Fix "prefer own module over others" rule when selecting a module for a header to work in the presence of module hierarchy.

2015-07-10 20:09:49 +00:00

filename

Default getFile() to use the last accessed name in the FileEntry.

2014-08-13 12:34:41 +00:00

HasSubModules.framework

…

header-in-multiple-maps

[modules] If we have a choice between including a file textually and importing

2015-02-13 23:50:20 +00:00

include_next

[modules] Add support for #include_next.

2014-10-20 00:15:49 +00:00

include-relative

…

inferred-attr

Inherit attributes when infering a framework module

2015-01-13 17:47:44 +00:00

initializer_list

[modules] Properly check whether a declaration is std::initializer_list. This

2015-02-24 03:30:14 +00:00

internal-constants

[modules] Rationalize the behavior of Decl::declarationReplaces, and in

2015-11-03 03:13:11 +00:00

invalidate-identifiers

[modules] Fix iterator invalidation issue with names being added to a module

2015-03-11 00:00:51 +00:00

libstdcxx-ambiguous-internal

[modules] Generalize the workaround for multiple ambiguous definitions of

2015-11-04 19:26:32 +00:00

macro-ambiguity

[Modules] Teach Clang to survive ambiguous macros which come from system

2015-03-13 08:29:54 +00:00

macro-hiding

…

macro-masking

[modules] If a module #includes a modular header that #undef's its macro, it

2015-05-02 00:45:56 +00:00

macro-reexport

[modules] PR20507: Avoid silent textual inclusion.

2015-08-17 16:39:30 +00:00

macro-undef-through-pch

…

malformed

[modules] If we import a module, and we've seen a module map that describes the

2014-12-06 03:21:08 +00:00

merge-anon-in-template

[modules] It's possible to merge into the pattern of a class template before we

2015-01-22 01:41:56 +00:00

merge-class-definition-visibility

[modules] Properly merge visibility of class definitions that got merged while

2015-06-25 21:42:33 +00:00

merge-decl-context

[modules] When loading in multiple canonical definitions of a template,

2015-02-27 00:25:58 +00:00

merge-decl-order

[modules] When collecting declarations to complete a redeclaration chain for an

2015-02-12 23:21:45 +00:00

merge-dependent-friends

[modules] Treat friend declarations that are lexically within a dependent

2015-02-07 03:11:11 +00:00

merge-friends

[modules] If a module declares an entity and then imports another declaration

2015-02-06 02:42:59 +00:00

merge-implicit-special-members

[modules] If we add an implicit special member to a class through an update

2015-01-22 03:50:31 +00:00

merge-name-for-linkage

[modules] If we load two declarations with typedef names for linkage purposes

2015-01-22 02:21:23 +00:00

merge-nested-templates

[modules] Sometimes we can deserialize a class member but not have yet

2015-01-24 01:07:20 +00:00

merge-target-features

[modules] Teach the AST reader to handle the case of importing a module

2015-03-14 04:47:43 +00:00

merge-template-friend

[modules] When merging the pattern of a class template definition into a prior

2015-03-11 18:21:02 +00:00

merge-template-members

Add missing file from r228104.

2015-02-04 01:51:12 +00:00

merge-template-pattern-visibility

[modules] When determining the visible module set during template

2015-07-08 02:22:15 +00:00

merge-typedefs

Fix typo.

2014-08-25 23:33:46 +00:00

merge-using-decls

[modules] Merging for class-scope using-declarations.

2014-10-14 02:00:47 +00:00

merge-vtable-codegen

Reland (2x) r230314, "Fix codegen for virtual methods that are (re-) exported from multiple modules."

2015-02-25 19:17:48 +00:00

misplaced

[Modules] More descriptive diagnostics for misplaced import directive

2015-09-19 05:32:57 +00:00

Modified

…

modular_maps

Reinstate r223753, reverted in r223759 due to breakage of clang-tools-extra.

2014-12-10 03:09:48 +00:00

module-map-path-hash

Avoid failure to canonicalize '..'.

2015-07-30 00:26:34 +00:00

Module.framework

[test] Expand a bit on the test case from r231251. NFC.

2015-03-05 03:12:33 +00:00

ModuleDiags

…

ModuleMapLocations

Don't load Framework module.map files when searching subdirectories

2015-02-24 04:58:15 +00:00

modules-with-same-name

…

multiple-include

[modules] When checking the include guard for a header, check whether it's

2015-07-10 22:27:17 +00:00

MutuallyRecursive1.framework/Headers

…

MutuallyRecursive2.framework/Headers

…

NameInDir2.framework

[Modules] Be consistent about finding a module for framework headers

2015-07-02 13:19:48 +00:00

NameInDir.framework

[Modules] Be consistent about finding a module for framework headers

2015-07-02 13:19:48 +00:00

NameInDirInferred.framework/Headers

[Modules] Be consistent about finding a module for framework headers

2015-07-02 13:19:48 +00:00

no-implicit-builds

Add -fno-implicit-modules.

2015-02-20 11:44:41 +00:00

no-linkage

[modules] Fix some more cases where we used to reject a conflict between two

2015-11-17 03:02:41 +00:00

normal-module-map

…

NotAModule.framework/Headers

…

NoUmbrella.framework

…

odr

[modules] Fix false report of an ODR violation when merging friend

2014-08-25 02:10:01 +00:00

oldname

…

pr19692

Remove unused test input.

2014-12-23 19:30:13 +00:00

PR20399

Reduce the PR20399 test case.

2014-10-01 23:16:30 +00:00

PR20786

[modules] PR20786: add (already passing) regression test from the bug report.

2014-08-28 20:14:15 +00:00

PR21687

PR21687: when adding a redeclaration of a function with an implicit exception

2015-03-10 02:00:53 +00:00

PR26179

[modules] Prefer more complete array types.

2016-02-28 19:08:24 +00:00

preprocess

[modules] When using -E, we may try to merge decls despite having no Sema

2015-02-04 23:37:59 +00:00

private

…

private0

…

private1

…

private2

…

private3

Allow use of private headers in different sub-modules.

2015-11-05 15:24:47 +00:00

redecl-found-building-chains

[modules] If we find more formerly-canonical declarations of an entity while

2015-03-16 20:54:07 +00:00

redecl-templates

[modules] Ensure we've imported all declarations of a template before

2015-02-24 02:44:23 +00:00

redecls

Reorganize test/Modules:

2015-01-22 23:07:47 +00:00

require-modular-includes

…

self-import-header

Reorganize test/Modules:

2015-01-22 23:07:47 +00:00

separate_map_tree

…

StdDef

Fix interaction of max_align_t and modules.

2014-10-03 00:31:35 +00:00

stress1

Add file missed from r244409.

2015-08-09 01:50:14 +00:00

string_names

…

subdir

…

submodule-visibility

[modules] Before checking whether the controlling macro of a header is defined,

2015-07-01 02:29:35 +00:00

submodules

…

submodules-merge-defs

Allow non-defining declarations of class template partial specializations to

2015-12-11 22:39:52 +00:00

System/usr/include

[Modules] Add Darwin-specific compatibility module map parsing hacks

2015-08-13 17:13:33 +00:00

template-default-args

Add new test file missing from r247486.

2015-09-11 22:54:01 +00:00

template-specialization-visibility

…

thread-safety

[modules] Fix thread safety analysis to cope with merging of FieldDecls across modules.

2015-08-12 02:17:52 +00:00

undefined-type-fixit

…

unnecessary-module-map-parsing

…

update-after-load

…

update-exception-spec

[modules] Remove redundant import of lexical decls when building a lookup table

2015-03-23 03:25:59 +00:00

using-decl-redecl

[modules] Don't diagnose a conflict between two using-declarations that name equivalent internal linkage entities.

2016-01-12 20:34:32 +00:00

va_list

[modules] Fix merging of __va_list_tag's implicit special member functions.

2015-10-13 00:23:25 +00:00

wildcard-submodule-exports

…

working-dir-test/Test.framework

[modules] Fix issue where building a module from a relative path when -working-directory option is set, results in error.

2015-07-31 00:58:32 +00:00

autolink-sub2.h

…

autolink-sub3.h

…

autolink-sub3.pch

…

autolink-sub.h

…

autolink.h

…

builtin_sub.h

Fix missing builtin identifier infos with PCH+modules

2015-10-28 22:25:37 +00:00

builtin.h

Fix predefine for __NSConstantString struct type

2016-02-04 00:55:24 +00:00

c-header-bad.h

…

c-header.h

…

category_bottom.h

…

category_left_sub.h

…

category_left.h

…

category_other.h

…

category_right_sub.h

…

category_right.h

Don't synthesize an ImportDecl for a module named in -fmodule-implementation-of

2016-02-05 01:10:05 +00:00

category_top.h

…

config.h

…

crash.h

[Modules] Test lock file removed on signal

2015-06-29 17:09:24 +00:00

cxx-decls-imported.h

[modules] For an inheriting constructor, the inherited constructor is stored in

2015-02-27 01:57:00 +00:00

cxx-decls-merged.h

[modules] For an inheriting constructor, the inherited constructor is stored in

2015-02-27 01:57:00 +00:00

cxx-decls-premerged.h

Add some missing test coverage for merging 'extern "C"' functions with modules.

2014-08-29 22:33:38 +00:00

cxx-decls-unimported.h

…

cxx-header.h

…

cxx-inline-namespace-b.h

…

cxx-inline-namespace.h

…

cxx-irgen-left.h

…

cxx-irgen-right.h

…

cxx-irgen-top.h

[modules] Fix a rejects-valid resulting from emitting an inline function

2014-08-13 21:15:09 +00:00

cxx-linkage-cache.h

…

cxx-many-overloads.h

…

cxx-templates-a.h

[modules] When building an injected-class-name type, we may have to insert it

2014-10-21 21:15:18 +00:00

cxx-templates-b-impl.h

…

cxx-templates-b.h

[modules] When building an injected-class-name type, we may have to insert it

2014-10-21 21:15:18 +00:00

cxx-templates-c.h

[modules] When building an injected-class-name type, we may have to insert it

2014-10-21 21:15:18 +00:00

cxx-templates-common.h

[modules] When completing the redecl chain for an anonymous declaration in a

2014-08-28 05:44:07 +00:00

cxx-templates-d.h

[modules] When building an injected-class-name type, we may have to insert it

2014-10-21 21:15:18 +00:00

cxx-templates-textual.h

[modules] Put class template declarations into the scope in which they're

2014-08-23 00:49:01 +00:00

DebugCXX.h

Module Debugging: Fine-tune the condition that determines whether a type

2016-01-20 01:29:34 +00:00

DebugObjC.h

Module Debugging: Add Objective-C testcases for anonymous tag decls. (NFC)

2016-01-19 23:42:56 +00:00

DebugSubmoduleA.h

Module debugging: Support submodules in the PCM/PCH debug info.

2015-09-20 16:51:35 +00:00

DebugSubmoduleB.h

Module debugging: Support submodules in the PCM/PCH debug info.

2015-09-20 16:51:35 +00:00

decl2.h

…

decl.h

…

def-include.h

…

def.h

…

dependency-gen-base2.modulemap

[modules] When constructing paths relative to a module, strip out /./ directory

2014-12-11 20:50:24 +00:00

dependency-gen-base.modulemap

[modules] When constructing paths relative to a module, strip out /./ directory

2014-12-11 20:50:24 +00:00

dependency-gen-included2.h

[modules] When constructing paths relative to a module, strip out /./ directory

2014-12-11 20:50:24 +00:00

dependency-gen-included.h

[modules] When constructing paths relative to a module, strip out /./ directory

2014-12-11 20:50:24 +00:00

dependency-gen.h

[modules] When constructing paths relative to a module, strip out /./ directory

2014-12-11 20:50:24 +00:00

diag_pragma.h

…

diagnostics-aux-2.modulemap

Add file missed from r242105.

2015-07-14 02:40:33 +00:00

diagnostics-aux.modulemap

[modules] When diagnosing errors in module map files found by 'extern module' declarations, show how we got to that module map file.

2015-07-14 02:06:01 +00:00

diamond_bottom.h

…

diamond_left.h

Avoid a couple of assertions when preprocessing with modules

2014-09-10 21:29:41 +00:00

diamond_right.h

…

diamond_top.h

Avoid a couple of assertions when preprocessing with modules

2014-09-10 21:29:41 +00:00

diamond.h

…

dummy.h

[modules] Make sure we always include the contents of private headers when

2016-01-08 22:36:45 +00:00

elaborated-type-structs.h

Reapply "[Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag"

2015-12-11 22:05:13 +00:00

empty.h

[modules] Don't assert if the same header is named as both a public and a

2015-03-09 23:46:50 +00:00

ExtensionTestA.h

Introduce module file extensions to piggy-back data onto module files.

2015-11-03 18:33:07 +00:00

ignored_macros.h

…

import-decl.h

…

ImportNameInDir.h

[Modules] Be consistent about finding a module for framework headers

2015-07-02 13:19:48 +00:00

incomplete_mod_missing.h

…

incomplete_mod.h

…

irgen.h

…

linkage-merge-bar.h

…

linkage-merge-foo.h

…

linkage-merge-sub.h

…

load_failure.h

…

lookup_left.h

…

lookup_left.hpp

…

lookup_right.h

…

lookup_right.hpp

…

macros_bottom.h

…

macros_left.h

…

macros_other.h

…

macros_right_undef.h

…

macros_right.h

…

macros_top_b.h

…

macros_top_c.h

…

macros_top.h

…

macros-indirect.h

[modules] Properly attribute macros to modules if they're in a file textually included into a file in the module.

2015-04-23 22:58:06 +00:00

macros.h

[modules] Properly attribute macros to modules if they're in a file textually included into a file in the module.

2015-04-23 22:58:06 +00:00

MethodPoolA.h

…

MethodPoolASub2.h

…

MethodPoolASub.h

…

MethodPoolB.h

…

MethodPoolBSub2.h

…

MethodPoolBSub.h

…

modular_maps-moduleb-cwd.map

Reinstate r223753, reverted in r223759 due to breakage of clang-tools-extra.

2014-12-10 03:09:48 +00:00

module_private_left.h

…

module_private_right.h

…

module.map

Reapply "[Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag"

2015-12-11 22:05:13 +00:00

namespaces-left.h

[modules] Fix crash when writing an update record for a redeclaration of an empty namespace.

2015-07-08 21:15:32 +00:00

namespaces-right.h

[modules] Fix crash when writing an update record for a redeclaration of an empty namespace.

2015-07-08 21:15:32 +00:00

namespaces-top.h

[modules] Fix crash when writing an update record for a redeclaration of an empty namespace.

2015-07-08 21:15:32 +00:00

pch-used.h

Fix PCHs that import more than one module

2014-09-08 20:36:26 +00:00

point.h

…

preprocess-prefix.h

Avoid a couple of assertions when preprocessing with modules

2014-09-10 21:29:41 +00:00

recursive1.h

…

recursive2.h

…

recursive_visibility_a1_inner.h

…

recursive_visibility_a2_more_inner.h

…

recursive_visibility_b.h

…

recursive_visibility_c.h

…

redecl_namespaces_left.h

…

redecl_namespaces_right.h

…

redecl-add-after-load-decls.h

[modules] When merging class definitions, make the retained definition visible

2015-03-27 21:16:39 +00:00

redecl-add-after-load-top.h

…

redecl-add-after-load.h

…

redecl-merge-bottom-prefix.h

…

redecl-merge-bottom.h

…

redecl-merge-left-left.h

…

redecl-merge-left.h

…

redecl-merge-right.h

…

redecl-merge-top-explicit.h

…

redecl-merge-top.h

…

redeclarations_left.h

…

redeclarations_right.h

…

relative-dep-gen-1.h

Add some file content to avoid test failures on content-addressed file systems.

2014-12-06 22:12:07 +00:00

relative-dep-gen-2.h

Add some file content to avoid test failures on content-addressed file systems.

2014-12-06 22:12:07 +00:00

relative-dep-gen-cwd.modulemap

Reinstate r223753, reverted in r223759 due to breakage of clang-tools-extra.

2014-12-10 03:09:48 +00:00

relative-dep-gen.modulemap

[modules] If we import a module, and we've seen a module map that describes the

2014-12-06 03:21:08 +00:00

templates-left.h

[modules] Use DeclContext::equals rather than == on DeclContext* when

2014-09-03 02:33:22 +00:00

templates-right.h

[modules] When instantiating the contents of an imported CXXRecordDecl, we can

2015-08-11 22:00:24 +00:00

templates-top.h

[modules] When instantiating the contents of an imported CXXRecordDecl, we can

2015-08-11 22:00:24 +00:00

typedef-tag-hidden.h

[modules] Allow "redefinition" of typedef of anon tag from unimported submodule

2015-11-14 03:26:14 +00:00

typedef-tag.h

[modules] Allow "redefinition" of typedef of anon tag from unimported submodule

2015-11-14 03:26:14 +00:00

use-builtin.h

Fix missing builtin identifier infos with PCH+modules

2015-10-28 22:25:37 +00:00

using-decl-a.h

[modules] Make sure we make hidden UsingShadowDecls visible to redeclaration

2015-09-15 18:51:56 +00:00

using-decl-b.h

[modules] Make sure we make hidden UsingShadowDecls visible to redeclaration

2015-09-15 18:51:56 +00:00

warn-unused-local-typedef.h

Add -Wunused-local-typedef, a warning that finds unused local typedefs.

2014-09-06 01:25:55 +00:00

warning.h

…

weird_objc.h

…