33b38339a0
Close #52781: for LTO, the inline asm diagnostic uses `<inline asm>` as the file name (lib/CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp) and it is unclear which module has the issue. With this patch, we will see the module name (say `asm.o`) before `<inline asm>` with ThinLTO. ``` % clang -flto=thin -c asm.c && myld.lld asm.o -e f ld.lld: error: asm.o <inline asm>:1:2: invalid instruction mnemonic 'invalid' invalid ^~~~~~~ ``` For regular LTO, unfortunately the original module name is lost and we only get ld-temp.o. Reviewed By: #lld-macho, ychen, Jez Ng Differential Revision: https://reviews.llvm.org/D118434
23 lines
703 B
LLVM
23 lines
703 B
LLVM
; REQUIRES: x86
|
|
; RUN: llvm-as %s -o %t.bc
|
|
; RUN: not %lld %t.bc -o /dev/null 2>&1 | FileCheck %s --check-prefix=REGULAR
|
|
|
|
;; For regular LTO, the original module name is lost.
|
|
;; TODO Fix the line number
|
|
; REGULAR: error: ld-temp.o <inline asm>:3:1: invalid instruction mnemonic 'invalid'
|
|
|
|
; RUN: opt -module-summary %s -o %t.bc
|
|
; RUN: not %lld %t.bc -o /dev/null 2>&1 | FileCheck %s --check-prefix=THIN
|
|
|
|
; THIN: error: {{.*}}.bc <inline asm>:2:1: invalid instruction mnemonic 'invalid'
|
|
|
|
target triple = "x86_64-apple-macosx10.15.0"
|
|
target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
module asm ".text"
|
|
module asm "invalid"
|
|
|
|
define void @main() {
|
|
ret void
|
|
}
|