ff13189c5d
How many place you need to modify when implementing a new extension for RISC-V? At least 7 places as I know: - Add new SubtargetFeature at RISCV.td - -march parser in RISCV.cpp - RISCVTargetInfo::initFeatureMap@RISCV.cpp for handling feature vector. - RISCVTargetInfo::getTargetDefines@RISCV.cpp for pre-define marco. - Arch string parser for ELF attribute in RISCVAsmParser.cpp - ELF attribute emittion in RISCVAsmParser.cpp, and make sure it's in canonical order... - ELF attribute emittion in RISCVTargetStreamer.cpp, and again, must in canonical order... And now, this patch provide an unified infrastructure for handling (almost) everything of RISC-V arch string. After this patch, you only need to update 2 places for implement an extension for RISC-V: - Add new SubtargetFeature at RISCV.td, hmmm, it's hard to avoid. - Add new entry to RISCVSupportedExtension@RISCVISAInfo.cpp or SupportedExperimentalExtensions@RISCVISAInfo.cpp . Most codes are come from existing -march parser, but with few new feature/bug fixes: - Accept version for -march, e.g. -march=rv32i2p0. - Reject version info with `p` but without minor version number like `rv32i2p`. Differential Revision: https://reviews.llvm.org/D105168
32 lines
1.1 KiB
ArmAsm
32 lines
1.1 KiB
ArmAsm
## Negative tests:
|
|
## - Feed integer value to string type attribute.
|
|
## - Feed string value to integer type attribute.
|
|
## - Invalid arch string.
|
|
|
|
# RUN: not llvm-mc %s -triple=riscv32 -filetype=asm 2>&1 | FileCheck %s
|
|
# RUN: not llvm-mc %s -triple=riscv64 -filetype=asm 2>&1 | FileCheck %s
|
|
|
|
.attribute arch, "foo"
|
|
# CHECK: [[@LINE-1]]:18: error: invalid arch name 'foo', string must begin with rv32{i,e,g} or rv64{i,g}
|
|
|
|
.attribute arch, "rv32i2p0_y2p0"
|
|
# CHECK: [[@LINE-1]]:18: error: invalid arch name 'rv32i2p0_y2p0', invalid standard user-level extension 'y'
|
|
|
|
.attribute stack_align, "16"
|
|
# CHECK: [[@LINE-1]]:25: error: expected numeric constant
|
|
|
|
.attribute unaligned_access, "0"
|
|
# CHECK: [[@LINE-1]]:30: error: expected numeric constant
|
|
|
|
.attribute priv_spec, "2"
|
|
# CHECK: [[@LINE-1]]:23: error: expected numeric constant
|
|
|
|
.attribute priv_spec_minor, "0"
|
|
# CHECK: [[@LINE-1]]:29: error: expected numeric constant
|
|
|
|
.attribute priv_spec_revision, "0"
|
|
# CHECK: [[@LINE-1]]:32: error: expected numeric constant
|
|
|
|
.attribute arch, 30
|
|
# CHECK: [[@LINE-1]]:18: error: expected string constant
|