f3ad8cf00e
There was some ad-hoc handling of liveness and manifest to avoid breaking CGSCC guarantees. Things always slipped through though. This cleanup will: 1) Prevent us from manifesting any "information" outside the CGSCC. This might be too conservative but we need to opt-in to annotation not try to avoid some problematic ones. 2) Avoid running any liveness analysis outside the CGSCC. We did have some AAIsDeadFunction handling to this end but we need this for all AAIsDead classes. The reason is that AAIsDead information is only correct if we actually manifest it, since we don't (see point 1) we cannot actually derive/use it at all. We are currently trying to avoid running any AA updates outside the CGSCC but that seems to impact things quite a bit. 3) Assert, don't check, that our modifications (during cleanup) modifies only CGSCC functions.
183 lines
8.1 KiB
LLVM
183 lines
8.1 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
|
|
; RUN: opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=2 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=2 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_OPM,NOT_CGSCC_NPM,NOT_TUNIT_OPM,IS__TUNIT____,IS________NPM,IS__TUNIT_NPM
|
|
; RUN: opt -attributor-cgscc -enable-new-pm=0 -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_NPM,IS__CGSCC____,IS________OPM,IS__CGSCC_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_OPM,IS__CGSCC____,IS________NPM,IS__CGSCC_NPM
|
|
|
|
; The original C source looked like this:
|
|
;
|
|
; long long a101, b101, e101;
|
|
; volatile long c101;
|
|
; int d101;
|
|
;
|
|
; static inline int bar(p1, p2)
|
|
; {
|
|
; return 0;
|
|
; }
|
|
;
|
|
; void foo(unsigned p1)
|
|
; {
|
|
; long long *f = &b101, *g = &e101;
|
|
; c101 = 0;
|
|
; (void)((*f |= a101) - (*g = bar(d101)));
|
|
; c101 = (*f |= a101 &= p1) == d101;
|
|
; }
|
|
;
|
|
; When compiled with Clang it gives a warning
|
|
; warning: too few arguments in call to 'bar'
|
|
;
|
|
; This ll reproducer has been reduced to only include tha call.
|
|
;
|
|
; Note that -lint will report this as UB, but it passes -verify.
|
|
|
|
; This test is just to verify that we do not crash/assert due to mismatch in
|
|
; argument count between the caller and callee.
|
|
|
|
; FIXME we should recognize this as UB and make it an unreachable.
|
|
|
|
define dso_local i16 @foo(i16 %a) {
|
|
; IS__TUNIT____: Function Attrs: norecurse
|
|
; IS__TUNIT____-LABEL: define {{[^@]+}}@foo
|
|
; IS__TUNIT____-SAME: (i16 [[A:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__TUNIT____-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar to i16 (i16)*)(i16 [[A]])
|
|
; IS__TUNIT____-NEXT: ret i16 [[CALL]]
|
|
;
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@foo
|
|
; IS__CGSCC_OPM-SAME: (i16 [[A:%.*]]) {
|
|
; IS__CGSCC_OPM-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar to i16 (i16)*)(i16 [[A]])
|
|
; IS__CGSCC_OPM-NEXT: ret i16 [[CALL]]
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: nofree nosync nounwind readnone
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@foo
|
|
; IS__CGSCC_NPM-SAME: (i16 [[A:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__CGSCC_NPM-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar to i16 (i16)*)(i16 [[A]])
|
|
; IS__CGSCC_NPM-NEXT: ret i16 [[CALL]]
|
|
;
|
|
%call = call i16 bitcast (i16 (i16, i16) * @bar to i16 (i16) *)(i16 %a)
|
|
ret i16 %call
|
|
}
|
|
|
|
define internal i16 @bar(i16 %p1, i16 %p2) {
|
|
; NOT_CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; NOT_CGSCC_OPM-LABEL: define {{[^@]+}}@bar
|
|
; NOT_CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]]) #[[ATTR1:[0-9]+]] {
|
|
; NOT_CGSCC_OPM-NEXT: ret i16 0
|
|
;
|
|
; IS__CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@bar
|
|
; IS__CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__CGSCC_OPM-NEXT: ret i16 0
|
|
;
|
|
ret i16 0
|
|
}
|
|
|
|
define dso_local i16 @foo2(i16 %a) {
|
|
; IS__TUNIT____: Function Attrs: norecurse
|
|
; IS__TUNIT____-LABEL: define {{[^@]+}}@foo2
|
|
; IS__TUNIT____-SAME: (i16 [[A:%.*]]) #[[ATTR0]] {
|
|
; IS__TUNIT____-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar2 to i16 (i16)*)(i16 [[A]])
|
|
; IS__TUNIT____-NEXT: ret i16 [[CALL]]
|
|
;
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@foo2
|
|
; IS__CGSCC_OPM-SAME: (i16 [[A:%.*]]) {
|
|
; IS__CGSCC_OPM-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar2 to i16 (i16)*)(i16 [[A]])
|
|
; IS__CGSCC_OPM-NEXT: ret i16 [[CALL]]
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: nofree nosync nounwind readnone
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@foo2
|
|
; IS__CGSCC_NPM-SAME: (i16 [[A:%.*]]) #[[ATTR0]] {
|
|
; IS__CGSCC_NPM-NEXT: [[CALL:%.*]] = call i16 bitcast (i16 (i16, i16)* @bar2 to i16 (i16)*)(i16 [[A]])
|
|
; IS__CGSCC_NPM-NEXT: ret i16 [[CALL]]
|
|
;
|
|
%call = call i16 bitcast (i16 (i16, i16) * @bar2 to i16 (i16) *)(i16 %a)
|
|
ret i16 %call
|
|
}
|
|
|
|
define internal i16 @bar2(i16 %p1, i16 %p2) {
|
|
; NOT_CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; NOT_CGSCC_OPM-LABEL: define {{[^@]+}}@bar2
|
|
; NOT_CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]]) #[[ATTR1]] {
|
|
; NOT_CGSCC_OPM-NEXT: [[A:%.*]] = add i16 [[P1]], [[P2]]
|
|
; NOT_CGSCC_OPM-NEXT: ret i16 [[A]]
|
|
;
|
|
; IS__CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@bar2
|
|
; IS__CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]]) #[[ATTR0]] {
|
|
; IS__CGSCC_OPM-NEXT: [[A:%.*]] = add i16 [[P1]], [[P2]]
|
|
; IS__CGSCC_OPM-NEXT: ret i16 [[A]]
|
|
;
|
|
%a = add i16 %p1, %p2
|
|
ret i16 %a
|
|
}
|
|
|
|
|
|
;-------------------------------------------------------------------------------
|
|
; Additional tests to verify that we still optimize when having a mismatch
|
|
; in argument count due to varargs (as long as all non-variadic arguments have
|
|
; been provided),
|
|
|
|
define dso_local i16 @vararg_tests(i16 %a) {
|
|
; IS__TUNIT____: Function Attrs: norecurse
|
|
; IS__TUNIT____-LABEL: define {{[^@]+}}@vararg_tests
|
|
; IS__TUNIT____-SAME: (i16 [[A:%.*]]) #[[ATTR0]] {
|
|
; IS__TUNIT____-NEXT: [[CALL2:%.*]] = call i16 bitcast (i16 (i16, i16, ...)* @vararg_no_prop to i16 (i16)*)(i16 noundef 7)
|
|
; IS__TUNIT____-NEXT: [[ADD:%.*]] = add i16 7, [[CALL2]]
|
|
; IS__TUNIT____-NEXT: ret i16 [[ADD]]
|
|
;
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@vararg_tests
|
|
; IS__CGSCC_OPM-SAME: (i16 [[A:%.*]]) {
|
|
; IS__CGSCC_OPM-NEXT: [[CALL2:%.*]] = call i16 bitcast (i16 (i16, i16, ...)* @vararg_no_prop to i16 (i16)*)(i16 7)
|
|
; IS__CGSCC_OPM-NEXT: [[ADD:%.*]] = add i16 7, [[CALL2]]
|
|
; IS__CGSCC_OPM-NEXT: ret i16 [[ADD]]
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: nofree nosync nounwind readnone
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@vararg_tests
|
|
; IS__CGSCC_NPM-SAME: (i16 [[A:%.*]]) #[[ATTR0]] {
|
|
; IS__CGSCC_NPM-NEXT: [[CALL2:%.*]] = call i16 bitcast (i16 (i16, i16, ...)* @vararg_no_prop to i16 (i16)*)(i16 7)
|
|
; IS__CGSCC_NPM-NEXT: [[ADD:%.*]] = add i16 7, [[CALL2]]
|
|
; IS__CGSCC_NPM-NEXT: ret i16 [[ADD]]
|
|
;
|
|
%call1 = call i16 (i16, ...) @vararg_prop(i16 7, i16 8, i16 %a)
|
|
%call2 = call i16 bitcast (i16 (i16, i16, ...) * @vararg_no_prop to i16 (i16) *) (i16 7)
|
|
%add = add i16 %call1, %call2
|
|
ret i16 %add
|
|
}
|
|
|
|
define internal i16 @vararg_prop(i16 %p1, ...) {
|
|
; IS__CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@vararg_prop
|
|
; IS__CGSCC_OPM-SAME: (i16 [[P1:%.*]], ...) #[[ATTR0]] {
|
|
; IS__CGSCC_OPM-NEXT: ret i16 7
|
|
;
|
|
; IS__CGSCC_NPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@vararg_prop
|
|
; IS__CGSCC_NPM-SAME: (i16 [[P1:%.*]], ...) #[[ATTR1]] {
|
|
; IS__CGSCC_NPM-NEXT: ret i16 7
|
|
;
|
|
ret i16 %p1
|
|
}
|
|
|
|
define internal i16 @vararg_no_prop(i16 %p1, i16 %p2, ...) {
|
|
; NOT_CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; NOT_CGSCC_OPM-LABEL: define {{[^@]+}}@vararg_no_prop
|
|
; NOT_CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]], ...) #[[ATTR1]] {
|
|
; NOT_CGSCC_OPM-NEXT: ret i16 7
|
|
;
|
|
; IS__CGSCC_OPM: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@vararg_no_prop
|
|
; IS__CGSCC_OPM-SAME: (i16 [[P1:%.*]], i16 [[P2:%.*]], ...) #[[ATTR0]] {
|
|
; IS__CGSCC_OPM-NEXT: ret i16 7
|
|
;
|
|
ret i16 %p1
|
|
}
|
|
|
|
;.
|
|
; IS__TUNIT____: attributes #[[ATTR0]] = { norecurse }
|
|
; IS__TUNIT____: attributes #[[ATTR1]] = { nofree norecurse nosync nounwind readnone willreturn }
|
|
;.
|
|
; IS__CGSCC_OPM: attributes #[[ATTR0]] = { nofree norecurse nosync nounwind readnone willreturn }
|
|
;.
|
|
; IS__CGSCC_NPM: attributes #[[ATTR0]] = { nofree nosync nounwind readnone }
|
|
; IS__CGSCC_NPM: attributes #[[ATTR1]] = { nofree norecurse nosync nounwind readnone willreturn }
|
|
;.
|