f3ad8cf00e
There was some ad-hoc handling of liveness and manifest to avoid breaking CGSCC guarantees. Things always slipped through though. This cleanup will: 1) Prevent us from manifesting any "information" outside the CGSCC. This might be too conservative but we need to opt-in to annotation not try to avoid some problematic ones. 2) Avoid running any liveness analysis outside the CGSCC. We did have some AAIsDeadFunction handling to this end but we need this for all AAIsDead classes. The reason is that AAIsDead information is only correct if we actually manifest it, since we don't (see point 1) we cannot actually derive/use it at all. We are currently trying to avoid running any AA updates outside the CGSCC but that seems to impact things quite a bit. 3) Assert, don't check, that our modifications (during cleanup) modifies only CGSCC functions.
145 lines
6.5 KiB
LLVM
145 lines
6.5 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals
|
|
; RUN: opt -attributor -enable-new-pm=0 -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=6 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_NPM,NOT_CGSCC_OPM,NOT_TUNIT_NPM,IS__TUNIT____,IS________OPM,IS__TUNIT_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor -attributor-manifest-internal -attributor-max-iterations-verify -attributor-annotate-decl-cs -attributor-max-iterations=6 -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_CGSCC_OPM,NOT_CGSCC_NPM,NOT_TUNIT_OPM,IS__TUNIT____,IS________NPM,IS__TUNIT_NPM
|
|
; RUN: opt -attributor-cgscc -enable-new-pm=0 -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_NPM,IS__CGSCC____,IS________OPM,IS__CGSCC_OPM
|
|
; RUN: opt -aa-pipeline=basic-aa -passes=attributor-cgscc -attributor-manifest-internal -attributor-annotate-decl-cs -S < %s | FileCheck %s --check-prefixes=CHECK,NOT_TUNIT_NPM,NOT_TUNIT_OPM,NOT_CGSCC_OPM,IS__CGSCC____,IS________NPM,IS__CGSCC_NPM
|
|
; PR36485
|
|
; musttail call result can't be replaced with a constant, unless the call can be removed
|
|
|
|
declare i32 @external()
|
|
|
|
define i8* @start(i8 %v) {
|
|
;
|
|
; IS__TUNIT_OPM-LABEL: define {{[^@]+}}@start
|
|
; IS__TUNIT_OPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS__TUNIT_OPM-NEXT: [[C1:%.*]] = icmp eq i8 [[V]], 0
|
|
; IS__TUNIT_OPM-NEXT: br i1 [[C1]], label [[TRUE:%.*]], label [[FALSE:%.*]]
|
|
; IS__TUNIT_OPM: true:
|
|
; IS__TUNIT_OPM-NEXT: [[CA:%.*]] = musttail call i8* @side_effects(i8 [[V]])
|
|
; IS__TUNIT_OPM-NEXT: ret i8* [[CA]]
|
|
; IS__TUNIT_OPM: false:
|
|
; IS__TUNIT_OPM-NEXT: [[C2:%.*]] = icmp eq i8 [[V]], 1
|
|
; IS__TUNIT_OPM-NEXT: br i1 [[C2]], label [[C2_TRUE:%.*]], label [[C2_FALSE:%.*]]
|
|
; IS__TUNIT_OPM: c2_true:
|
|
; IS__TUNIT_OPM-NEXT: ret i8* null
|
|
; IS__TUNIT_OPM: c2_false:
|
|
; IS__TUNIT_OPM-NEXT: [[CA2:%.*]] = musttail call i8* @dont_zap_me(i8 undef)
|
|
; IS__TUNIT_OPM-NEXT: ret i8* [[CA2]]
|
|
;
|
|
; IS__TUNIT_NPM-LABEL: define {{[^@]+}}@start
|
|
; IS__TUNIT_NPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS__TUNIT_NPM-NEXT: [[C1:%.*]] = icmp eq i8 [[V]], 0
|
|
; IS__TUNIT_NPM-NEXT: br i1 [[C1]], label [[TRUE:%.*]], label [[FALSE:%.*]]
|
|
; IS__TUNIT_NPM: true:
|
|
; IS__TUNIT_NPM-NEXT: [[CA:%.*]] = musttail call i8* @side_effects(i8 undef)
|
|
; IS__TUNIT_NPM-NEXT: ret i8* [[CA]]
|
|
; IS__TUNIT_NPM: false:
|
|
; IS__TUNIT_NPM-NEXT: [[C2:%.*]] = icmp eq i8 [[V]], 1
|
|
; IS__TUNIT_NPM-NEXT: br i1 [[C2]], label [[C2_TRUE:%.*]], label [[C2_FALSE:%.*]]
|
|
; IS__TUNIT_NPM: c2_true:
|
|
; IS__TUNIT_NPM-NEXT: ret i8* null
|
|
; IS__TUNIT_NPM: c2_false:
|
|
; IS__TUNIT_NPM-NEXT: [[CA2:%.*]] = musttail call i8* @dont_zap_me(i8 undef)
|
|
; IS__TUNIT_NPM-NEXT: ret i8* [[CA2]]
|
|
;
|
|
; IS__CGSCC_OPM-LABEL: define {{[^@]+}}@start
|
|
; IS__CGSCC_OPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS__CGSCC_OPM-NEXT: [[C1:%.*]] = icmp eq i8 [[V]], 0
|
|
; IS__CGSCC_OPM-NEXT: br i1 [[C1]], label [[TRUE:%.*]], label [[FALSE:%.*]]
|
|
; IS__CGSCC_OPM: true:
|
|
; IS__CGSCC_OPM-NEXT: [[CA:%.*]] = musttail call i8* @side_effects(i8 [[V]])
|
|
; IS__CGSCC_OPM-NEXT: ret i8* [[CA]]
|
|
; IS__CGSCC_OPM: false:
|
|
; IS__CGSCC_OPM-NEXT: [[C2:%.*]] = icmp eq i8 [[V]], 1
|
|
; IS__CGSCC_OPM-NEXT: br i1 [[C2]], label [[C2_TRUE:%.*]], label [[C2_FALSE:%.*]]
|
|
; IS__CGSCC_OPM: c2_true:
|
|
; IS__CGSCC_OPM-NEXT: ret i8* null
|
|
; IS__CGSCC_OPM: c2_false:
|
|
; IS__CGSCC_OPM-NEXT: [[CA2:%.*]] = musttail call i8* @dont_zap_me(i8 [[V]])
|
|
; IS__CGSCC_OPM-NEXT: ret i8* [[CA2]]
|
|
;
|
|
; IS__CGSCC_NPM-LABEL: define {{[^@]+}}@start
|
|
; IS__CGSCC_NPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS__CGSCC_NPM-NEXT: [[C1:%.*]] = icmp eq i8 [[V]], 0
|
|
; IS__CGSCC_NPM-NEXT: br i1 [[C1]], label [[TRUE:%.*]], label [[FALSE:%.*]]
|
|
; IS__CGSCC_NPM: true:
|
|
; IS__CGSCC_NPM-NEXT: [[CA:%.*]] = musttail call i8* @side_effects(i8 undef)
|
|
; IS__CGSCC_NPM-NEXT: ret i8* [[CA]]
|
|
; IS__CGSCC_NPM: false:
|
|
; IS__CGSCC_NPM-NEXT: [[C2:%.*]] = icmp eq i8 [[V]], 1
|
|
; IS__CGSCC_NPM-NEXT: br i1 [[C2]], label [[C2_TRUE:%.*]], label [[C2_FALSE:%.*]]
|
|
; IS__CGSCC_NPM: c2_true:
|
|
; IS__CGSCC_NPM-NEXT: ret i8* null
|
|
; IS__CGSCC_NPM: c2_false:
|
|
; IS__CGSCC_NPM-NEXT: [[CA2:%.*]] = musttail call i8* @dont_zap_me(i8 [[V]])
|
|
; IS__CGSCC_NPM-NEXT: ret i8* [[CA2]]
|
|
;
|
|
%c1 = icmp eq i8 %v, 0
|
|
br i1 %c1, label %true, label %false
|
|
true:
|
|
; FIXME: propagate the value information for %v
|
|
%ca = musttail call i8* @side_effects(i8 %v)
|
|
ret i8* %ca
|
|
false:
|
|
%c2 = icmp eq i8 %v, 1
|
|
br i1 %c2, label %c2_true, label %c2_false
|
|
c2_true:
|
|
%ca1 = musttail call i8* @no_side_effects(i8 %v)
|
|
ret i8* %ca1
|
|
c2_false:
|
|
%ca2 = musttail call i8* @dont_zap_me(i8 %v)
|
|
ret i8* %ca2
|
|
}
|
|
|
|
define internal i8* @side_effects(i8 %v) {
|
|
; IS________OPM-LABEL: define {{[^@]+}}@side_effects
|
|
; IS________OPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS________OPM-NEXT: [[I1:%.*]] = call i32 @external()
|
|
; IS________OPM-NEXT: [[CA:%.*]] = musttail call i8* @start(i8 [[V]])
|
|
; IS________OPM-NEXT: ret i8* [[CA]]
|
|
;
|
|
; IS________NPM-LABEL: define {{[^@]+}}@side_effects
|
|
; IS________NPM-SAME: (i8 [[V:%.*]]) {
|
|
; IS________NPM-NEXT: [[I1:%.*]] = call i32 @external()
|
|
; IS________NPM-NEXT: [[CA:%.*]] = musttail call i8* @start(i8 0)
|
|
; IS________NPM-NEXT: ret i8* [[CA]]
|
|
;
|
|
%i1 = call i32 @external()
|
|
|
|
; since this goes back to `start` the SCPP should be see that the return value
|
|
; is always `null`.
|
|
; The call can't be removed due to `external` call above, though.
|
|
|
|
%ca = musttail call i8* @start(i8 %v)
|
|
|
|
; Thus the result must be returned anyway
|
|
ret i8* %ca
|
|
}
|
|
|
|
define internal i8* @no_side_effects(i8 %v) readonly nounwind {
|
|
; IS__CGSCC____: Function Attrs: nofree norecurse nosync nounwind readnone willreturn
|
|
; IS__CGSCC____-LABEL: define {{[^@]+}}@no_side_effects
|
|
; IS__CGSCC____-SAME: (i8 [[V:%.*]]) #[[ATTR0:[0-9]+]] {
|
|
; IS__CGSCC____-NEXT: ret i8* null
|
|
;
|
|
ret i8* null
|
|
}
|
|
|
|
define internal i8* @dont_zap_me(i8 %v) {
|
|
; IS__TUNIT____-LABEL: define {{[^@]+}}@dont_zap_me
|
|
; IS__TUNIT____-SAME: (i8 [[V:%.*]]) {
|
|
; IS__TUNIT____-NEXT: [[I1:%.*]] = call i32 @external()
|
|
; IS__TUNIT____-NEXT: ret i8* undef
|
|
;
|
|
; IS__CGSCC____-LABEL: define {{[^@]+}}@dont_zap_me
|
|
; IS__CGSCC____-SAME: (i8 [[V:%.*]]) {
|
|
; IS__CGSCC____-NEXT: [[I1:%.*]] = call i32 @external()
|
|
; IS__CGSCC____-NEXT: ret i8* null
|
|
;
|
|
%i1 = call i32 @external()
|
|
ret i8* null
|
|
}
|
|
;.
|
|
; IS__CGSCC____: attributes #[[ATTR0]] = { nofree norecurse nosync nounwind readnone willreturn }
|
|
;.
|