0628bea513
This broke Chromium's PGO build, it seems because hot-cold-splitting got turned
on unintentionally. See comment on the code review for repro etc.
> This patch adds -f[no-]split-cold-code CC1 options to clang. This allows
> the splitting pass to be toggled on/off. The current method of passing
> `-mllvm -hot-cold-split=true` to clang isn't ideal as it may not compose
> correctly (say, with `-O0` or `-Oz`).
>
> To implement the -fsplit-cold-code option, an attribute is applied to
> functions to indicate that they may be considered for splitting. This
> removes some complexity from the old/new PM pipeline builders, and
> behaves as expected when LTO is enabled.
>
> Co-authored by: Saleem Abdulrasool <compnerd@compnerd.org>
> Differential Revision: https://reviews.llvm.org/D57265
> Reviewed By: Aditya Kumar, Vedant Kumar
> Reviewers: Teresa Johnson, Aditya Kumar, Fedor Sergeev, Philip Pfaffe, Vedant Kumar
This reverts commit 273c299d5d.
28 lines
641 B
LLVM
28 lines
641 B
LLVM
; RUN: opt -hotcoldsplit -hotcoldsplit-threshold=-1 -S < %s | FileCheck %s
|
|
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.14.0"
|
|
|
|
; CHECK: define {{.*}} @foo{{.*}}#[[outlined_func_attr:[0-9]+]]
|
|
define void @foo() noreturn cold {
|
|
unreachable
|
|
}
|
|
|
|
; CHECK: define {{.*}} @bar.cold.1{{.*}}#[[outlined_func_attr]]
|
|
define void @bar() {
|
|
br i1 undef, label %normal, label %exit
|
|
|
|
normal:
|
|
unreachable
|
|
|
|
exit:
|
|
ret void
|
|
}
|
|
|
|
@take_addr_of_foo = global void ()* @foo
|
|
@take_addr_of_bar = global void ()* @bar
|
|
|
|
; CHECK: attributes #[[outlined_func_attr]] = {
|
|
; CHECK-SAME: cold
|
|
; CHECK-SAME: minsize
|