We use the same similarity scheme we used for branch instructions for phi nodes, and allow them to be outlined. There is not a lot of special handling needed for these phi nodes when outlining, as they simply act as outputs. The code extractor does not currently allow for non entry blocks within the extracted region to have predecessors, so there are not conflicts to handle with respect to predecessors no longer contained in the function.
Recommit of 515eec3553
Reviewers: paquette
Differential Revision: https://reviews.llvm.org/D106997
94 lines
3.0 KiB
LLVM
94 lines
3.0 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --include-generated-funcs
|
|
; RUN: opt -S -verify -iroutliner -ir-outlining-no-cost < %s | FileCheck %s
|
|
|
|
; Show that we are able to outline when all of the phi nodes in the starting
|
|
; block are included in the region and there is no more than one predecessor
|
|
; into those phi nodes from outside of the region.
|
|
|
|
define void @function1(i32* %a, i32* %b) {
|
|
entry:
|
|
%0 = alloca i32, align 4
|
|
%c = load i32, i32* %0, align 4
|
|
%y = add i32 %c, %c
|
|
br label %test1
|
|
dummy:
|
|
ret void
|
|
test1:
|
|
%1 = phi i32 [ %e, %test1 ], [ %y, %entry ]
|
|
%2 = phi i32 [ %e, %test1 ], [ %y, %entry ]
|
|
%e = load i32, i32* %0, align 4
|
|
%3 = add i32 %c, %c
|
|
br i1 true, label %test, label %test1
|
|
test:
|
|
%d = load i32, i32* %0, align 4
|
|
br label %first
|
|
first:
|
|
ret void
|
|
}
|
|
|
|
define void @function2(i32* %a, i32* %b) {
|
|
entry:
|
|
%0 = alloca i32, align 4
|
|
%c = load i32, i32* %0, align 4
|
|
%y = mul i32 %c, %c
|
|
br label %test1
|
|
dummy:
|
|
ret void
|
|
test1:
|
|
%1 = phi i32 [ %e, %test1 ], [ %y, %entry ]
|
|
%2 = phi i32 [ %e, %test1 ], [ %y, %entry ]
|
|
%e = load i32, i32* %0, align 4
|
|
%3 = add i32 %c, %c
|
|
br i1 true, label %test, label %test1
|
|
test:
|
|
%d = load i32, i32* %0, align 4
|
|
br label %first
|
|
first:
|
|
ret void
|
|
}
|
|
; CHECK-LABEL: @function1(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4
|
|
; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4
|
|
; CHECK-NEXT: [[Y:%.*]] = add i32 [[C]], [[C]]
|
|
; CHECK-NEXT: br label [[TEST1:%.*]]
|
|
; CHECK: dummy:
|
|
; CHECK-NEXT: ret void
|
|
; CHECK: test1:
|
|
; CHECK-NEXT: call void @outlined_ir_func_0(i32 [[Y]], i32* [[TMP0]], i32 [[C]])
|
|
; CHECK-NEXT: br label [[FIRST:%.*]]
|
|
; CHECK: first:
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
;
|
|
; CHECK-LABEL: @function2(
|
|
; CHECK-NEXT: entry:
|
|
; CHECK-NEXT: [[TMP0:%.*]] = alloca i32, align 4
|
|
; CHECK-NEXT: [[C:%.*]] = load i32, i32* [[TMP0]], align 4
|
|
; CHECK-NEXT: [[Y:%.*]] = mul i32 [[C]], [[C]]
|
|
; CHECK-NEXT: br label [[TEST1:%.*]]
|
|
; CHECK: dummy:
|
|
; CHECK-NEXT: ret void
|
|
; CHECK: test1:
|
|
; CHECK-NEXT: call void @outlined_ir_func_0(i32 [[Y]], i32* [[TMP0]], i32 [[C]])
|
|
; CHECK-NEXT: br label [[FIRST:%.*]]
|
|
; CHECK: first:
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
;
|
|
; CHECK: define internal void @outlined_ir_func_0(
|
|
; CHECK-NEXT: newFuncRoot:
|
|
; CHECK-NEXT: br label [[TEST1_TO_OUTLINE:%.*]]
|
|
; CHECK: test1_to_outline:
|
|
; CHECK-NEXT: [[TMP3:%.*]] = phi i32 [ [[E:%.*]], [[TEST1_TO_OUTLINE]] ], [ [[TMP0:%.*]], [[NEWFUNCROOT:%.*]] ]
|
|
; CHECK-NEXT: [[TMP4:%.*]] = phi i32 [ [[E]], [[TEST1_TO_OUTLINE]] ], [ [[TMP0]], [[NEWFUNCROOT]] ]
|
|
; CHECK-NEXT: [[E]] = load i32, i32* [[TMP1:%.*]], align 4
|
|
; CHECK-NEXT: [[TMP5:%.*]] = add i32 [[TMP2:%.*]], [[TMP2]]
|
|
; CHECK-NEXT: br i1 true, label [[TEST:%.*]], label [[TEST1_TO_OUTLINE]]
|
|
; CHECK: test:
|
|
; CHECK-NEXT: [[D:%.*]] = load i32, i32* [[TMP1]], align 4
|
|
; CHECK-NEXT: br label [[FIRST_EXITSTUB:%.*]]
|
|
; CHECK: first.exitStub:
|
|
; CHECK-NEXT: ret void
|
|
;
|