5899278758
IHexWriter was evaluating a section's physical address when deciding if that section should be written to an output. This approach does not account for a zero-sized section that has the same physical address as a sized section. The behavior varies from GNU objcopy, and may result in a HEX file that does not include all program sections. The IHexWriter now excludes zero-sized sections when deciding what should be written to the output. This affects the contents of the writer's `Sections` collection; we will not try to insert multiple sections that could have the same physical address. The behavior seems consistent with GNU objcopy, which always excludes empty sections, no matter the address. The new test case evaluates the IHexWriter behavior when provided a variety of empty sections that overlap or append a filled section. See the input file's comments for more information. Given that test input, and the change to the IHexWriter, GNU objcopy and llvm-objcopy produce the same output. Reviewed By: jhenderson, MaskRay, evgeny777 Differential Revision: https://reviews.llvm.org/D101332
31 lines
964 B
YAML
31 lines
964 B
YAML
!ELF
|
|
FileHeader:
|
|
Class: ELFCLASS64
|
|
Data: ELFDATA2LSB
|
|
Type: ET_EXEC
|
|
Machine: EM_X86_64
|
|
Sections:
|
|
- Name: .text1
|
|
# Section address is sign-extended 32-bit address
|
|
# Data fits 32-bit range
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
Address: 0xFFFFFFFF80001000
|
|
AddressAlign: 0x8
|
|
Content: "0001020304"
|
|
- Name: .text2
|
|
# Part of section data is in 32-bit address range
|
|
# and part isn't.
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
Address: 0xFFFFFFF8
|
|
AddressAlign: 0x8
|
|
Content: "000102030405060708"
|
|
- Name: .text3
|
|
# Entire secion is outside of 32-bit range
|
|
Type: SHT_PROGBITS
|
|
Flags: [ SHF_ALLOC, SHF_EXECINSTR ]
|
|
Address: 0xFFFFFFFF0
|
|
AddressAlign: 0x8
|
|
Content: "0001020304"
|