- added views::join adaptor object - added test for the adaptor object - fixed some join_view's tests. e.g iter_swap test - added some negative tests for join_view to test that operations do not exist when constraints aren't met - added tests that locks down issues that were already addressed in previous change - LWG3500 `join_view::iterator::operator->()` is bogus - LWG3313 `join_view::iterator::operator--` is incorrectly constrained - LWG3517 `join_view::iterator`'s `iter_swap` is underconstrained - P2328R1 join_view should join all views of ranges - fixed some issues in join_view and added tests - LWG3535 `join_view::iterator::iterator_category` and `::iterator_concept` lie - LWG3474 Nesting ``join_views`` is broken because of CTAD - added tests for an LWG issue that isn't resolved in the standard yet, but the previous code has workaround. - LWG3569 Inner iterator not default_initializable Reviewed By: #libc, var-const Spies: var-const, libcxx-commits Differential Revision: https://reviews.llvm.org/D123466
50 lines
1.3 KiB
C++
50 lines
1.3 KiB
C++
//===----------------------------------------------------------------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
// UNSUPPORTED: c++03, c++11, c++14, c++17
|
|
// UNSUPPORTED: libcpp-has-no-incomplete-ranges
|
|
|
|
// join_view() requires default_initializable<V> = default;
|
|
|
|
#include <cassert>
|
|
#include <ranges>
|
|
|
|
#include "types.h"
|
|
|
|
struct DefaultView : std::ranges::view_base {
|
|
int i; // deliberately uninitialised
|
|
|
|
ChildView* begin() const;
|
|
ChildView* end() const;
|
|
};
|
|
|
|
constexpr bool test() {
|
|
{
|
|
std::ranges::join_view<ParentView<ChildView>> jv;
|
|
assert(std::move(jv).base().ptr_ == globalChildren);
|
|
}
|
|
|
|
// Default constructor should value initialise underlying view
|
|
{
|
|
std::ranges::join_view<DefaultView> jv;
|
|
assert(jv.base().i == 0);
|
|
}
|
|
|
|
static_assert( std::default_initializable<std::ranges::join_view<ParentView<ChildView>>>);
|
|
static_assert(!std::default_initializable<std::ranges::join_view<CopyableParent>>);
|
|
|
|
return true;
|
|
}
|
|
|
|
int main(int, char**) {
|
|
test();
|
|
static_assert(test());
|
|
|
|
return 0;
|
|
}
|