68c1eeb4ba
This rewrites ArgPromotion to be based on offsets rather than GEP structure. We inspect all loads at constant offsets and remember which types are loaded at which offsets. Then we promote based on those types. This generalizes ArgPromotion to work with bitcasted loads, and is compatible with opaque pointers. This patch also fixes incorrect handling of alignment during argument promotion. Previously, the implementation only checked that the pointer is dereferenceable, but was happy to speculate overaligned loads. (I would have fixed this separately in advance, but I found this hard to do with the previous implementation approach). Differential Revision: https://reviews.llvm.org/D118685
115 lines
3.6 KiB
LLVM
115 lines
3.6 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --function-signature --scrub-attributes
|
|
; RUN: opt -S -argpromotion < %s | FileCheck %s
|
|
|
|
define internal i32 @callee_must_exec(i32* %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@callee_must_exec
|
|
; CHECK-SAME: (i32 [[P_0_VAL:%.*]]) {
|
|
; CHECK-NEXT: ret i32 [[P_0_VAL]]
|
|
;
|
|
%x = load i32, i32* %p, align 16
|
|
ret i32 %x
|
|
}
|
|
|
|
define void @caller_must_exec(i32* %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@caller_must_exec
|
|
; CHECK-SAME: (i32* [[P:%.*]]) {
|
|
; CHECK-NEXT: [[P_VAL:%.*]] = load i32, i32* [[P]], align 16
|
|
; CHECK-NEXT: [[TMP1:%.*]] = call i32 @callee_must_exec(i32 [[P_VAL]])
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call i32 @callee_must_exec(i32* %p)
|
|
ret void
|
|
}
|
|
|
|
define internal i32 @callee_guaranteed_aligned_1(i1 %c, i32* %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@callee_guaranteed_aligned_1
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32 [[P_0_VAL:%.*]]) {
|
|
; CHECK-NEXT: br i1 [[C]], label [[IF:%.*]], label [[ELSE:%.*]]
|
|
; CHECK: if:
|
|
; CHECK-NEXT: ret i32 [[P_0_VAL]]
|
|
; CHECK: else:
|
|
; CHECK-NEXT: ret i32 -1
|
|
;
|
|
br i1 %c, label %if, label %else
|
|
|
|
if:
|
|
%x = load i32, i32* %p, align 16
|
|
ret i32 %x
|
|
|
|
else:
|
|
ret i32 -1
|
|
}
|
|
|
|
define void @caller_guaranteed_aligned_1(i1 %c, i32* align 16 dereferenceable(4) %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@caller_guaranteed_aligned_1
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32* align 16 dereferenceable(4) [[P:%.*]]) {
|
|
; CHECK-NEXT: [[P_VAL:%.*]] = load i32, i32* [[P]], align 16
|
|
; CHECK-NEXT: [[TMP1:%.*]] = call i32 @callee_guaranteed_aligned_1(i1 [[C]], i32 [[P_VAL]])
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call i32 @callee_guaranteed_aligned_1(i1 %c, i32* %p)
|
|
ret void
|
|
}
|
|
|
|
define internal i32 @callee_guaranteed_aligned_2(i1 %c, i32* align 16 dereferenceable(4) %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@callee_guaranteed_aligned_2
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32 [[P_0_VAL:%.*]]) {
|
|
; CHECK-NEXT: br i1 [[C]], label [[IF:%.*]], label [[ELSE:%.*]]
|
|
; CHECK: if:
|
|
; CHECK-NEXT: ret i32 [[P_0_VAL]]
|
|
; CHECK: else:
|
|
; CHECK-NEXT: ret i32 -1
|
|
;
|
|
br i1 %c, label %if, label %else
|
|
|
|
if:
|
|
%x = load i32, i32* %p, align 16
|
|
ret i32 %x
|
|
|
|
else:
|
|
ret i32 -1
|
|
}
|
|
|
|
define void @caller_guaranteed_aligned_2(i1 %c, i32* %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@caller_guaranteed_aligned_2
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32* [[P:%.*]]) {
|
|
; CHECK-NEXT: [[P_VAL:%.*]] = load i32, i32* [[P]], align 16
|
|
; CHECK-NEXT: [[TMP1:%.*]] = call i32 @callee_guaranteed_aligned_2(i1 [[C]], i32 [[P_VAL]])
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call i32 @callee_guaranteed_aligned_2(i1 %c, i32* %p)
|
|
ret void
|
|
}
|
|
|
|
; This should not be promoted, as the caller only guarantees that the
|
|
; pointer is dereferenceable, not that it is aligned.
|
|
define internal i32 @callee_not_guaranteed_aligned(i1 %c, i32* %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@callee_not_guaranteed_aligned
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32* [[P:%.*]]) {
|
|
; CHECK-NEXT: br i1 [[C]], label [[IF:%.*]], label [[ELSE:%.*]]
|
|
; CHECK: if:
|
|
; CHECK-NEXT: [[X:%.*]] = load i32, i32* [[P]], align 16
|
|
; CHECK-NEXT: ret i32 [[X]]
|
|
; CHECK: else:
|
|
; CHECK-NEXT: ret i32 -1
|
|
;
|
|
br i1 %c, label %if, label %else
|
|
|
|
if:
|
|
%x = load i32, i32* %p, align 16
|
|
ret i32 %x
|
|
|
|
else:
|
|
ret i32 -1
|
|
}
|
|
|
|
define void @caller_not_guaranteed_aligned(i1 %c, i32* dereferenceable(4) %p) {
|
|
; CHECK-LABEL: define {{[^@]+}}@caller_not_guaranteed_aligned
|
|
; CHECK-SAME: (i1 [[C:%.*]], i32* dereferenceable(4) [[P:%.*]]) {
|
|
; CHECK-NEXT: [[TMP1:%.*]] = call i32 @callee_not_guaranteed_aligned(i1 [[C]], i32* [[P]])
|
|
; CHECK-NEXT: ret void
|
|
;
|
|
call i32 @callee_not_guaranteed_aligned(i1 %c, i32* %p)
|
|
ret void
|
|
}
|