ce6a56e667
**Summary**
This patch makes LLDB understand the `DW_AT_default_value` on
template argument DIEs. As a result, type summaries will no
longer contain the defaulted template arguments, reducing
noise substantially. E.g.,
Before:
```
(lldb) v nested
(std::vector<std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator<char> > > >, std::allocator<std::vector<std::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::allocator<std::basic_string<char, std::char_traits<char>, std::allocator <char> > > > > >) nested = size=0 {}
```
After:
```
(lldb) v nested
(std::vector<std::vector<std::basic_string<char> > >) nested = size=0 {}
```
See discussion in https://reviews.llvm.org/D140423
**Testing**
* Adjust API tests
* Added unit-test
Differential Revision: https://reviews.llvm.org/D141828
63 lines
2.9 KiB
Python
63 lines
2.9 KiB
Python
from lldbsuite.test.decorators import *
|
|
from lldbsuite.test.lldbtest import *
|
|
from lldbsuite.test import lldbutil
|
|
|
|
|
|
class TestCase(TestBase):
|
|
|
|
@add_test_categories(["libc++"])
|
|
@skipIf(compiler=no_match("clang"))
|
|
def test(self):
|
|
self.build()
|
|
|
|
lldbutil.run_to_source_breakpoint(self,
|
|
"// Set break point at this line.",
|
|
lldb.SBFileSpec("main.cpp"))
|
|
|
|
# Test printing the vector before enabling any C++ module setting.
|
|
self.expect_expr("a", result_type="std::vector<int>")
|
|
|
|
# Set loading the import-std-module to 'fallback' which loads the module
|
|
# and retries when an expression fails to parse.
|
|
self.runCmd("settings set target.import-std-module fallback")
|
|
|
|
# Printing the vector still works. This should return the same type
|
|
# as before as this shouldn't use a C++ module type.
|
|
self.expect_expr("a", result_type="std::vector<int>")
|
|
|
|
# This expression can only parse with a C++ module. LLDB should
|
|
# automatically fall back to import the C++ module to get this working.
|
|
self.expect_expr("std::max<std::size_t>(0U, a.size())", result_value="3")
|
|
|
|
|
|
# The 'a' and 'local' part can be parsed without loading a C++ module and will
|
|
# load type/runtime information. The 'std::max...' part will fail to
|
|
# parse without a C++ module. Make sure we reset all the relevant parts of
|
|
# the C++ parser so that we don't end up with for example a second
|
|
# definition of 'local' when retrying.
|
|
self.expect_expr("a; local; std::max<std::size_t>(0U, a.size())", result_value="3")
|
|
|
|
|
|
# Try to declare top-level declarations that require a C++ module to parse.
|
|
# Top-level expressions don't support importing the C++ module (yet), so
|
|
# this should still fail as before.
|
|
self.expect("expr --top-level -- int i = std::max(1, 2);", error=True,
|
|
substrs=["no member named 'max' in namespace 'std'"])
|
|
|
|
# The proper diagnostic however should be shown on the retry.
|
|
self.expect("expr std::max(1, 2); unknown_identifier", error=True,
|
|
substrs=["use of undeclared identifier 'unknown_identifier'"])
|
|
|
|
# Turn on the 'import-std-module' setting and make sure we import the
|
|
# C++ module.
|
|
self.runCmd("settings set target.import-std-module true")
|
|
# This is still expected to work.
|
|
self.expect_expr("std::max<std::size_t>(0U, a.size())", result_value="3")
|
|
|
|
# Turn of the 'import-std-module' setting and make sure we don't load
|
|
# the module (which should prevent parsing the expression involving
|
|
# 'std::max').
|
|
self.runCmd("settings set target.import-std-module false")
|
|
self.expect("expr std::max(1, 2);", error=True,
|
|
substrs=["no member named 'max' in namespace 'std'"])
|