We currently always vectorize induction variables. However, if an induction variable is only used for counting loop iterations or computing addresses with getelementptr instructions, we don't need to do this. Vectorizing these trivial induction variables can create vector code that is difficult to simplify later on. This is especially true when the unroll factor is greater than one, and we create vector arithmetic when computing step vectors. With this patch, we check if an induction variable is only used for counting iterations or computing addresses, and if so, scalarize the arithmetic when computing step vectors instead. This allows for greater simplification. This patch addresses the suboptimal pointer arithmetic sequence seen in PR27881. Reference: https://llvm.org/bugs/show_bug.cgi?id=27881 Differential Revision: http://reviews.llvm.org/D21620 llvm-svn: 274627
196 lines
7.8 KiB
LLVM
196 lines
7.8 KiB
LLVM
; RUN: opt < %s -loop-vectorize -force-vector-interleave=2 -force-vector-width=4 -S | FileCheck %s
|
|
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
|
|
|
|
; Make sure consecutive vector generates correct negative indices.
|
|
; PR15882
|
|
|
|
; CHECK: %index = phi i64 [ 0, %vector.ph ], [ %index.next, %vector.body ]
|
|
; CHECK: %offset.idx = sub i64 %startval, %index
|
|
; CHECK: %[[a0:.+]] = add i64 %offset.idx, 0
|
|
; CHECK: %[[v0:.+]] = insertelement <4 x i64> undef, i64 %[[a0]], i64 0
|
|
; CHECK: %[[a1:.+]] = add i64 %offset.idx, -1
|
|
; CHECK: %[[v1:.+]] = insertelement <4 x i64> %[[v0]], i64 %[[a1]], i64 1
|
|
; CHECK: %[[a2:.+]] = add i64 %offset.idx, -2
|
|
; CHECK: %[[v2:.+]] = insertelement <4 x i64> %[[v1]], i64 %[[a2]], i64 2
|
|
; CHECK: %[[a3:.+]] = add i64 %offset.idx, -3
|
|
; CHECK: %[[v3:.+]] = insertelement <4 x i64> %[[v2]], i64 %[[a3]], i64 3
|
|
; CHECK: %[[a4:.+]] = add i64 %offset.idx, -4
|
|
; CHECK: %[[v4:.+]] = insertelement <4 x i64> undef, i64 %[[a4]], i64 0
|
|
; CHECK: %[[a5:.+]] = add i64 %offset.idx, -5
|
|
; CHECK: %[[v5:.+]] = insertelement <4 x i64> %[[v4]], i64 %[[a5]], i64 1
|
|
; CHECK: %[[a6:.+]] = add i64 %offset.idx, -6
|
|
; CHECK: %[[v6:.+]] = insertelement <4 x i64> %[[v5]], i64 %[[a6]], i64 2
|
|
; CHECK: %[[a7:.+]] = add i64 %offset.idx, -7
|
|
; CHECK: %[[v7:.+]] = insertelement <4 x i64> %[[v6]], i64 %[[a7]], i64 3
|
|
|
|
define i32 @reverse_induction_i64(i64 %startval, i32 * %ptr) {
|
|
entry:
|
|
br label %for.body
|
|
|
|
for.body:
|
|
%add.i7 = phi i64 [ %startval, %entry ], [ %add.i, %for.body ]
|
|
%i.06 = phi i32 [ 0, %entry ], [ %inc4, %for.body ]
|
|
%redux5 = phi i32 [ 0, %entry ], [ %inc.redux, %for.body ]
|
|
%add.i = add i64 %add.i7, -1
|
|
%kind_.i = getelementptr inbounds i32, i32* %ptr, i64 %add.i
|
|
%tmp.i1 = load i32, i32* %kind_.i, align 4
|
|
%inc.redux = add i32 %tmp.i1, %redux5
|
|
%inc4 = add i32 %i.06, 1
|
|
%exitcond = icmp ne i32 %inc4, 1024
|
|
br i1 %exitcond, label %for.body, label %loopend
|
|
|
|
loopend:
|
|
ret i32 %inc.redux
|
|
}
|
|
|
|
; CHECK-LABEL: @reverse_induction_i128(
|
|
; CHECK: %index = phi i128 [ 0, %vector.ph ], [ %index.next, %vector.body ]
|
|
; CHECK: %offset.idx = sub i128 %startval, %index
|
|
; CHECK: %[[a0:.+]] = add i128 %offset.idx, 0
|
|
; CHECK: %[[v0:.+]] = insertelement <4 x i128> undef, i128 %[[a0]], i64 0
|
|
; CHECK: %[[a1:.+]] = add i128 %offset.idx, -1
|
|
; CHECK: %[[v1:.+]] = insertelement <4 x i128> %[[v0]], i128 %[[a1]], i64 1
|
|
; CHECK: %[[a2:.+]] = add i128 %offset.idx, -2
|
|
; CHECK: %[[v2:.+]] = insertelement <4 x i128> %[[v1]], i128 %[[a2]], i64 2
|
|
; CHECK: %[[a3:.+]] = add i128 %offset.idx, -3
|
|
; CHECK: %[[v3:.+]] = insertelement <4 x i128> %[[v2]], i128 %[[a3]], i64 3
|
|
; CHECK: %[[a4:.+]] = add i128 %offset.idx, -4
|
|
; CHECK: %[[v4:.+]] = insertelement <4 x i128> undef, i128 %[[a4]], i64 0
|
|
; CHECK: %[[a5:.+]] = add i128 %offset.idx, -5
|
|
; CHECK: %[[v5:.+]] = insertelement <4 x i128> %[[v4]], i128 %[[a5]], i64 1
|
|
; CHECK: %[[a6:.+]] = add i128 %offset.idx, -6
|
|
; CHECK: %[[v6:.+]] = insertelement <4 x i128> %[[v5]], i128 %[[a6]], i64 2
|
|
; CHECK: %[[a7:.+]] = add i128 %offset.idx, -7
|
|
; CHECK: %[[v7:.+]] = insertelement <4 x i128> %[[v6]], i128 %[[a7]], i64 3
|
|
|
|
define i32 @reverse_induction_i128(i128 %startval, i32 * %ptr) {
|
|
entry:
|
|
br label %for.body
|
|
|
|
for.body:
|
|
%add.i7 = phi i128 [ %startval, %entry ], [ %add.i, %for.body ]
|
|
%i.06 = phi i32 [ 0, %entry ], [ %inc4, %for.body ]
|
|
%redux5 = phi i32 [ 0, %entry ], [ %inc.redux, %for.body ]
|
|
%add.i = add i128 %add.i7, -1
|
|
%kind_.i = getelementptr inbounds i32, i32* %ptr, i128 %add.i
|
|
%tmp.i1 = load i32, i32* %kind_.i, align 4
|
|
%inc.redux = add i32 %tmp.i1, %redux5
|
|
%inc4 = add i32 %i.06, 1
|
|
%exitcond = icmp ne i32 %inc4, 1024
|
|
br i1 %exitcond, label %for.body, label %loopend
|
|
|
|
loopend:
|
|
ret i32 %inc.redux
|
|
}
|
|
|
|
; CHECK-LABEL: @reverse_induction_i16(
|
|
; CHECK: %index = phi i32 [ 0, %vector.ph ], [ %index.next, %vector.body ]
|
|
; CHECK: %offset.idx = sub i16 %startval, {{.*}}
|
|
; CHECK: %[[a0:.+]] = add i16 %offset.idx, 0
|
|
; CHECK: %[[v0:.+]] = insertelement <4 x i16> undef, i16 %[[a0]], i64 0
|
|
; CHECK: %[[a1:.+]] = add i16 %offset.idx, -1
|
|
; CHECK: %[[v1:.+]] = insertelement <4 x i16> %[[v0]], i16 %[[a1]], i64 1
|
|
; CHECK: %[[a2:.+]] = add i16 %offset.idx, -2
|
|
; CHECK: %[[v2:.+]] = insertelement <4 x i16> %[[v1]], i16 %[[a2]], i64 2
|
|
; CHECK: %[[a3:.+]] = add i16 %offset.idx, -3
|
|
; CHECK: %[[v3:.+]] = insertelement <4 x i16> %[[v2]], i16 %[[a3]], i64 3
|
|
; CHECK: %[[a4:.+]] = add i16 %offset.idx, -4
|
|
; CHECK: %[[v4:.+]] = insertelement <4 x i16> undef, i16 %[[a4]], i64 0
|
|
; CHECK: %[[a5:.+]] = add i16 %offset.idx, -5
|
|
; CHECK: %[[v5:.+]] = insertelement <4 x i16> %[[v4]], i16 %[[a5]], i64 1
|
|
; CHECK: %[[a6:.+]] = add i16 %offset.idx, -6
|
|
; CHECK: %[[v6:.+]] = insertelement <4 x i16> %[[v5]], i16 %[[a6]], i64 2
|
|
; CHECK: %[[a7:.+]] = add i16 %offset.idx, -7
|
|
; CHECK: %[[v7:.+]] = insertelement <4 x i16> %[[v6]], i16 %[[a7]], i64 3
|
|
|
|
define i32 @reverse_induction_i16(i16 %startval, i32 * %ptr) {
|
|
entry:
|
|
br label %for.body
|
|
|
|
for.body:
|
|
%add.i7 = phi i16 [ %startval, %entry ], [ %add.i, %for.body ]
|
|
%i.06 = phi i32 [ 0, %entry ], [ %inc4, %for.body ]
|
|
%redux5 = phi i32 [ 0, %entry ], [ %inc.redux, %for.body ]
|
|
%add.i = add i16 %add.i7, -1
|
|
%kind_.i = getelementptr inbounds i32, i32* %ptr, i16 %add.i
|
|
%tmp.i1 = load i32, i32* %kind_.i, align 4
|
|
%inc.redux = add i32 %tmp.i1, %redux5
|
|
%inc4 = add i32 %i.06, 1
|
|
%exitcond = icmp ne i32 %inc4, 1024
|
|
br i1 %exitcond, label %for.body, label %loopend
|
|
|
|
loopend:
|
|
ret i32 %inc.redux
|
|
}
|
|
|
|
|
|
@a = common global [1024 x i32] zeroinitializer, align 16
|
|
|
|
; We incorrectly transformed this loop into an empty one because we left the
|
|
; induction variable in i8 type and truncated the exit value 1024 to 0.
|
|
; int a[1024];
|
|
;
|
|
; void fail() {
|
|
; int reverse_induction = 1023;
|
|
; unsigned char forward_induction = 0;
|
|
; while ((reverse_induction) >= 0) {
|
|
; forward_induction++;
|
|
; a[reverse_induction] = forward_induction;
|
|
; --reverse_induction;
|
|
; }
|
|
; }
|
|
|
|
; CHECK-LABEL: @reverse_forward_induction_i64_i8(
|
|
; CHECK: vector.body
|
|
; CHECK: %index = phi i64 [ 0, %vector.ph ], [ %index.next, %vector.body ]
|
|
; CHECK: %vec.ind = phi <4 x i64> [ <i64 1023, i64 1022, i64 1021, i64 1020>, %vector.ph ]
|
|
; CHECK: %step.add = add <4 x i64> %vec.ind, <i64 -4, i64 -4, i64 -4, i64 -4>
|
|
; CHECK: trunc i64 %index to i8
|
|
|
|
define void @reverse_forward_induction_i64_i8() {
|
|
entry:
|
|
br label %while.body
|
|
|
|
while.body:
|
|
%indvars.iv = phi i64 [ 1023, %entry ], [ %indvars.iv.next, %while.body ]
|
|
%forward_induction.05 = phi i8 [ 0, %entry ], [ %inc, %while.body ]
|
|
%inc = add i8 %forward_induction.05, 1
|
|
%conv = zext i8 %inc to i32
|
|
%arrayidx = getelementptr inbounds [1024 x i32], [1024 x i32]* @a, i64 0, i64 %indvars.iv
|
|
store i32 %conv, i32* %arrayidx, align 4
|
|
%indvars.iv.next = add i64 %indvars.iv, -1
|
|
%0 = trunc i64 %indvars.iv to i32
|
|
%cmp = icmp sgt i32 %0, 0
|
|
br i1 %cmp, label %while.body, label %while.end
|
|
|
|
while.end:
|
|
ret void
|
|
}
|
|
|
|
; CHECK-LABEL: @reverse_forward_induction_i64_i8_signed(
|
|
; CHECK: vector.body:
|
|
; CHECK: %index = phi i64 [ 0, %vector.ph ], [ %index.next, %vector.body ]
|
|
; CHECK: %vec.ind = phi <4 x i64> [ <i64 1023, i64 1022, i64 1021, i64 1020>, %vector.ph ]
|
|
; CHECK: %step.add = add <4 x i64> %vec.ind, <i64 -4, i64 -4, i64 -4, i64 -4>
|
|
|
|
define void @reverse_forward_induction_i64_i8_signed() {
|
|
entry:
|
|
br label %while.body
|
|
|
|
while.body:
|
|
%indvars.iv = phi i64 [ 1023, %entry ], [ %indvars.iv.next, %while.body ]
|
|
%forward_induction.05 = phi i8 [ -127, %entry ], [ %inc, %while.body ]
|
|
%inc = add i8 %forward_induction.05, 1
|
|
%conv = sext i8 %inc to i32
|
|
%arrayidx = getelementptr inbounds [1024 x i32], [1024 x i32]* @a, i64 0, i64 %indvars.iv
|
|
store i32 %conv, i32* %arrayidx, align 4
|
|
%indvars.iv.next = add i64 %indvars.iv, -1
|
|
%0 = trunc i64 %indvars.iv to i32
|
|
%cmp = icmp sgt i32 %0, 0
|
|
br i1 %cmp, label %while.body, label %while.end
|
|
|
|
while.end:
|
|
ret void
|
|
}
|