e1689689d8
Previously, in r320472, I moved the calculation of section offsets and sizes for compressed debug sections into maybeCompress, which happens before assignAddresses, so that the compression had the required information. However, I failed to take account of relocations that patch such sections. This had two effects: 1. A race condition existed when a debug section referred to a different debug section (see PR35788). 2. References to symbols in non-debug sections would be patched incorrectly. This is because the addresses of such symbols are not calculated until after assignAddresses (this was a partial regression caused by r320472, but they could still have been broken before, in the event that a custom layout was used in a linker script). assignAddresses does not need to know about the output section size of non-allocatable sections, because they do not affect the value of Dot. This means that there is no longer a reason not to support custom layout of compressed debug sections, as far as I'm aware. These two points allow for delaying when maybeCompress can be called, removing the need for the loop I previously added to calculate the section size, and therefore the race condition. Furthermore, by delaying, we fix the issues of relocations getting incorrect symbol values, because they have now all been finalized. llvm-svn: 321986
36 lines
1.3 KiB
ArmAsm
36 lines
1.3 KiB
ArmAsm
# REQUIRES: x86, zlib
|
|
|
|
# RUN: echo "SECTIONS { \
|
|
# RUN: .text : { . += 0x10; *(.text) } \
|
|
# RUN: .debug_str : { . += 0x10; *(.debug_str) } \
|
|
# RUN: .debug_info : { . += 0x10; *(.debug_info) } \
|
|
# RUN: }" > %t.script
|
|
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
|
|
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %S/../Inputs/compress-debug.s -o %t2.o
|
|
# RUN: ld.lld %t2.o %t.o -o %t1 --compress-debug-sections=zlib -T %t.script
|
|
# RUN: llvm-dwarfdump %t1 -debug-str | FileCheck %s
|
|
# These two checks correspond to the patched values of a_sym and a_debug_sym.
|
|
# T = 0x54 - address of .text input section for this file (the start address of
|
|
# .text is 0 by default, the size of the preceding .text in the other input
|
|
# file is 0x44, and the linker script adds an additional 0x10).
|
|
# S = 0x53 - offset of .debug_info section for this file (the size of
|
|
# the preceding .debug_info from the other input file is 0x43, and the
|
|
# linker script adds an additional 0x10).
|
|
# Also note that the .debug_str offsets are also offset by 0x10, as directed by
|
|
# the linker script.
|
|
# CHECK: 0x00000010: "T"
|
|
# CHECK: 0x00000014: "S"
|
|
|
|
.text
|
|
a_sym:
|
|
nop
|
|
|
|
.section .debug_str,"",@progbits
|
|
.long a_sym
|
|
.long a_debug_sym
|
|
|
|
.section .debug_info,"",@progbits
|
|
a_debug_sym:
|
|
.long 0x88776655
|