e1d18758eb
Summary: This patch adds the ability to lookup variables to the DWARF v5 index class. During review we discovered an inconsistency between how the existing two indexes handle looking up qualified names of the variables: - manual index would return a value if the input string exactly matched the demangled name of some variable. - apple index ignored the context and returned any variable with the same base name. So, this patch also rectifies that situation: - it removes all context handling from the index classes. The GetGlobalVariables functions now just take a base name. For manual index, this meant we can stop putting demangled names into the variable index (this matches the behavior for functions). - context extraction is put into SymbolFileDWARF, so that it is common to all indexes. - additional filtering based on the context is also done in SymbolFileDWARF. This is done via a simple substring search, which is not ideal, but it matches what we are doing for functions (cf. Module::LookupInfo::Prune). Reviewers: clayborg, JDevlieghere Subscribers: aprantl, lldb-commits Differential Revision: https://reviews.llvm.org/D47781 llvm-svn: 334181
65 lines
2.8 KiB
C++
65 lines
2.8 KiB
C++
//===-- AppleDWARFIndex.h --------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#ifndef LLDB_APPLEDWARFINDEX_H
|
|
#define LLDB_APPLEDWARFINDEX_H
|
|
|
|
#include "Plugins/SymbolFile/DWARF/DWARFIndex.h"
|
|
#include "Plugins/SymbolFile/DWARF/HashedNameToDIE.h"
|
|
|
|
namespace lldb_private {
|
|
class AppleDWARFIndex : public DWARFIndex {
|
|
public:
|
|
static std::unique_ptr<AppleDWARFIndex>
|
|
Create(Module &module, DWARFDataExtractor apple_names,
|
|
DWARFDataExtractor apple_namespaces, DWARFDataExtractor apple_types,
|
|
DWARFDataExtractor apple_objc, DWARFDataExtractor debug_str);
|
|
|
|
AppleDWARFIndex(
|
|
Module &module, std::unique_ptr<DWARFMappedHash::MemoryTable> apple_names,
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> apple_namespaces,
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> apple_types,
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> apple_objc)
|
|
: DWARFIndex(module), m_apple_names_up(std::move(apple_names)),
|
|
m_apple_namespaces_up(std::move(apple_namespaces)),
|
|
m_apple_types_up(std::move(apple_types)),
|
|
m_apple_objc_up(std::move(apple_objc)) {}
|
|
|
|
void Preload() override {}
|
|
|
|
void GetGlobalVariables(ConstString basename, DIEArray &offsets) override;
|
|
void GetGlobalVariables(const RegularExpression ®ex,
|
|
DIEArray &offsets) override;
|
|
void GetGlobalVariables(const DWARFUnit &cu, DIEArray &offsets) override;
|
|
void GetObjCMethods(ConstString class_name, DIEArray &offsets) override;
|
|
void GetCompleteObjCClass(ConstString class_name, bool must_be_implementation,
|
|
DIEArray &offsets) override;
|
|
void GetTypes(ConstString name, DIEArray &offsets) override;
|
|
void GetTypes(const DWARFDeclContext &context, DIEArray &offsets) override;
|
|
void GetNamespaces(ConstString name, DIEArray &offsets) override;
|
|
void GetFunctions(ConstString name, DWARFDebugInfo &info,
|
|
const CompilerDeclContext &parent_decl_ctx,
|
|
uint32_t name_type_mask,
|
|
std::vector<DWARFDIE> &dies) override;
|
|
void GetFunctions(const RegularExpression ®ex, DIEArray &offsets) override;
|
|
|
|
void ReportInvalidDIEOffset(dw_offset_t offset,
|
|
llvm::StringRef name) override;
|
|
void Dump(Stream &s) override;
|
|
|
|
private:
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> m_apple_names_up;
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> m_apple_namespaces_up;
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> m_apple_types_up;
|
|
std::unique_ptr<DWARFMappedHash::MemoryTable> m_apple_objc_up;
|
|
};
|
|
} // namespace lldb_private
|
|
|
|
#endif // LLDB_APPLEDWARFINDEX_H
|