Files
clang-p2996/lldb/tools/lldb-mi/MICmnBase.h
Kamil Rytarowski b5bc933c29 Do not pass non-POD type variables through variadic function
Summary:
Cannot pass object of non-POD type 'const CMIUtilString' through variadic function.

This behavior is undefined according to C++11 5.2.2/7:

> Passing a potentially-evaluated argument of class type having a non-trivial copy constructor, a non-trivial move contructor, or a non-trivial destructor, with no corresponding parameter, is conditionally-supported with implementation-defined semantics.

Replace SetErrorDescriptionn(errMsg); with SetErrorDescription(errMsg);

Original patch by Tobias Nygren (NetBSD).

Sponsored by <The NetBSD Foundation>


Reviewers: clayborg, labath, emaste, joerg, ki.stfu

Reviewed By: labath, ki.stfu

Subscribers: tnn, ki.stfu, #lldb

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D29256

llvm-svn: 293774
2017-02-01 16:02:55 +00:00

48 lines
1.4 KiB
C++

//===-- MICmnBase.h ---------------------------------------------*- C++ -*-===//
//
// The LLVM Compiler Infrastructure
//
// This file is distributed under the University of Illinois Open Source
// License. See LICENSE.TXT for details.
//
//===----------------------------------------------------------------------===//
#pragma once
// In-house headers:
#include "MIDataTypes.h"
#include "MIUtilString.h"
// Declarations:
class CMICmnLog;
//++
//============================================================================
// Details: MI common code implementation base class.
//--
class CMICmnBase {
// Methods:
public:
/* ctor */ CMICmnBase();
bool HaveErrorDescription() const;
const CMIUtilString &GetErrorDescription() const;
void SetErrorDescription(const CMIUtilString &vrTxt) const;
void SetErrorDescriptionn(const char *vFormat, ...) const;
void SetErrorDescriptionNoLog(const CMIUtilString &vrTxt) const;
void ClrErrorDescription() const;
// Overrideable:
public:
/* dtor */ virtual ~CMICmnBase();
// Attributes:
protected:
mutable CMIUtilString m_strMILastErrorDescription;
bool m_bInitialized; // True = yes successfully initialized, false = no yet or
// failed
CMICmnLog *m_pLog; // Allow all derived classes to use the logger
MIint m_clientUsageRefCnt; // Count of client using *this object so not
// shutdown() object to early
};