3336f681e3
Summary:
This change adds some verification in the IR verifier around struct path
TBAA metadata.
Other than some basic sanity checks (e.g. we get constant integers where
we expect constant integers), this checks:
- That by the time an struct access tuple `(base-type, offset)` is
"reduced" to a scalar base type, the offset is `0`. For instance, in
C++ you can't start from, say `("struct-a", 16)`, and end up with
`("int", 4)` -- by the time the base type is `"int"`, the offset
better be zero. In particular, a variant of this invariant is needed
for `llvm::getMostGenericTBAA` to be correct.
- That there are no cycles in a struct path.
- That struct type nodes have their offsets listed in an ascending
order.
- That when generating the struct access path, you eventually reach the
access type listed in the tbaa tag node.
Reviewers: dexonsmith, chandlerc, reames, mehdi_amini, manmanren
Subscribers: mcrosier, llvm-commits
Differential Revision: https://reviews.llvm.org/D26438
llvm-svn: 289402
41 lines
1.3 KiB
LLVM
41 lines
1.3 KiB
LLVM
; RUN: opt < %s -tsan -S | FileCheck %s
|
|
; Check that vtable pointer updates are treated in a special way.
|
|
target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"
|
|
|
|
define void @Foo(i8** nocapture %a, i8* %b) nounwind uwtable sanitize_thread {
|
|
entry:
|
|
; CHECK-LABEL: @Foo
|
|
; CHECK: call void @__tsan_vptr_update
|
|
; CHECK: ret void
|
|
store i8* %b, i8** %a, align 8, !tbaa !0
|
|
ret void
|
|
}
|
|
|
|
define void @FooInt(i64* nocapture %a, i64 %b) nounwind uwtable sanitize_thread {
|
|
entry:
|
|
; CHECK-LABEL: @FooInt
|
|
; CHECK: call void @__tsan_vptr_update
|
|
; CHECK: ret void
|
|
store i64 %b, i64* %a, align 8, !tbaa !0
|
|
ret void
|
|
}
|
|
|
|
|
|
declare i32 @Func1()
|
|
declare i32 @Func2()
|
|
|
|
; Test that we properly handle vector stores marked as vtable updates.
|
|
define void @VectorVptrUpdate(<2 x i8*>* nocapture %a, i8* %b) nounwind uwtable sanitize_thread {
|
|
entry:
|
|
; CHECK-LABEL: @VectorVptrUpdate
|
|
; CHECK: call void @__tsan_vptr_update{{.*}}Func1
|
|
; CHECK-NOT: call void @__tsan_vptr_update
|
|
; CHECK: ret void
|
|
store <2 x i8 *> <i8* bitcast(i32 ()* @Func1 to i8 *), i8* bitcast(i32 ()* @Func2 to i8 *)>, <2 x i8 *>* %a, align 8, !tbaa !0
|
|
ret void
|
|
}
|
|
|
|
!0 = !{!2, !2, i64 0}
|
|
!1 = !{!"Simple C/C++ TBAA"}
|
|
!2 = !{!"vtable pointer", !1}
|