baa3bf8f76
The difference is that now we don't error on out-of-comdat access to
internal global values. We copy them instead. This seems to match the
expectation of COFF linkers (see pr25686).
Original message:
Start deciding earlier what to link.
A traditional linker is roughly split in symbol resolution and
"copying
stuff".
The two tasks are badly mixed in lib/Linker.
This starts splitting them apart.
With this patch there are no direct call to linkGlobalValueBody or
linkGlobalValueProto. Everything is linked via WapValue.
This also includes a few fixes:
* A GV goes undefined if the comdat is dropped (comdat11.ll).
* We error if an internal GV goes undefined (comdat13.ll).
* We don't link an unused comdat.
The first two match the behavior of an ELF linker. The second one is
equivalent to running globaldce on the input.
llvm-svn: 254418
9 lines
140 B
LLVM
9 lines
140 B
LLVM
; RUN: llvm-link %s -S -o - | FileCheck %s
|
|
|
|
$foo = comdat largest
|
|
define internal void @foo() comdat($foo) {
|
|
ret void
|
|
}
|
|
|
|
; CHECK-NOT: foo
|