baa3bf8f76
The difference is that now we don't error on out-of-comdat access to
internal global values. We copy them instead. This seems to match the
expectation of COFF linkers (see pr25686).
Original message:
Start deciding earlier what to link.
A traditional linker is roughly split in symbol resolution and
"copying
stuff".
The two tasks are badly mixed in lib/Linker.
This starts splitting them apart.
With this patch there are no direct call to linkGlobalValueBody or
linkGlobalValueProto. Everything is linked via WapValue.
This also includes a few fixes:
* A GV goes undefined if the comdat is dropped (comdat11.ll).
* We error if an internal GV goes undefined (comdat13.ll).
* We don't link an unused comdat.
The first two match the behavior of an ELF linker. The second one is
equivalent to running globaldce on the input.
llvm-svn: 254418
31 lines
832 B
LLVM
31 lines
832 B
LLVM
; RUN: llvm-link -S %s %p/Inputs/comdat13.ll -o - | FileCheck %s
|
|
|
|
; In Inputs/comdat13.ll a function not in the $foo comdat (zed) references an
|
|
; internal function in the comdat $foo.
|
|
; The IR would be ilegal on ELF ("relocation refers to discarded section"),
|
|
; but COFF linkers seem to just duplicate the comdat.
|
|
|
|
$foo = comdat any
|
|
@foo = internal global i8 0, comdat
|
|
define i8* @bar() {
|
|
ret i8* @foo
|
|
}
|
|
|
|
; CHECK: $foo = comdat any
|
|
|
|
; CHECK: @foo = internal global i8 0, comdat
|
|
; CHECK: @foo.1 = internal global i8 1, comdat($foo)
|
|
|
|
; CHECK: define i8* @bar() {
|
|
; CHECK-NEXT: ret i8* @foo
|
|
; CHECK-NEXT: }
|
|
|
|
; CHECK: define i8* @zed() {
|
|
; CHECK-NEXT: call void @bax()
|
|
; CHECK-NEXT: ret i8* @foo.1
|
|
; CHECK-NEXT: }
|
|
|
|
; CHECK: define internal void @bax() comdat($foo) {
|
|
; CHECK-NEXT: ret void
|
|
; CHECK-NEXT: }
|