6d354ed72e
Before this patch, debugify would insert debug value intrinsics before the terminating instruction in a block. This had the advantage of being simple, but was a bit too simple/unrealistic. This patch teaches debugify to insert debug values immediately after their operand defs. This enables better testing of the compiler. For example, with this patch, `opt -debugify-each` is able to identify a vectorizer DI-invariance bug fixed in llvm.org/PR32761. In this bug, the vectorizer produced different output with/without debug info present. Reverting Davide's bugfix locally, I see: $ ~/scripts/opt-check-dbg-invar.sh ./bin/opt \ .../SLPVectorizer/AArch64/spillcost-di.ll -slp-vectorizer Comparing: -slp-vectorizer .../SLPVectorizer/AArch64/spillcost-di.ll Baseline: /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.iYYeL1kf With DI : /var/folders/j8/t4w0bp8j6x1g6fpghkcb4sjm0000gp/T/tmp.sQtQSeet 9,11c9,11 < %5 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1 < %6 = bitcast i64* %4 to <2 x i64>* < %7 = load <2 x i64>, <2 x i64>* %6, align 8, !tbaa !0 --- > %5 = load i64, i64* %4, align 8, !tbaa !0 > %6 = getelementptr inbounds %0, %0* %2, i64 %0, i32 1 > %7 = load i64, i64* %6, align 8, !tbaa !5 12a13 > store i64 %5, i64* %8, align 8, !tbaa !0 14,15c15 < %10 = bitcast i64* %8 to <2 x i64>* < store <2 x i64> %7, <2 x i64>* %10, align 8, !tbaa !0 --- > store i64 %7, i64* %9, align 8, !tbaa !5 :: Found a test case ^ Running this over the *.ll files in tree, I found four additional examples which compile differently with/without DI present. I plan on filing bugs for these. llvm-svn: 334118
35 lines
1.3 KiB
LLVM
35 lines
1.3 KiB
LLVM
; RUN: opt < %s -debugify -basicaa -dse -S | FileCheck %s
|
|
|
|
target datalayout = "E-p:64:64:64-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128"
|
|
|
|
declare noalias i8* @malloc(i32)
|
|
|
|
declare void @test_f()
|
|
|
|
define i32* @test_salvage() {
|
|
; Check that all four original local variables have their values preserved.
|
|
; CHECK-LABEL: @test_salvage()
|
|
; CHECK-NEXT: malloc
|
|
; CHECK-NEXT: @llvm.dbg.value(metadata i8* %p, metadata ![[p:.*]], metadata !DIExpression())
|
|
; CHECK-NEXT: bitcast
|
|
; CHECK-NEXT: @llvm.dbg.value(metadata i32* %P, metadata ![[P:.*]], metadata !DIExpression())
|
|
; CHECK-NEXT: @llvm.dbg.value(metadata i32* %P, metadata ![[DEAD:.*]], metadata !DIExpression(DW_OP_deref))
|
|
; CHECK-NEXT: call void @llvm.dbg.value(metadata i32* %P, metadata ![[DEAD2:.*]], metadata !DIExpression(DW_OP_deref, DW_OP_plus_uconst, 1, DW_OP_stack_value))
|
|
; CHECK-NEXT: call void @test_f()
|
|
; CHECK-NEXT: store i32 0, i32* %P
|
|
|
|
%p = tail call i8* @malloc(i32 4)
|
|
%P = bitcast i8* %p to i32*
|
|
%DEAD = load i32, i32* %P
|
|
%DEAD2 = add i32 %DEAD, 1
|
|
store i32 %DEAD2, i32* %P
|
|
call void @test_f()
|
|
store i32 0, i32* %P
|
|
ret i32* %P
|
|
}
|
|
|
|
; CHECK: ![[p]] = !DILocalVariable(name: "1"
|
|
; CHECK: ![[P]] = !DILocalVariable(name: "2"
|
|
; CHECK: ![[DEAD]] = !DILocalVariable(name: "3"
|
|
; CHECK: ![[DEAD2]] = !DILocalVariable(name: "4"
|