Summary: This is a resurrection of work first proposed and discussed in Aug 2015: http://lists.llvm.org/pipermail/llvm-dev/2015-August/089384.html and initially landed (but then backed out) in Nov 2015: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20151109/312083.html The @llvm.memcpy/memmove/memset intrinsics currently have an explicit argument which is required to be a constant integer. It represents the alignment of the dest (and source), and so must be the minimum of the actual alignment of the two. This change is the first in a series that allows source and dest to each have their own alignments by using the alignment attribute on their arguments. In this change we: 1) Remove the alignment argument. 2) Add alignment attributes to the source & dest arguments. We, temporarily, require that the alignments for source & dest be equal. For example, code which used to read: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %dest, i8* %src, i32 100, i32 4, i1 false) will now read call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %dest, i8* align 4 %src, i32 100, i1 false) Downstream users may have to update their lit tests that check for @llvm.memcpy/memmove/memset call/declaration patterns. The following extended sed script may help with updating the majority of your tests, but it does not catch all possible patterns so some manual checking and updating will be required. s~declare void @llvm\.mem(set|cpy|move)\.p([^(]*)\((.*), i32, i1\)~declare void @llvm.mem\1.p\2(\3, i1)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* \3, i8 \4, i8 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* \3, i8 \4, i16 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* \3, i8 \4, i32 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* \3, i8 \4, i64 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* \3, i8 \4, i128 \5, i1 \6)~g s~call void @llvm\.memset\.p([^(]*)i8\(i8([^*]*)\* (.*), i8 (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i8(i8\2* align \6 \3, i8 \4, i8 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i16\(i8([^*]*)\* (.*), i8 (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i16(i8\2* align \6 \3, i8 \4, i16 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i32\(i8([^*]*)\* (.*), i8 (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i32(i8\2* align \6 \3, i8 \4, i32 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i64\(i8([^*]*)\* (.*), i8 (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i64(i8\2* align \6 \3, i8 \4, i64 \5, i1 \7)~g s~call void @llvm\.memset\.p([^(]*)i128\(i8([^*]*)\* (.*), i8 (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.memset.p\1i128(i8\2* align \6 \3, i8 \4, i128 \5, i1 \7)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* \4, i8\5* \6, i8 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* \4, i8\5* \6, i16 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* \4, i8\5* \6, i32 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* \4, i8\5* \6, i64 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 [01], i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* \4, i8\5* \6, i128 \7, i1 \8)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i8\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i8 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i8(i8\3* align \8 \4, i8\5* align \8 \6, i8 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i16\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i16 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i16(i8\3* align \8 \4, i8\5* align \8 \6, i16 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i32\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i32 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i32(i8\3* align \8 \4, i8\5* align \8 \6, i32 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i64\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i64 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i64(i8\3* align \8 \4, i8\5* align \8 \6, i64 \7, i1 \9)~g s~call void @llvm\.mem(cpy|move)\.p([^(]*)i128\(i8([^*]*)\* (.*), i8([^*]*)\* (.*), i128 (.*), i32 ([0-9]*), i1 ([^)]*)\)~call void @llvm.mem\1.p\2i128(i8\3* align \8 \4, i8\5* align \8 \6, i128 \7, i1 \9)~g The remaining changes in the series will: Step 2) Expand the IRBuilder API to allow creation of memcpy/memmove with differing source and dest alignments. Step 3) Update Clang to use the new IRBuilder API. Step 4) Update Polly to use the new IRBuilder API. Step 5) Update LLVM passes that create memcpy/memmove calls to use the new IRBuilder API, and those that use use MemIntrinsicInst::[get|set]Alignment() to use getDestAlignment() and getSourceAlignment() instead. Step 6) Remove the single-alignment IRBuilder API for memcpy/memmove, and the MemIntrinsicInst::[get|set]Alignment() methods. Reviewers: pete, hfinkel, lhames, reames, bollu Reviewed By: reames Subscribers: niosHD, reames, jholewinski, qcolombet, jfb, sanjoy, arsenm, dschuff, dylanmckay, mehdi_amini, sdardis, nemanjai, david2050, nhaehnle, javed.absar, sbc100, jgravelle-google, eraman, aheejin, kbarton, JDevlieghere, asb, rbar, johnrusso, simoncook, jordy.potman.lists, apazos, sabuasal, llvm-commits Differential Revision: https://reviews.llvm.org/D41675 llvm-svn: 322965
181 lines
5.7 KiB
LLVM
181 lines
5.7 KiB
LLVM
; RUN: opt -S < %s -instcombine | FileCheck %s
|
|
target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-f80:128:128-v64:64:64-v128:128:128-a0:0:64-f80:32:32-n8:16:32-S32"
|
|
|
|
@G = constant [3 x i8] c"%s\00" ; <[3 x i8]*> [#uses=1]
|
|
|
|
declare i32 @sprintf(i8*, i8*, ...)
|
|
|
|
define void @foo(i8* %P, i32* %X) {
|
|
call i32 (i8*, i8*, ...) @sprintf( i8* %P, i8* getelementptr ([3 x i8], [3 x i8]* @G, i32 0, i32 0), i32* %X ) ; <i32>:1 [#uses=0]
|
|
ret void
|
|
}
|
|
|
|
; PR1307
|
|
@str = internal constant [5 x i8] c"foog\00"
|
|
@str1 = internal constant [8 x i8] c"blahhh!\00"
|
|
@str2 = internal constant [5 x i8] c"Ponk\00"
|
|
|
|
define i8* @test1() {
|
|
%tmp3 = tail call i8* @strchr( i8* getelementptr ([5 x i8], [5 x i8]* @str, i32 0, i32 2), i32 103 ) ; <i8*> [#uses=1]
|
|
ret i8* %tmp3
|
|
|
|
; CHECK-LABEL: @test1(
|
|
; CHECK: ret i8* getelementptr inbounds ([5 x i8], [5 x i8]* @str, i32 0, i32 3)
|
|
}
|
|
|
|
declare i8* @strchr(i8*, i32)
|
|
|
|
define i8* @test2() {
|
|
%tmp3 = tail call i8* @strchr( i8* getelementptr ([8 x i8], [8 x i8]* @str1, i32 0, i32 2), i32 0 ) ; <i8*> [#uses=1]
|
|
ret i8* %tmp3
|
|
|
|
; CHECK-LABEL: @test2(
|
|
; CHECK: ret i8* getelementptr inbounds ([8 x i8], [8 x i8]* @str1, i32 0, i32 7)
|
|
}
|
|
|
|
define i8* @test3() {
|
|
entry:
|
|
%tmp3 = tail call i8* @strchr( i8* getelementptr ([5 x i8], [5 x i8]* @str2, i32 0, i32 1), i32 80 ) ; <i8*> [#uses=1]
|
|
ret i8* %tmp3
|
|
|
|
; CHECK-LABEL: @test3(
|
|
; CHECK: ret i8* null
|
|
}
|
|
|
|
@_2E_str = external constant [5 x i8] ; <[5 x i8]*> [#uses=1]
|
|
|
|
declare i32 @memcmp(i8*, i8*, i32) nounwind readonly
|
|
|
|
define i1 @PR2341(i8** %start_addr) {
|
|
entry:
|
|
%tmp4 = load i8*, i8** %start_addr, align 4 ; <i8*> [#uses=1]
|
|
%tmp5 = call i32 @memcmp( i8* %tmp4, i8* getelementptr ([5 x i8], [5 x i8]* @_2E_str, i32 0, i32 0), i32 4 ) nounwind readonly ; <i32> [#uses=1]
|
|
%tmp6 = icmp eq i32 %tmp5, 0 ; <i1> [#uses=1]
|
|
ret i1 %tmp6
|
|
|
|
; CHECK-LABEL: @PR2341(
|
|
; CHECK: i32
|
|
}
|
|
|
|
define i32 @PR4284() nounwind {
|
|
entry:
|
|
%c0 = alloca i8, align 1 ; <i8*> [#uses=2]
|
|
%c2 = alloca i8, align 1 ; <i8*> [#uses=2]
|
|
store i8 64, i8* %c0
|
|
store i8 -127, i8* %c2
|
|
%call = call i32 @memcmp(i8* %c0, i8* %c2, i32 1) ; <i32> [#uses=1]
|
|
ret i32 %call
|
|
|
|
; CHECK-LABEL: @PR4284(
|
|
; CHECK: ret i32 -65
|
|
}
|
|
|
|
%struct.__sFILE = type { i8*, i32, i32, i16, i16, %struct.__sbuf, i32, i8*, i32 (i8*)*, i32 (i8*, i8*, i32)*, i64 (i8*, i64, i32)*, i32 (i8*, i8*, i32)*, %struct.__sbuf, i8*, i32, [3 x i8], [1 x i8], %struct.__sbuf, i32, i64, %struct.pthread_mutex*, %struct.pthread*, i32, i32, %union.anon }
|
|
%struct.__sbuf = type { i8*, i32, [4 x i8] }
|
|
%struct.pthread = type opaque
|
|
%struct.pthread_mutex = type opaque
|
|
%union.anon = type { i64, [120 x i8] }
|
|
@.str13 = external constant [2 x i8] ; <[2 x i8]*> [#uses=1]
|
|
@.str14 = external constant [2 x i8] ; <[2 x i8]*> [#uses=1]
|
|
|
|
define i32 @PR4641(i32 %argc, i8** %argv) nounwind {
|
|
entry:
|
|
call void @exit(i32 0) nounwind
|
|
%cond392 = select i1 undef, i8* getelementptr ([2 x i8], [2 x i8]* @.str13, i32 0, i32 0), i8* getelementptr ([2 x i8], [2 x i8]* @.str14, i32 0, i32 0) ; <i8*> [#uses=1]
|
|
%call393 = call %struct.__sFILE* @fopen(i8* undef, i8* %cond392) nounwind ; <%struct.__sFILE*> [#uses=0]
|
|
unreachable
|
|
}
|
|
|
|
declare %struct.__sFILE* @fopen(i8*, i8*)
|
|
|
|
declare void @exit(i32)
|
|
|
|
define i32 @PR4645() {
|
|
entry:
|
|
br label %if.then
|
|
|
|
lor.lhs.false: ; preds = %while.body
|
|
br i1 undef, label %if.then, label %for.cond
|
|
|
|
if.then: ; preds = %lor.lhs.false, %while.body
|
|
call void @exit(i32 1)
|
|
br label %for.cond
|
|
|
|
for.cond: ; preds = %for.end, %if.then, %lor.lhs.false
|
|
%j.0 = phi i32 [ %inc47, %for.end ], [ 0, %if.then ], [ 0, %lor.lhs.false ] ; <i32> [#uses=1]
|
|
unreachable
|
|
|
|
for.end: ; preds = %for.cond20
|
|
%inc47 = add i32 %j.0, 1 ; <i32> [#uses=1]
|
|
br label %for.cond
|
|
}
|
|
|
|
@h = constant [2 x i8] c"h\00" ; <[2 x i8]*> [#uses=1]
|
|
@hel = constant [4 x i8] c"hel\00" ; <[4 x i8]*> [#uses=1]
|
|
@hello_u = constant [8 x i8] c"hello_u\00" ; <[8 x i8]*> [#uses=1]
|
|
|
|
define i32 @MemCpy() {
|
|
%h_p = getelementptr [2 x i8], [2 x i8]* @h, i32 0, i32 0
|
|
%hel_p = getelementptr [4 x i8], [4 x i8]* @hel, i32 0, i32 0
|
|
%hello_u_p = getelementptr [8 x i8], [8 x i8]* @hello_u, i32 0, i32 0
|
|
%target = alloca [1024 x i8]
|
|
%target_p = getelementptr [1024 x i8], [1024 x i8]* %target, i32 0, i32 0
|
|
call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 2 %target_p, i8* align 2 %h_p, i32 2, i1 false)
|
|
call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 4 %target_p, i8* align 4 %hel_p, i32 4, i1 false)
|
|
call void @llvm.memcpy.p0i8.p0i8.i32(i8* align 8 %target_p, i8* align 8 %hello_u_p, i32 8, i1 false)
|
|
ret i32 0
|
|
|
|
; CHECK-LABEL: @MemCpy(
|
|
; CHECK-NOT: llvm.memcpy
|
|
; CHECK: ret i32 0
|
|
}
|
|
|
|
declare void @llvm.memcpy.p0i8.p0i8.i32(i8* nocapture, i8* nocapture, i32, i1) nounwind
|
|
|
|
declare i32 @strcmp(i8*, i8*) #0
|
|
|
|
define void @test9(i8* %x) {
|
|
; CHECK-LABEL: @test9(
|
|
; CHECK-NOT: strcmp
|
|
%y = call i32 @strcmp(i8* %x, i8* %x) #1
|
|
ret void
|
|
}
|
|
|
|
; PR30484 - https://llvm.org/bugs/show_bug.cgi?id=30484
|
|
; These aren't the library functions you're looking for...
|
|
|
|
declare i32 @isdigit(i8)
|
|
declare i32 @isascii(i8)
|
|
declare i32 @toascii(i8)
|
|
|
|
define i32 @fake_isdigit(i8 %x) {
|
|
; CHECK-LABEL: @fake_isdigit(
|
|
; CHECK-NEXT: [[Y:%.*]] = call i32 @isdigit(i8 %x)
|
|
; CHECK-NEXT: ret i32 [[Y]]
|
|
;
|
|
%y = call i32 @isdigit(i8 %x)
|
|
ret i32 %y
|
|
}
|
|
|
|
define i32 @fake_isascii(i8 %x) {
|
|
; CHECK-LABEL: @fake_isascii(
|
|
; CHECK-NEXT: [[Y:%.*]] = call i32 @isascii(i8 %x)
|
|
; CHECK-NEXT: ret i32 [[Y]]
|
|
;
|
|
%y = call i32 @isascii(i8 %x)
|
|
ret i32 %y
|
|
}
|
|
|
|
define i32 @fake_toascii(i8 %x) {
|
|
; CHECK-LABEL: @fake_toascii(
|
|
; CHECK-NEXT: [[Y:%.*]] = call i32 @toascii(i8 %x)
|
|
; CHECK-NEXT: ret i32 [[Y]]
|
|
;
|
|
%y = call i32 @toascii(i8 %x)
|
|
ret i32 %y
|
|
}
|
|
|
|
|
|
attributes #0 = { nobuiltin }
|
|
attributes #1 = { builtin }
|