550517bcab
Summary: This is a follow-up to r334830 and r335031. In the valueCoversEntireFragment check we now also handle the situation when there is a variable length array (VLA) involved, and the length of the array has been reduced to a constant. The ConvertDebugDeclareToDebugValue functions that are related to PHI nodes and load instructions now avoid inserting dbg.value intrinsics when the value does not, for certain, cover the variable/fragment that should be described. In r334830 we assumed that the value always covered the entire var/fragment and we had assertions in the code to show that assumption. However, those asserts failed when compiling code with VLAs, so we removed the asserts in r335031. Now when we know that the valueCoversEntireFragment check can fail also for PHI/Load instructions we avoid to insert the faulty dbg.value intrinsic in such situations. Compared to the Store instruction scenario we simply drop the dbg.value here (as the variable does not change its value due to PHI/Load, so an earlier dbg.value describing the variable should still be valid). Reviewers: aprantl, vsk, efriedma Reviewed By: aprantl Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D48547 llvm-svn: 335580
63 lines
2.9 KiB
LLVM
63 lines
2.9 KiB
LLVM
; RUN: opt < %s -mem2reg -S | FileCheck %s
|
|
|
|
; Testing conversion from dbg.declare to dbg.value when the variable is a VLA.
|
|
;
|
|
; We can't derive the size of the variable simply by looking at the
|
|
; metadata. But we can find out the size by examining the alloca, so we should
|
|
; know that the load/store instructions are referencing the whole variable,
|
|
; and we expect to get dbg.value intrinsics that maps %entryN (aka %[[PHI]])
|
|
; and %t0 to the variable allocated as %vla1.
|
|
|
|
; ModuleID = 'debug-alloca-vla.ll'
|
|
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
|
|
target triple = "x86_64-apple-macosx10.12.0"
|
|
|
|
; Function Attrs: nounwind ssp uwtable
|
|
define void @scan() #0 !dbg !4 {
|
|
entry:
|
|
%vla1 = alloca i32, i32 1, align 8
|
|
call void @llvm.dbg.declare(metadata i32* %vla1, metadata !10, metadata !DIExpression()), !dbg !18
|
|
br label %for.cond, !dbg !18
|
|
|
|
for.cond: ; preds = %for.cond, %entry
|
|
; CHECK: %[[PHI:.*]] = phi i32 [ undef, %entry ], [ %t0, %for.cond ]
|
|
%entryN = load i32, i32* %vla1, align 8, !dbg !18
|
|
; CHECK: call void @llvm.dbg.value(metadata i32 %[[PHI]],
|
|
; CHECK-SAME: metadata !DIExpression())
|
|
%t0 = add i32 %entryN, 1
|
|
; CHECK: %t0 = add i32 %[[PHI]], 1
|
|
; CHECK: call void @llvm.dbg.value(metadata i32 %t0,
|
|
; CHECK-SAME: metadata !DIExpression())
|
|
store i32 %t0, i32* %vla1, align 8, !dbg !18
|
|
br label %for.cond, !dbg !18
|
|
}
|
|
|
|
; Function Attrs: nounwind readnone speculatable
|
|
declare void @llvm.dbg.declare(metadata, metadata, metadata) #1
|
|
|
|
attributes #0 = { nounwind ssp uwtable }
|
|
attributes #1 = { nounwind readnone speculatable }
|
|
|
|
!llvm.dbg.cu = !{!0}
|
|
!llvm.module.flags = !{!2, !3}
|
|
|
|
!0 = distinct !DICompileUnit(language: DW_LANG_C99, file: !1, producer: "adrian", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug)
|
|
!1 = !DIFile(filename: "<stdin>", directory: "/")
|
|
!2 = !{i32 2, !"Debug Info Version", i32 3}
|
|
!3 = !{i32 7, !"PIC Level", i32 2}
|
|
!4 = distinct !DISubprogram(name: "scan", scope: !1, file: !1, line: 4, type: !5, isLocal: false, isDefinition: true, scopeLine: 5, flags: DIFlagPrototyped, isOptimized: true, unit: !0, retainedNodes: !8)
|
|
!5 = !DISubroutineType(types: !6)
|
|
!6 = !{null, !7, !7}
|
|
!7 = !DIBasicType(name: "char", size: 8, encoding: DW_ATE_signed_char)
|
|
!8 = !{!9}
|
|
!9 = !DILocalVariable(name: "entry", scope: !4, file: !1, line: 6, type: !7)
|
|
!10 = !DILocalVariable(name: "ptr32", scope: !4, file: !1, line: 240, type: !11)
|
|
!11 = !DICompositeType(tag: DW_TAG_array_type, baseType: !12, elements: !14)
|
|
!12 = !DIDerivedType(tag: DW_TAG_typedef, name: "__uint32_t", file: !1, line: 41, baseType: !13)
|
|
!13 = !DIBasicType(name: "unsigned int", size: 32, encoding: DW_ATE_unsigned)
|
|
!14 = !{!15}
|
|
!15 = !DISubrange(count: !16)
|
|
!16 = !DILocalVariable(name: "__vla_expr", scope: !4, type: !17, flags: DIFlagArtificial)
|
|
!17 = !DIBasicType(name: "long unsigned int", size: 64, encoding: DW_ATE_unsigned)
|
|
!18 = !DILocation(line: 6, scope: !4)
|