7693b116a1
In commit r219005 lifetime markers have been introduced to mark the lifetime of the OpenMP context data structure. However, their use seems incorrect and recently caused a miscompile in ASC_Sequoia/CrystalMk after r298053 which was not at all related to r298053. r298053 only caused a change in the loop order, as this change resulted in a different isl internal representation which caused the scheduler to derive a different schedule. This change then caused the IR to change, which apparently created a pattern in which LLVM exploites the lifetime markers. It seems we are using the OpenMP context outside of the lifetime markers. Even though CrystalMk could probably be fixed by expanding the scope of the lifetime markers, it is not clear what happens in case the OpenMP function call is in a loop which will cause a sequence of starting and ending lifetimes. As it is unlikely that the lifetime markers give any performance benefit, we just drop them to remove complexity. llvm-svn: 298192
46 lines
1.6 KiB
LLVM
46 lines
1.6 KiB
LLVM
; RUN: opt %loadPolly -polly-parallel -polly-parallel-force -polly-ast -analyze < %s | FileCheck %s -check-prefix=AST
|
|
; RUN: opt %loadPolly -polly-parallel -polly-parallel-force -polly-codegen -S < %s | FileCheck %s -check-prefix=IR
|
|
|
|
; Make sure we correctly forward the reference to 'A' to the OpenMP subfunction.
|
|
;
|
|
; void loop_references_outer_ids(float *A) {
|
|
; for (long i = 0; i < 100; i++)
|
|
; A[i] = i;
|
|
; }
|
|
|
|
|
|
; AST: #pragma simd
|
|
; AST: #pragma omp parallel for
|
|
; AST: for (int c0 = 0; c0 <= 99; c0 += 1)
|
|
; AST: Stmt_for_body(c0);
|
|
|
|
; IR-LABEL: polly.parallel.for:
|
|
; IR-NEXT: %polly.subfn.storeaddr.A = getelementptr inbounds { float* }, { float* }* %polly.par.userContext, i32 0, i32 0
|
|
; IR-NEXT: store float* %A, float** %polly.subfn.storeaddr.A
|
|
; IR-NEXT: %polly.par.userContext1 = bitcast { float* }* %polly.par.userContext to i8*
|
|
|
|
target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
|
|
|
|
define void @loop_references_outer_ids(float* %A) {
|
|
entry:
|
|
br label %for.cond
|
|
|
|
for.cond: ; preds = %for.inc, %entry
|
|
%i.0 = phi i64 [ 0, %entry ], [ %inc, %for.inc ]
|
|
%exitcond = icmp ne i64 %i.0, 100
|
|
br i1 %exitcond, label %for.body, label %for.end
|
|
|
|
for.body: ; preds = %for.cond
|
|
%conv = sitofp i64 %i.0 to float
|
|
%arrayidx = getelementptr inbounds float, float* %A, i64 %i.0
|
|
store float %conv, float* %arrayidx, align 4
|
|
br label %for.inc
|
|
|
|
for.inc: ; preds = %for.body
|
|
%inc = add nsw i64 %i.0, 1
|
|
br label %for.cond
|
|
|
|
for.end: ; preds = %for.cond
|
|
ret void
|
|
}
|