0c18d03d91
Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is unprintable. Example, before: NSLog(@"%\u25B9"); => warning: invalid conversion specifier ' [-Wformat-invalid-specifier] after: NSLog(@"%\u25B9"); => warning: invalid conversion specifier '\u25b9' [-Wformat-invalid-specifier] Differential Revision: http://reviews.llvm.org/D18296 rdar://problem/24672159 llvm-svn: 264752
81 lines
2.5 KiB
C++
81 lines
2.5 KiB
C++
#ifndef LLVM_CLANG_LIB_ANALYSIS_FORMATSTRINGPARSING_H
|
|
#define LLVM_CLANG_LIB_ANALYSIS_FORMATSTRINGPARSING_H
|
|
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/AST/Type.h"
|
|
#include "clang/Analysis/Analyses/FormatString.h"
|
|
#include "llvm/Support/raw_ostream.h"
|
|
|
|
namespace clang {
|
|
|
|
class LangOptions;
|
|
|
|
template <typename T>
|
|
class UpdateOnReturn {
|
|
T &ValueToUpdate;
|
|
const T &ValueToCopy;
|
|
public:
|
|
UpdateOnReturn(T &valueToUpdate, const T &valueToCopy)
|
|
: ValueToUpdate(valueToUpdate), ValueToCopy(valueToCopy) {}
|
|
|
|
~UpdateOnReturn() {
|
|
ValueToUpdate = ValueToCopy;
|
|
}
|
|
};
|
|
|
|
namespace analyze_format_string {
|
|
|
|
OptionalAmount ParseAmount(const char *&Beg, const char *E);
|
|
OptionalAmount ParseNonPositionAmount(const char *&Beg, const char *E,
|
|
unsigned &argIndex);
|
|
|
|
OptionalAmount ParsePositionAmount(FormatStringHandler &H,
|
|
const char *Start, const char *&Beg,
|
|
const char *E, PositionContext p);
|
|
|
|
bool ParseFieldWidth(FormatStringHandler &H,
|
|
FormatSpecifier &CS,
|
|
const char *Start, const char *&Beg, const char *E,
|
|
unsigned *argIndex);
|
|
|
|
bool ParseArgPosition(FormatStringHandler &H,
|
|
FormatSpecifier &CS, const char *Start,
|
|
const char *&Beg, const char *E);
|
|
|
|
/// Returns true if a LengthModifier was parsed and installed in the
|
|
/// FormatSpecifier& argument, and false otherwise.
|
|
bool ParseLengthModifier(FormatSpecifier &FS, const char *&Beg, const char *E,
|
|
const LangOptions &LO, bool IsScanf = false);
|
|
|
|
/// Returns true if the invalid specifier in \p SpecifierBegin is a UTF-8
|
|
/// string; check that it won't go further than \p FmtStrEnd and write
|
|
/// up the total size in \p Len.
|
|
bool ParseUTF8InvalidSpecifier(const char *SpecifierBegin,
|
|
const char *FmtStrEnd, unsigned &Len);
|
|
|
|
template <typename T> class SpecifierResult {
|
|
T FS;
|
|
const char *Start;
|
|
bool Stop;
|
|
public:
|
|
SpecifierResult(bool stop = false)
|
|
: Start(nullptr), Stop(stop) {}
|
|
SpecifierResult(const char *start,
|
|
const T &fs)
|
|
: FS(fs), Start(start), Stop(false) {}
|
|
|
|
const char *getStart() const { return Start; }
|
|
bool shouldStop() const { return Stop; }
|
|
bool hasValue() const { return Start != nullptr; }
|
|
const T &getValue() const {
|
|
assert(hasValue());
|
|
return FS;
|
|
}
|
|
const T &getValue() { return FS; }
|
|
};
|
|
|
|
} // end analyze_format_string namespace
|
|
} // end clang namespace
|
|
|
|
#endif
|