This commit adds a static analysis checker to verify the correct usage of the MPI API in C and C++. This version updates the reverted r271981 to fix a memory corruption found by the ASan bots. Three path-sensitive checks are included: - Double nonblocking: Double request usage by nonblocking calls without intermediate wait - Missing wait: Nonblocking call without matching wait. - Unmatched wait: Waiting for a request that was never used by a nonblocking call Examples of how to use the checker can be found at https://github.com/0ax1/MPI-Checker A patch by Alexander Droste! Reviewers: zaks.anna, dcoughlin Differential Revision: http://reviews.llvm.org/D21081 llvm-svn: 272529
35 lines
1.8 KiB
C++
35 lines
1.8 KiB
C++
// RUN: %clang_cc1 -analyze -analyzer-checker=optin.mpi.MPI-Checker -analyzer-output=text -verify %s
|
|
|
|
// MPI-Checker test file to test note diagnostics.
|
|
|
|
#include "MPIMock.h"
|
|
|
|
void doubleNonblocking() {
|
|
double buf = 0;
|
|
MPI_Request sendReq;
|
|
MPI_Isend(&buf, 1, MPI_DOUBLE, 0, 0, MPI_COMM_WORLD, &sendReq); // expected-note{{Request is previously used by nonblocking call here.}}
|
|
MPI_Irecv(&buf, 1, MPI_DOUBLE, 0, 0, MPI_COMM_WORLD, &sendReq); // expected-warning{{Double nonblocking on request 'sendReq'.}} expected-note{{Double nonblocking on request 'sendReq'.}}
|
|
MPI_Wait(&sendReq, MPI_STATUS_IGNORE);
|
|
}
|
|
|
|
void missingWait() {
|
|
double buf = 0;
|
|
MPI_Request sendReq;
|
|
MPI_Ireduce(MPI_IN_PLACE, &buf, 1, MPI_DOUBLE, MPI_SUM, 0, MPI_COMM_WORLD, &sendReq); // expected-note{{Request is previously used by nonblocking call here.}}
|
|
} // expected-warning{{Request 'sendReq' has no matching wait.}} expected-note{{Request 'sendReq' has no matching wait.}}
|
|
|
|
// If more than 2 nonblocking calls are using a request in a sequence, they all
|
|
// point to the first call as the 'previous' call. This is because the
|
|
// BugReporterVisitor only checks for differences in state or existence of an
|
|
// entity.
|
|
void tripleNonblocking() {
|
|
double buf = 0;
|
|
MPI_Request sendReq;
|
|
MPI_Isend(&buf, 1, MPI_DOUBLE, 0, 0, MPI_COMM_WORLD, &sendReq); // expected-note 2{{Request is previously used by nonblocking call here.}}
|
|
MPI_Irecv(&buf, 1, MPI_DOUBLE, 0, 0, MPI_COMM_WORLD, &sendReq); // expected-warning{{Double nonblocking on request 'sendReq'.}} expected-note{{Double nonblocking on request 'sendReq'.}}
|
|
|
|
MPI_Isend(&buf, 1, MPI_DOUBLE, 0, 0, MPI_COMM_WORLD, &sendReq); // expected-warning{{Double nonblocking on request 'sendReq'.}} expected-note{{Double nonblocking on request 'sendReq'.}}
|
|
|
|
MPI_Wait(&sendReq, MPI_STATUS_IGNORE);
|
|
}
|