a212c58db0
Summary: In D18689, I removed the call to Normalize() in FileSpec::SetFile, because it no longer seemed needed, and it resolved a quirk in the FileSpec API (spec.GetCString() returnes a path with backslashes, but spec.GetDirectory().GetCString() has forward slashes). This turned out to be a problem because we would consider paths with different separators as different (which led to unresolved breakpoints for instance). Here, I am putting back in the call to Normalize() and adding a unittest for FileSpec::Equal. I am commenting out the GetDirectory unittests until we figure out the what is the expected behaviour here. Reviewers: zturner Subscribers: lldb-commits Differential Revision: http://reviews.llvm.org/D19060 llvm-svn: 266286
112 lines
5.2 KiB
C++
112 lines
5.2 KiB
C++
//===-- FileSpecTest.cpp ----------------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "lldb/Host/FileSpec.h"
|
|
|
|
using namespace lldb_private;
|
|
|
|
TEST(FileSpecTest, FileAndDirectoryComponents)
|
|
{
|
|
FileSpec fs_posix("/foo/bar", false, FileSpec::ePathSyntaxPosix);
|
|
EXPECT_STREQ("/foo/bar", fs_posix.GetCString());
|
|
EXPECT_STREQ("/foo", fs_posix.GetDirectory().GetCString());
|
|
EXPECT_STREQ("bar", fs_posix.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows("F:\\bar", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_STREQ("F:\\bar", fs_windows.GetCString());
|
|
// EXPECT_STREQ("F:\\", fs_windows.GetDirectory().GetCString()); // It returns "F:/"
|
|
EXPECT_STREQ("bar", fs_windows.GetFilename().GetCString());
|
|
|
|
FileSpec fs_posix_root("/", false, FileSpec::ePathSyntaxPosix);
|
|
EXPECT_STREQ("/", fs_posix_root.GetCString());
|
|
EXPECT_EQ(nullptr, fs_posix_root.GetDirectory().GetCString());
|
|
EXPECT_STREQ("/", fs_posix_root.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows_drive("F:", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_STREQ("F:", fs_windows_drive.GetCString());
|
|
EXPECT_EQ(nullptr, fs_windows_drive.GetDirectory().GetCString());
|
|
EXPECT_STREQ("F:", fs_windows_drive.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows_root("F:\\", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_STREQ("F:\\", fs_windows_root.GetCString());
|
|
EXPECT_STREQ("F:", fs_windows_root.GetDirectory().GetCString());
|
|
// EXPECT_STREQ("\\", fs_windows_root.GetFilename().GetCString()); // It returns "/"
|
|
|
|
FileSpec fs_posix_long("/foo/bar/baz", false, FileSpec::ePathSyntaxPosix);
|
|
EXPECT_STREQ("/foo/bar/baz", fs_posix_long.GetCString());
|
|
EXPECT_STREQ("/foo/bar", fs_posix_long.GetDirectory().GetCString());
|
|
EXPECT_STREQ("baz", fs_posix_long.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows_long("F:\\bar\\baz", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_STREQ("F:\\bar\\baz", fs_windows_long.GetCString());
|
|
// EXPECT_STREQ("F:\\bar", fs_windows_long.GetDirectory().GetCString()); // It returns "F:/bar"
|
|
EXPECT_STREQ("baz", fs_windows_long.GetFilename().GetCString());
|
|
|
|
FileSpec fs_posix_trailing_slash("/foo/bar/", false, FileSpec::ePathSyntaxPosix);
|
|
EXPECT_STREQ("/foo/bar/.", fs_posix_trailing_slash.GetCString());
|
|
EXPECT_STREQ("/foo/bar", fs_posix_trailing_slash.GetDirectory().GetCString());
|
|
EXPECT_STREQ(".", fs_posix_trailing_slash.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows_trailing_slash("F:\\bar\\", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_STREQ("F:\\bar\\.", fs_windows_trailing_slash.GetCString());
|
|
// EXPECT_STREQ("F:\\bar", fs_windows_trailing_slash.GetDirectory().GetCString()); // It returns "F:/bar"
|
|
EXPECT_STREQ(".", fs_windows_trailing_slash.GetFilename().GetCString());
|
|
}
|
|
|
|
TEST(FileSpecTest, AppendPathComponent)
|
|
{
|
|
FileSpec fs_posix("/foo", false, FileSpec::ePathSyntaxPosix);
|
|
fs_posix.AppendPathComponent("bar");
|
|
EXPECT_STREQ("/foo/bar", fs_posix.GetCString());
|
|
EXPECT_STREQ("/foo", fs_posix.GetDirectory().GetCString());
|
|
EXPECT_STREQ("bar", fs_posix.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows("F:\\bar", false, FileSpec::ePathSyntaxWindows);
|
|
fs_windows.AppendPathComponent("baz");
|
|
EXPECT_STREQ("F:\\bar\\baz", fs_windows.GetCString());
|
|
// EXPECT_STREQ("F:\\bar", fs_windows.GetDirectory().GetCString()); // It returns "F:/bar"
|
|
EXPECT_STREQ("baz", fs_windows.GetFilename().GetCString());
|
|
|
|
FileSpec fs_posix_root("/", false, FileSpec::ePathSyntaxPosix);
|
|
fs_posix_root.AppendPathComponent("bar");
|
|
EXPECT_STREQ("/bar", fs_posix_root.GetCString());
|
|
EXPECT_STREQ("/", fs_posix_root.GetDirectory().GetCString());
|
|
EXPECT_STREQ("bar", fs_posix_root.GetFilename().GetCString());
|
|
|
|
FileSpec fs_windows_root("F:\\", false, FileSpec::ePathSyntaxWindows);
|
|
fs_windows_root.AppendPathComponent("bar");
|
|
EXPECT_STREQ("F:\\bar", fs_windows_root.GetCString());
|
|
// EXPECT_STREQ("F:\\", fs_windows_root.GetDirectory().GetCString()); // It returns "F:/"
|
|
EXPECT_STREQ("bar", fs_windows_root.GetFilename().GetCString());
|
|
}
|
|
|
|
TEST(FileSpecTest, CopyByAppendingPathComponent)
|
|
{
|
|
FileSpec fs = FileSpec("/foo", false, FileSpec::ePathSyntaxPosix).CopyByAppendingPathComponent("bar");
|
|
EXPECT_STREQ("/foo/bar", fs.GetCString());
|
|
EXPECT_STREQ("/foo", fs.GetDirectory().GetCString());
|
|
EXPECT_STREQ("bar", fs.GetFilename().GetCString());
|
|
}
|
|
|
|
TEST(FileSpecTest, Equal)
|
|
{
|
|
FileSpec backward("C:\\foo\\bar", false, FileSpec::ePathSyntaxWindows);
|
|
FileSpec forward("C:/foo/bar", false, FileSpec::ePathSyntaxWindows);
|
|
EXPECT_EQ(forward, backward);
|
|
|
|
const bool full_match = true;
|
|
const bool remove_backup_dots = true;
|
|
EXPECT_TRUE(FileSpec::Equal(forward, backward, full_match, remove_backup_dots));
|
|
EXPECT_TRUE(FileSpec::Equal(forward, backward, full_match, !remove_backup_dots));
|
|
EXPECT_TRUE(FileSpec::Equal(forward, backward, !full_match, remove_backup_dots));
|
|
EXPECT_TRUE(FileSpec::Equal(forward, backward, !full_match, !remove_backup_dots));
|
|
}
|