fd893bda55
This fixes https://bugs.llvm.org/show_bug.cgi?id=47118. Before this change, when the sigaction interceptor prevented a signal from being changed, it also prevented the oldact output parameter from being written to. This resulted in a use-of-uninitialized-variable by any program that used sigaction for the purpose of reading signals. This change fixes this: the regular sigaction implementation is still called, but with the act parameter nullified, preventing any changes. Patch By: IanPudney Reviewed By: morehouse Differential Revision: https://reviews.llvm.org/D85797
26 lines
761 B
C++
26 lines
761 B
C++
// RUN: %clangxx_msan -O0 -g %s -o %t
|
|
// RUN: MSAN_OPTIONS=handle_segv=2 %t 2>&1 | FileCheck %s
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <signal.h>
|
|
#include <string.h>
|
|
|
|
extern "C" int __interceptor_sigaction(int signum, const struct sigaction *act, struct sigaction *oldact);
|
|
extern "C" int sigaction(int signum, const struct sigaction *act, struct sigaction *oldact) {
|
|
write(2, "sigaction call\n", sizeof("sigaction call\n") - 1);
|
|
return __interceptor_sigaction(signum, act, oldact);
|
|
}
|
|
|
|
int main() {
|
|
struct sigaction oldact;
|
|
sigaction(SIGSEGV, nullptr, &oldact);
|
|
|
|
if (oldact.sa_handler || oldact.sa_sigaction) {
|
|
fprintf(stderr, "oldact filled\n");
|
|
}
|
|
return 0;
|
|
// CHECK: sigaction call
|
|
// CHECK: oldact filled
|
|
}
|