Summary: This commit removes the concrete_frame_idx member from NativeRegisterContext and related functions, which was always set to zero and never used. I also change the native thread class to store a NativeRegisterContext as a unique_ptr (documenting the ownership) and make sure it is always initialized (most of the code was already blindly dereferencing the register context pointer, assuming it would always be present -- this makes its treatment consistent). Reviewers: eugene, clayborg, krytarowski Subscribers: aemerson, sdardis, nemanjai, javed.absar, arichardson, kristof.beyls, kbarton, uweigand, alexandreyy, lldb-commits Differential Revision: https://reviews.llvm.org/D39837 llvm-svn: 317881
55 lines
1.9 KiB
C++
55 lines
1.9 KiB
C++
//===-- NativeThreadProtocol.cpp --------------------------------*- C++ -*-===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "lldb/Host/common/NativeThreadProtocol.h"
|
|
|
|
#include "lldb/Host/common/NativeProcessProtocol.h"
|
|
#include "lldb/Host/common/NativeRegisterContext.h"
|
|
#include "lldb/Host/common/SoftwareBreakpoint.h"
|
|
|
|
using namespace lldb;
|
|
using namespace lldb_private;
|
|
|
|
NativeThreadProtocol::NativeThreadProtocol(NativeProcessProtocol &process,
|
|
lldb::tid_t tid)
|
|
: m_process(process), m_tid(tid) {}
|
|
|
|
Status NativeThreadProtocol::ReadRegister(uint32_t reg,
|
|
RegisterValue ®_value) {
|
|
NativeRegisterContext ®ister_context = GetRegisterContext();
|
|
|
|
const RegisterInfo *const reg_info =
|
|
register_context.GetRegisterInfoAtIndex(reg);
|
|
if (!reg_info)
|
|
return Status("no register info for reg num %" PRIu32, reg);
|
|
|
|
return register_context.ReadRegister(reg_info, reg_value);
|
|
;
|
|
}
|
|
|
|
Status NativeThreadProtocol::WriteRegister(uint32_t reg,
|
|
const RegisterValue ®_value) {
|
|
NativeRegisterContext& register_context = GetRegisterContext();
|
|
|
|
const RegisterInfo *const reg_info =
|
|
register_context.GetRegisterInfoAtIndex(reg);
|
|
if (!reg_info)
|
|
return Status("no register info for reg num %" PRIu32, reg);
|
|
|
|
return register_context.WriteRegister(reg_info, reg_value);
|
|
}
|
|
|
|
Status NativeThreadProtocol::SaveAllRegisters(lldb::DataBufferSP &data_sp) {
|
|
return GetRegisterContext().WriteAllRegisterValues(data_sp);
|
|
}
|
|
|
|
Status NativeThreadProtocol::RestoreAllRegisters(lldb::DataBufferSP &data_sp) {
|
|
return GetRegisterContext().ReadAllRegisterValues(data_sp);
|
|
}
|