clang-p2996

Files

Yingwei Zheng c727b48287 [SDAG][ISel][TableGen][LoongArch] Report error for trivial bitcasts when there are predicate calls (#116075 )

On loongarch64 with lsx extension, we select `VBITREV_W` for `v4i32 (xor
X, (shl splat(1), Y))`:

8e66303916/llvm/lib/Target/LoongArch/LoongArchLSXInstrInfo.td (L1583-L1584)

And `vsplat_imm_eq_1` is defined as:

8e66303916/llvm/lib/Target/LoongArch/LoongArchLSXInstrInfo.td (L77-L87)

For the `(bitconvert (v4i32 (build_vector)))` case, the pattern is
expected to be:
```
PATTERN: (xor:{ *:[v4i32] } v4i32:{ *:[v4i32] }:$vj, (shl:{ *:[v4i32] } (bitconvert:{ *:[v4i32] } (build_vector:{ *:[v4i32] }))<<P:Predicate_vsplat_imm_eq_1>>, v4i32:{ *:[v4i32] }:$vk))
RESULT:  (VBITREV_W:{ *:[v4i32] } v4i32:{ *:[v4i32] }:$vj, v4i32:{ *:[v4i32] }:$vk)
```

However, `simplifyTree` drops the `bitconvert` node and its predicates:

8e66303916/llvm/utils/TableGen/Common/CodeGenDAGPatterns.cpp (L3036-L3062)

Then llvm will match `vsplat_imm_eq_1` for any v4i32 splats and cause a
miscompilation:
```
PATTERN: (xor:{ *:[v4i32] } v4i32:{ *:[v4i32] }:$vj, (shl:{ *:[v4i32] } (build_vector:{ *:[v4i32] }), v4i32:{ *:[v4i32] }:$vk))
RESULT:  (VBITREV_W:{ *:[v4i32] } v4i32:{ *:[v4i32] }:$vj, v4i32:{ *:[v4i32] }:$vk)
```

This patch adds additional checks for predicates associated with the
trivial bitconvert node. Unused patterns in the LoongArch target are
also removed.

Fixes https://github.com/llvm/llvm-project/issues/116008.

2024-11-19 21:24:40 +08:00

ir-instruction

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

lasx

[LoongArch] Optimize vreplgr2vr + vinsgr2vr intrinsic sequence (#115803 )

2024-11-12 19:07:53 +08:00

lsx

[SDAG][ISel][TableGen][LoongArch] Report error for trivial bitcasts when there are predicate calls (#116075 )

2024-11-19 21:24:40 +08:00

addrspacecast.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

alloca.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

alsl.ll

[LoongArch] Custom legalize i32 operations for LA64 to reduce signed extensions (#93811 )

2024-06-03 13:23:35 +08:00

analyze-branch.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

andn-icmp.ll

[LoongArch] Recommit "Remove spurious mask operations from andn->icmp on 16 and 8 bit values" (#99798 )

2024-07-22 15:10:21 +08:00

annotate-tablejump.ll

[LoongArch] Add options for annotate tablejump

2024-10-16 11:58:00 +08:00

atomicrmw-cond-sub-clamp.ll

Add usub_cond and usub_sat operations to atomicrmw (#105568 )

2024-09-06 16:19:20 +01:00

atomicrmw-uinc-udec-wrap.ll

[LoongArch] Custom legalize i32 operations for LA64 to reduce signed extensions (#93811 )

2024-06-03 13:23:35 +08:00

bitreverse.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

block-address.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

blockaddress-symbol.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bnez-beqz.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

branch-relaxation-spill-32.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

branch-relaxation-spill-64.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

branch-relaxation.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bstrins_d.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bstrins_w.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bstrpick_d.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bstrpick_w.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bswap-bitreverse.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bswap.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

bytepick.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

calling-conv-common.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

calling-conv-lp64d.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

calling-conv-lp64s.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

can-not-realign-stack.ll

[LoongArch] Merge base and offset for LSX/LASX memory accesses (#104452 )

2024-08-19 15:23:05 +08:00

cfr-copy.mir

…

cfr-pseudo-copy.mir

…

code-models.ll

[LoongArch] Ensure pcaddu18i and jirl adjacency in tail calls for correct relocation (#113932 )

2024-11-01 00:08:15 +08:00

cpu-name-generic.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

cpus-invalid.ll

…

cpus.ll

[LoongArch] Support la664 (#100068 )

2024-07-23 15:14:20 +08:00

ctlz-cttz-ctpop.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

ctpop-with-lsx.ll

[LoongArch] Legalize ISD::CTPOP for GRLenVT type with LSX

2024-09-06 15:46:43 +08:00

double-br-fcmp.ll

…

double-fcmp-strict.ll

…

double-fcmps-strict.ll

…

double-fma.ll

…

double-imm.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

double-lround.ll

[LoongArch] Support llvm.lround intrinsics with i32 return type. (#114733 )

2024-11-06 17:34:13 +08:00

duplicate-returns-for-tailcall.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

dwarf-eh.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

e_flags.ll

[MC][LoongArch] Change default cpu in MCSubtargetInfo. (#114922 )

2024-11-11 16:46:22 +08:00

eh-dwarf-cfa.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

emergency-spill-slot.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

emutls.ll

[LoongArch] Emit error messages when using emulated TLS

2024-06-12 17:41:26 +08:00

exception-pointer-register.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

expand-adjacency.ll

[LoongArch] Ensure pcaddu18i and jirl adjacency in tail calls for correct relocation (#113932 )

2024-11-01 00:08:15 +08:00

expand-call.ll

[LoongArch] Reimplement to prevent Pseudo{CALL, LA*}_LARGE instruction reordering (#100099 )

2024-07-30 14:22:53 +08:00

fabs.ll

…

fcopysign.ll

…

fdiv-reciprocal-estimate.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

feature-32bit.ll

…

float-br-fcmp.ll

…

float-fcmp-strict.ll

…

float-fcmps-strict.ll

…

float-fma.ll

…

float-imm-vldi.ll

[LoongArch] Load floating-point immediate using VLDI (#101923 )

2024-08-09 14:08:32 +08:00

float-imm.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

float-lround.ll

[LoongArch] Support llvm.lround intrinsics with i32 return type. (#114733 )

2024-11-06 17:34:13 +08:00

fp16-promote.ll

[loongarch][DAG][FREEZE] Fix crash when FREEZE a half(f16) type on loongarch (#107791 )

2024-09-13 08:49:54 +08:00

fp-expand.ll

…

fp-max-min.ll

…

fp-maximumnum-minimumnum.ll

Intrinsic: introduce minimumnum and maximumnum for IR and SelectionDAG (#96649 )

2024-08-15 14:09:36 +08:00

fp-reciprocal.ll

…

fp-rounding.ll

[LoongArch] Use LSX for scalar FP rounding with explicit rounding mode (#114766 )

2024-11-06 09:26:28 +08:00

fp-trunc-store.ll

…

frame.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

frameaddr-returnaddr.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

frint.ll

…

fsqrt-reciprocal-estimate.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

fsqrt.ll

…

gep-imm.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

get-reg-error-la32.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

get-reg-error-la64.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

get-reg.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

get-setcc-result-type.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

ghc-cc.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

global-address.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

global-variable-code-model.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

imm.ll

[LoongArch] Optimize for immediate value materialization using BSTRINS_D instruction

2024-08-30 16:38:42 +08:00

inline-asm-clobbers-fcc.mir

…

inline-asm-clobbers.ll

…

inline-asm-constraint-error.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

inline-asm-constraint-f.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

inline-asm-constraint-k.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-constraint-m.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

inline-asm-constraint-ZB.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-constraint-ZC.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-constraint.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-operand-modifiers.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-reg-names-error.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

inline-asm-reg-names-f-error.ll

…

inline-asm-reg-names-f.ll

…

inline-asm-reg-names.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-csr-side-effects.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-error.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

intrinsic-frecipe-dbl.ll

…

intrinsic-frecipe-flt.ll

…

intrinsic-iocsr-side-effects.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-la32-error.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-la32.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-la64-error.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic-la64.ll

[LoongArch] Add a pass to rewrite rd to r0 for non-computational instrs whose return values are unused (#94590 )

2024-06-07 15:39:05 +08:00

intrinsic-memcpy.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

intrinsic-not-constant-error.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

intrinsic.ll

[LoongArch] Add a pass to rewrite rd to r0 for non-computational instrs whose return values are unused (#94590 )

2024-06-07 15:39:05 +08:00

is_fpclass_f32.ll

…

is_fpclass_f64.ll

…

jr-without-ra.ll

[LoongArch] Avoid indirect branch jumps using the ra register

2024-11-11 14:15:22 +08:00

jump-table.ll

[LoongArch] Set isAsCheapAsAMove on ADDI.D and {X}ORI instructions (#94733 )

2024-06-12 22:02:47 +08:00

ldptr.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

ldx-stx-sp-1.ll

…

ldx-stx-sp-2.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

ldx-stx-sp-3.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

legalicmpimm.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

libcall-extend.ll

[LoongArch] Suppress the unnecessary extensions for arguments in makeLibCall

2024-05-17 09:13:51 +08:00

lit.local.cfg

…

load-store-offset.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

machinelicm-address-pseudos.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

mafft-Lalignmm.ll

…

memcmp.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

merge-base-offset.ll

[LoongArch] Merge base and offset for large offsets (#113277 )

2024-10-23 19:43:23 +08:00

merge-load-store.ll

[LoongArch] Enable alias analysis by default (#114980 )

2024-11-06 19:30:57 +08:00

mir-target-flags.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

naked-fn-with-frame-pointer.ll

[llvm] Consistently respect naked fn attribute in TargetFrameLowering::hasFP() (#106014 )

2024-10-18 09:35:42 +04:00

nomerge.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

not.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

numeric-reg-names.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

O0-pipeline.ll

[ExtendLifetimes] Implement llvm.fake.use to extend variable lifetimes (#86149 )

2024-08-29 17:53:32 +01:00

opt-pipeline.ll

Revert "TLS loads opimization (hoist)" (#114740 )

2024-11-07 10:10:28 +01:00

patchable-function-entry.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

prefer-w-inst.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

preferred-alignments.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

psabi-restricted-scheduling.ll

[LoongArch] Add machine function pass to merge base + offset (#101139 )

2024-08-08 23:05:38 +08:00

[LoongArch] Set isAsCheapAsAMove on ADDI.D and {X}ORI instructions (#94733 )

2024-06-12 22:02:47 +08:00

returnaddr-error.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

rotl-rotr.ll

[LoongArch] Optimize codegen for ISD::ROTL (#100344 )

2024-07-30 14:22:24 +08:00

scmp.ll

[SelectionDAG] Expand [US]CMP using arithmetic on boolean values instead of selects (#98774 )

2024-07-16 20:56:18 +01:00

select-const.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

select-to-shiftand.ll

[LoongArch] Custom legalize i32 operations for LA64 to reduce signed extensions (#93811 )

2024-06-03 13:23:35 +08:00

sext-cheaper-than-zext.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

sextw-removal.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

shift-masked-shamt.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

shrinkwrap.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

smul-with-overflow.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

soft-fp-to-int.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

spill-ra-without-kill.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

spill-reload-cfr.ll

…

split-sp-adjust.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

stack-realignment-with-variable-sized-objects.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

stack-realignment.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

statepoint-call-lowering-r1.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

statepoint-call-lowering.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

stptr.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

tail-calls.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

target_support.ll

…

target-abi-from-triple-edge-cases.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

target-abi-from-triple.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

target-abi.ll

[LoongArch] Enable all -target-abi options

2024-05-16 16:54:18 +08:00

test_bl_fixupkind.mir

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

thread-pointer.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

tls-models.ll

[LoongArch] Reimplement to prevent Pseudo{CALL, LA*}_LARGE instruction reordering (#100099 )

2024-07-30 14:22:53 +08:00

trap.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

typepromotion-overflow.ll

[LoongArch] Enable the TypePromotion pass from AArch64 (#98868 )

2024-07-17 12:21:44 +08:00

ucmp.ll

[LegalizeTypes][RISCV][LoongArch] Optimize promotion of ucmp. (#101366 )

2024-07-31 17:18:27 -07:00

unaligned-access.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

unaligned-memcpy-inline.ll

[LoongArch] Align stack objects passed to memory intrinsics (#101309 )

2024-08-02 11:28:03 +08:00

vararg.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

vector-fp-imm.ll

[LoongArch] Enable FeatureExtLSX for generic-la64 processor (#113421 )

2024-10-31 15:58:15 +08:00

xray-attribute-instrumentation.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00

zext-with-load-is-free.ll

[test][LoongArch] Add -mattr=+d option. NFC

2024-05-14 20:23:04 +08:00