516803dc86
Summary: This patch addresses https://bugs.llvm.org/show_bug.cgi?id=46256 The spec of coroutine requires that the expression co_await promise.final_suspend() shall not be potentially-throwing. To check this, we recursively look at every call (including Call, MemberCall, OperatorCall and Constructor) in all code generated by the final suspend, and ensure that the callees are declared with noexcept. We also look at any returned data type that requires explicit destruction, and check their destructors for noexcept. This patch does not check declarations with dependent types yet, which will be done in future patches. Updated all tests to add noexcept to the required functions, and added a dedicated test for this patch. This patch might start to cause existing codebase fail to compile because most people may not have been strict in tagging all the related functions noexcept. Reviewers: lewissbaker, modocache, junparser Reviewed By: modocache Subscribers: arphaman, junparser, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D82029
43 lines
1.3 KiB
C++
43 lines
1.3 KiB
C++
// Test without serialization:
|
|
// RUN: %clang_cc1 -triple x86_64-apple-darwin9 %s -std=c++14 -fcoroutines-ts \
|
|
// RUN: -fsyntax-only -ast-dump | FileCheck %s
|
|
//
|
|
// Test with serialization:
|
|
// RUN: %clang_cc1 -triple x86_64-apple-darwin9 -std=c++14 -fcoroutines-ts -emit-pch -o %t %s
|
|
// RUN: %clang_cc1 -x c++ -triple x86_64-apple-darwin9 -std=c++14 -fcoroutines-ts -include-pch %t \
|
|
// RUN: -ast-dump-all /dev/null \
|
|
// RUN: | sed -e "s/ <undeserialized declarations>//" -e "s/ imported//" \
|
|
// RUN: | FileCheck %s
|
|
|
|
#include "Inputs/std-coroutine.h"
|
|
|
|
using namespace std::experimental;
|
|
|
|
struct A {
|
|
bool await_ready();
|
|
void await_resume();
|
|
template <typename F>
|
|
void await_suspend(F);
|
|
};
|
|
|
|
struct coro_t {
|
|
struct promise_type {
|
|
coro_t get_return_object();
|
|
suspend_never initial_suspend();
|
|
suspend_never final_suspend() noexcept;
|
|
void return_void();
|
|
static void unhandled_exception();
|
|
};
|
|
};
|
|
|
|
// {{0x[0-9a-fA-F]+}} <line:[[@LINE+1]]:1, col:36>
|
|
// CHECK-LABEL: FunctionDecl {{.*}} f 'coro_t (int)'
|
|
coro_t f(int n) {
|
|
A a{};
|
|
// CHECK: CoawaitExpr {{0x[0-9a-fA-F]+}} <col:3, col:12>
|
|
// CHECK-NEXT: DeclRefExpr {{0x[0-9a-fA-F]+}} <col:12>
|
|
// CHECK-NEXT: CXXMemberCallExpr {{0x[0-9a-fA-F]+}} <col:12>
|
|
// CHECK-NEXT: MemberExpr {{0x[0-9a-fA-F]+}} <col:12>
|
|
co_await a;
|
|
}
|