The MLIR classes Type/Attribute/Operation/Op/Value support cast/dyn_cast/isa/dyn_cast_or_null functionality through llvm's doCast functionality in addition to defining methods with the same name. This change begins the migration of uses of the method to the corresponding function call as has been decided as more consistent. Note that there still exist classes that only define methods directly, such as AffineExpr, and this does not include work currently to support a functional cast/isa call. Caveats include: - This clang-tidy script probably has more problems. - This only touches C++ code, so nothing that is being generated. Context: - https://mlir.llvm.org/deprecation/ at "Use the free function variants for dyn_cast/cast/isa/…" - Original discussion at https://discourse.llvm.org/t/preferred-casting-style-going-forward/68443 Implementation: This first patch was created with the following steps. The intention is to only do automated changes at first, so I waste less time if it's reverted, and so the first mass change is more clear as an example to other teams that will need to follow similar steps. Steps are described per line, as comments are removed by git: 0. Retrieve the change from the following to build clang-tidy with an additional check: https://github.com/llvm/llvm-project/compare/main...tpopp:llvm-project:tidy-cast-check 1. Build clang-tidy 2. Run clang-tidy over your entire codebase while disabling all checks and enabling the one relevant one. Run on all header files also. 3. Delete .inc files that were also modified, so the next build rebuilds them to a pure state. 4. Some changes have been deleted for the following reasons: - Some files had a variable also named cast - Some files had not included a header file that defines the cast functions - Some files are definitions of the classes that have the casting methods, so the code still refers to the method instead of the function without adding a prefix or removing the method declaration at the same time. ``` ninja -C $BUILD_DIR clang-tidy run-clang-tidy -clang-tidy-binary=$BUILD_DIR/bin/clang-tidy -checks='-*,misc-cast-functions'\ -header-filter=mlir/ mlir/* -fix rm -rf $BUILD_DIR/tools/mlir/**/*.inc git restore mlir/lib/IR mlir/lib/Dialect/DLTI/DLTI.cpp\ mlir/lib/Dialect/Complex/IR/ComplexDialect.cpp\ mlir/lib/**/IR/\ mlir/lib/Dialect/SparseTensor/Transforms/SparseVectorization.cpp\ mlir/lib/Dialect/Vector/Transforms/LowerVectorMultiReduction.cpp\ mlir/test/lib/Dialect/Test/TestTypes.cpp\ mlir/test/lib/Dialect/Transform/TestTransformDialectExtension.cpp\ mlir/test/lib/Dialect/Test/TestAttributes.cpp\ mlir/unittests/TableGen/EnumsGenTest.cpp\ mlir/test/python/lib/PythonTestCAPI.cpp\ mlir/include/mlir/IR/ ``` Differential Revision: https://reviews.llvm.org/D150123
227 lines
7.8 KiB
C++
227 lines
7.8 KiB
C++
//===- TestAliasAnalysis.cpp - Test alias analysis results ----------------===//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file contains test passes for constructing and testing alias analysis
|
|
// results.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "TestAliasAnalysis.h"
|
|
#include "mlir/Analysis/AliasAnalysis.h"
|
|
#include "mlir/Analysis/AliasAnalysis/LocalAliasAnalysis.h"
|
|
#include "mlir/IR/FunctionInterfaces.h"
|
|
#include "mlir/Pass/Pass.h"
|
|
|
|
using namespace mlir;
|
|
|
|
/// Print a value that is used as an operand of an alias query.
|
|
static void printAliasOperand(Operation *op) {
|
|
llvm::errs() << op->getAttrOfType<StringAttr>("test.ptr").getValue();
|
|
}
|
|
static void printAliasOperand(Value value) {
|
|
if (BlockArgument arg = dyn_cast<BlockArgument>(value)) {
|
|
Region *region = arg.getParentRegion();
|
|
unsigned parentBlockNumber =
|
|
std::distance(region->begin(), arg.getOwner()->getIterator());
|
|
llvm::errs() << region->getParentOp()
|
|
->getAttrOfType<StringAttr>("test.ptr")
|
|
.getValue()
|
|
<< ".region" << region->getRegionNumber();
|
|
if (parentBlockNumber != 0)
|
|
llvm::errs() << ".block" << parentBlockNumber;
|
|
llvm::errs() << "#" << arg.getArgNumber();
|
|
return;
|
|
}
|
|
OpResult result = cast<OpResult>(value);
|
|
printAliasOperand(result.getOwner());
|
|
llvm::errs() << "#" << result.getResultNumber();
|
|
}
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void printAliasResult(AliasResult result, Value lhs, Value rhs) {
|
|
printAliasOperand(lhs);
|
|
llvm::errs() << " <-> ";
|
|
printAliasOperand(rhs);
|
|
llvm::errs() << ": " << result << "\n";
|
|
}
|
|
|
|
/// Print the result of an alias query.
|
|
void printModRefResult(ModRefResult result, Operation *op, Value location) {
|
|
printAliasOperand(op);
|
|
llvm::errs() << " -> ";
|
|
printAliasOperand(location);
|
|
llvm::errs() << ": " << result << "\n";
|
|
}
|
|
|
|
void TestAliasAnalysisBase::runAliasAnalysisOnOperation(
|
|
Operation *op, AliasAnalysis &aliasAnalysis) {
|
|
llvm::errs() << "Testing : " << op->getAttr("sym_name") << "\n";
|
|
|
|
// Collect all of the values to check for aliasing behavior.
|
|
SmallVector<Value, 32> valsToCheck;
|
|
op->walk([&](Operation *op) {
|
|
if (!op->getAttr("test.ptr"))
|
|
return;
|
|
valsToCheck.append(op->result_begin(), op->result_end());
|
|
for (Region ®ion : op->getRegions())
|
|
for (Block &block : region)
|
|
valsToCheck.append(block.args_begin(), block.args_end());
|
|
});
|
|
|
|
// Check for aliasing behavior between each of the values.
|
|
for (auto it = valsToCheck.begin(), e = valsToCheck.end(); it != e; ++it)
|
|
for (auto *innerIt = valsToCheck.begin(); innerIt != it; ++innerIt)
|
|
printAliasResult(aliasAnalysis.alias(*innerIt, *it), *innerIt, *it);
|
|
}
|
|
|
|
void TestAliasAnalysisModRefBase::runAliasAnalysisOnOperation(
|
|
Operation *op, AliasAnalysis &aliasAnalysis) {
|
|
llvm::errs() << "Testing : " << op->getAttr("sym_name") << "\n";
|
|
|
|
// Collect all of the values to check for aliasing behavior.
|
|
SmallVector<Value, 32> valsToCheck;
|
|
op->walk([&](Operation *op) {
|
|
if (!op->getAttr("test.ptr"))
|
|
return;
|
|
valsToCheck.append(op->result_begin(), op->result_end());
|
|
for (Region ®ion : op->getRegions())
|
|
for (Block &block : region)
|
|
valsToCheck.append(block.args_begin(), block.args_end());
|
|
});
|
|
|
|
// Check for aliasing behavior between each of the values.
|
|
for (auto &it : valsToCheck) {
|
|
op->walk([&](Operation *op) {
|
|
if (!op->getAttr("test.ptr"))
|
|
return;
|
|
printModRefResult(aliasAnalysis.getModRef(op, it), op, it);
|
|
});
|
|
}
|
|
}
|
|
|
|
} // namespace test
|
|
} // namespace mlir
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Testing AliasResult
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
struct TestAliasAnalysisPass
|
|
: public test::TestAliasAnalysisBase,
|
|
PassWrapper<TestAliasAnalysisPass, OperationPass<>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestAliasAnalysisPass)
|
|
|
|
StringRef getArgument() const final { return "test-alias-analysis"; }
|
|
StringRef getDescription() const final {
|
|
return "Test alias analysis results.";
|
|
}
|
|
void runOnOperation() override {
|
|
AliasAnalysis &aliasAnalysis = getAnalysis<AliasAnalysis>();
|
|
runAliasAnalysisOnOperation(getOperation(), aliasAnalysis);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Testing ModRefResult
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace {
|
|
struct TestAliasAnalysisModRefPass
|
|
: public test::TestAliasAnalysisModRefBase,
|
|
PassWrapper<TestAliasAnalysisModRefPass, OperationPass<>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestAliasAnalysisModRefPass)
|
|
|
|
StringRef getArgument() const final { return "test-alias-analysis-modref"; }
|
|
StringRef getDescription() const final {
|
|
return "Test alias analysis ModRef results.";
|
|
}
|
|
void runOnOperation() override {
|
|
AliasAnalysis &aliasAnalysis = getAnalysis<AliasAnalysis>();
|
|
runAliasAnalysisOnOperation(getOperation(), aliasAnalysis);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Testing LocalAliasAnalysis extending
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
/// Check if value is function argument.
|
|
static bool isFuncArg(Value val) {
|
|
auto blockArg = dyn_cast<BlockArgument>(val);
|
|
if (!blockArg)
|
|
return false;
|
|
|
|
return mlir::isa_and_nonnull<FunctionOpInterface>(
|
|
blockArg.getOwner()->getParentOp());
|
|
}
|
|
|
|
/// Check if value has "restrict" attribute. Value must be a function argument.
|
|
static bool isRestrict(Value val) {
|
|
auto blockArg = cast<BlockArgument>(val);
|
|
auto func =
|
|
mlir::cast<FunctionOpInterface>(blockArg.getOwner()->getParentOp());
|
|
return !!func.getArgAttr(blockArg.getArgNumber(),
|
|
"local_alias_analysis.restrict");
|
|
}
|
|
|
|
namespace {
|
|
/// LocalAliasAnalysis extended to support "restrict" attreibute.
|
|
class LocalAliasAnalysisRestrict : public LocalAliasAnalysis {
|
|
protected:
|
|
AliasResult aliasImpl(Value lhs, Value rhs) override {
|
|
if (lhs == rhs)
|
|
return AliasResult::MustAlias;
|
|
|
|
// Assume no aliasing if both values are function arguments and any of them
|
|
// have restrict attr.
|
|
if (isFuncArg(lhs) && isFuncArg(rhs))
|
|
if (isRestrict(lhs) || isRestrict(rhs))
|
|
return AliasResult::NoAlias;
|
|
|
|
return LocalAliasAnalysis::aliasImpl(lhs, rhs);
|
|
}
|
|
};
|
|
|
|
/// This pass tests adding additional analysis impls to the AliasAnalysis.
|
|
struct TestAliasAnalysisExtendingPass
|
|
: public test::TestAliasAnalysisBase,
|
|
PassWrapper<TestAliasAnalysisExtendingPass, OperationPass<>> {
|
|
MLIR_DEFINE_EXPLICIT_INTERNAL_INLINE_TYPE_ID(TestAliasAnalysisExtendingPass)
|
|
|
|
StringRef getArgument() const final {
|
|
return "test-alias-analysis-extending";
|
|
}
|
|
StringRef getDescription() const final {
|
|
return "Test alias analysis extending.";
|
|
}
|
|
void runOnOperation() override {
|
|
AliasAnalysis aliasAnalysis(getOperation());
|
|
aliasAnalysis.addAnalysisImplementation(LocalAliasAnalysisRestrict());
|
|
runAliasAnalysisOnOperation(getOperation(), aliasAnalysis);
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
//===----------------------------------------------------------------------===//
|
|
// Pass Registration
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
namespace mlir {
|
|
namespace test {
|
|
void registerTestAliasAnalysisPass() {
|
|
PassRegistration<TestAliasAnalysisExtendingPass>();
|
|
PassRegistration<TestAliasAnalysisModRefPass>();
|
|
PassRegistration<TestAliasAnalysisPass>();
|
|
}
|
|
} // namespace test
|
|
} // namespace mlir
|