clang-p2996

Files

Fangrui Song 9dce25a9fa [llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist

Exposed by D69041. If SHT_SYMTAB does not exist, ELFObjcopy.cpp:handleArgs will crash due
to a null pointer dereference.

  for (const NewSymbolInfo &SI : Config.ELF->SymbolsToAdd) {
    ...
    Obj.SymbolTable->addSymbol(

Fix this by creating .symtab and .strtab on demand in ELFBuilder<ELFT>::readSections,
if --add-symbol is specified.

Reviewed By: grimar

Differential Revision: https://reviews.llvm.org/D69093

llvm-svn: 375105

2019-10-17 11:21:54 +00:00

ELFConfig.cpp

[llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC.

2019-09-24 09:38:23 +00:00

ELFConfig.h

[llvm-objcopy] Refactor ELF-specific config out to ELFCopyConfig. NFC.

2019-09-24 09:38:23 +00:00

ELFObjcopy.cpp

[llvm-objcopy] --add-symbol: fix crash if SHT_SYMTAB does not exist

2019-10-17 11:21:54 +00:00

ELFObjcopy.h

[llvm-objcopy] Implement IHEX reader