During instruction selection, there is an inconsistency in choosing the initial soffset value. With certain early passes, this value is getting modified and that brought additional fixup during eliminateFrameIndex to work for all cases. This whole transformation looks trivial and can be handled better. This patch clearly defines the initial value for soffset and keeps it unchanged before eliminateFrameIndex. The initial value must be zero for MUBUF with a frame index. The non-frame index MUBUF forms that use a raw offset from SP will have the stack register for soffset. During frame elimination, the soffset remains zero for entry functions with zero dynamic allocas and no callsites, or else is updated to the appropriate frame/stack register. Also, did some code clean up and made all asserts around soffset stricter to match. Reviewed By: scott.linder Differential Revision: https://reviews.llvm.org/D95071
103 lines
4.9 KiB
LLVM
103 lines
4.9 KiB
LLVM
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
|
|
; RUN: llc < %s -march=amdgcn -mcpu=gfx1010 -verify-machineinstrs | FileCheck -check-prefix=MUBUF %s
|
|
; RUN: llc < %s -march=amdgcn -mcpu=gfx1010 -amdgpu-enable-flat-scratch -verify-machineinstrs | FileCheck -check-prefix=FLATSCR %s
|
|
|
|
; During instruction selection, we use immediate const zero for soffset in
|
|
; MUBUF stack accesses and let eliminateFrameIndex to fix up this field to use
|
|
; the correct frame register whenever required.
|
|
define amdgpu_kernel void @kernel_background_evaluate(float addrspace(5)* %kg, <4 x i32> addrspace(1)* %input, <4 x float> addrspace(1)* %output, i32 %i) {
|
|
; MUBUF-LABEL: kernel_background_evaluate:
|
|
; MUBUF: ; %bb.0: ; %entry
|
|
; MUBUF-NEXT: s_load_dword s0, s[0:1], 0x24
|
|
; MUBUF-NEXT: s_mov_b32 s36, SCRATCH_RSRC_DWORD0
|
|
; MUBUF-NEXT: s_mov_b32 s37, SCRATCH_RSRC_DWORD1
|
|
; MUBUF-NEXT: s_mov_b32 s38, -1
|
|
; MUBUF-NEXT: s_mov_b32 s39, 0x31c16000
|
|
; MUBUF-NEXT: s_add_u32 s36, s36, s3
|
|
; MUBUF-NEXT: s_addc_u32 s37, s37, 0
|
|
; MUBUF-NEXT: v_mov_b32_e32 v1, 0x2000
|
|
; MUBUF-NEXT: v_mov_b32_e32 v2, 0x4000
|
|
; MUBUF-NEXT: v_mov_b32_e32 v3, 0
|
|
; MUBUF-NEXT: v_mov_b32_e32 v4, 0x400000
|
|
; MUBUF-NEXT: s_mov_b32 s32, 0xc0000
|
|
; MUBUF-NEXT: v_add_nc_u32_e64 v40, 4, 0x4000
|
|
; MUBUF-NEXT: s_getpc_b64 s[4:5]
|
|
; MUBUF-NEXT: s_add_u32 s4, s4, svm_eval_nodes@rel32@lo+4
|
|
; MUBUF-NEXT: s_addc_u32 s5, s5, svm_eval_nodes@rel32@hi+12
|
|
; MUBUF-NEXT: s_waitcnt lgkmcnt(0)
|
|
; MUBUF-NEXT: v_mov_b32_e32 v0, s0
|
|
; MUBUF-NEXT: s_mov_b64 s[0:1], s[36:37]
|
|
; MUBUF-NEXT: s_mov_b64 s[2:3], s[38:39]
|
|
; MUBUF-NEXT: s_swappc_b64 s[30:31], s[4:5]
|
|
; MUBUF-NEXT: v_cmp_ne_u32_e32 vcc_lo, 0, v0
|
|
; MUBUF-NEXT: s_and_saveexec_b32 s0, vcc_lo
|
|
; MUBUF-NEXT: s_cbranch_execz BB0_2
|
|
; MUBUF-NEXT: ; %bb.1: ; %if.then4.i
|
|
; MUBUF-NEXT: s_clause 0x1
|
|
; MUBUF-NEXT: buffer_load_dword v0, v40, s[36:39], 0 offen
|
|
; MUBUF-NEXT: buffer_load_dword v1, v40, s[36:39], 0 offen offset:4
|
|
; MUBUF-NEXT: s_waitcnt vmcnt(0)
|
|
; MUBUF-NEXT: v_add_nc_u32_e32 v0, v1, v0
|
|
; MUBUF-NEXT: v_mul_lo_u32 v0, 0x41c64e6d, v0
|
|
; MUBUF-NEXT: v_add_nc_u32_e32 v0, 0x3039, v0
|
|
; MUBUF-NEXT: buffer_store_dword v0, v0, s[36:39], 0 offen
|
|
; MUBUF-NEXT: BB0_2: ; %shader_eval_surface.exit
|
|
; MUBUF-NEXT: s_endpgm
|
|
;
|
|
; FLATSCR-LABEL: kernel_background_evaluate:
|
|
; FLATSCR: ; %bb.0: ; %entry
|
|
; FLATSCR-NEXT: s_add_u32 s2, s2, s5
|
|
; FLATSCR-NEXT: s_movk_i32 s32, 0x6000
|
|
; FLATSCR-NEXT: s_addc_u32 s3, s3, 0
|
|
; FLATSCR-NEXT: s_setreg_b32 hwreg(HW_REG_FLAT_SCR_LO), s2
|
|
; FLATSCR-NEXT: s_setreg_b32 hwreg(HW_REG_FLAT_SCR_HI), s3
|
|
; FLATSCR-NEXT: s_load_dword s2, s[0:1], 0x24
|
|
; FLATSCR-NEXT: v_mov_b32_e32 v1, 0x2000
|
|
; FLATSCR-NEXT: v_mov_b32_e32 v2, 0x4000
|
|
; FLATSCR-NEXT: v_mov_b32_e32 v3, 0
|
|
; FLATSCR-NEXT: v_mov_b32_e32 v4, 0x400000
|
|
; FLATSCR-NEXT: s_getpc_b64 s[0:1]
|
|
; FLATSCR-NEXT: s_add_u32 s0, s0, svm_eval_nodes@rel32@lo+4
|
|
; FLATSCR-NEXT: s_addc_u32 s1, s1, svm_eval_nodes@rel32@hi+12
|
|
; FLATSCR-NEXT: s_waitcnt lgkmcnt(0)
|
|
; FLATSCR-NEXT: v_mov_b32_e32 v0, s2
|
|
; FLATSCR-NEXT: s_swappc_b64 s[30:31], s[0:1]
|
|
; FLATSCR-NEXT: v_cmp_ne_u32_e32 vcc_lo, 0, v0
|
|
; FLATSCR-NEXT: s_and_saveexec_b32 s0, vcc_lo
|
|
; FLATSCR-NEXT: s_cbranch_execz BB0_2
|
|
; FLATSCR-NEXT: ; %bb.1: ; %if.then4.i
|
|
; FLATSCR-NEXT: s_movk_i32 vcc_lo, 0x4000
|
|
; FLATSCR-NEXT: s_nop 1
|
|
; FLATSCR-NEXT: scratch_load_dwordx2 v[0:1], off, vcc_lo offset:4
|
|
; FLATSCR-NEXT: s_waitcnt vmcnt(0)
|
|
; FLATSCR-NEXT: v_add_nc_u32_e32 v0, v1, v0
|
|
; FLATSCR-NEXT: v_mul_lo_u32 v0, 0x41c64e6d, v0
|
|
; FLATSCR-NEXT: v_add_nc_u32_e32 v0, 0x3039, v0
|
|
; FLATSCR-NEXT: scratch_store_dword off, v0, s0
|
|
; FLATSCR-NEXT: BB0_2: ; %shader_eval_surface.exit
|
|
; FLATSCR-NEXT: s_endpgm
|
|
entry:
|
|
%sd = alloca < 1339 x i32>, align 8192, addrspace(5)
|
|
%state = alloca <4 x i32>, align 16, addrspace(5)
|
|
%rslt = call i32 @svm_eval_nodes(float addrspace(5)* %kg, <1339 x i32> addrspace(5)* %sd, <4 x i32> addrspace(5)* %state, i32 0, i32 4194304)
|
|
%cmp = icmp eq i32 %rslt, 0
|
|
br i1 %cmp, label %shader_eval_surface.exit, label %if.then4.i
|
|
|
|
if.then4.i: ; preds = %entry
|
|
%rng_hash.i.i = getelementptr inbounds < 4 x i32>, <4 x i32> addrspace(5)* %state, i32 0, i32 1
|
|
%tmp0 = load i32, i32 addrspace(5)* %rng_hash.i.i, align 4
|
|
%rng_offset.i.i = getelementptr inbounds <4 x i32>, <4 x i32> addrspace(5)* %state, i32 0, i32 2
|
|
%tmp1 = load i32, i32 addrspace(5)* %rng_offset.i.i, align 4
|
|
%add.i.i = add i32 %tmp1, %tmp0
|
|
%add1.i.i = add i32 %add.i.i, 0
|
|
%mul.i.i.i.i = mul i32 %add1.i.i, 1103515245
|
|
%add.i.i.i.i = add i32 %mul.i.i.i.i, 12345
|
|
store i32 %add.i.i.i.i, i32 addrspace(5)* undef, align 16
|
|
br label %shader_eval_surface.exit
|
|
|
|
shader_eval_surface.exit: ; preds = %entry
|
|
ret void
|
|
}
|
|
|
|
declare hidden i32 @svm_eval_nodes(float addrspace(5)*, <1339 x i32> addrspace(5)*, <4 x i32> addrspace(5)*, i32, i32) local_unnamed_addr
|