d9ab3e82f3
This avoids recomputing string length that is already known at compile time. It has a slight impact on preprocessing / compile time, see https://llvm-compile-time-tracker.com/compare.php?from=3f36d2d579d8b0e8824d9dd99bfa79f456858f88&to=e49640c507ddc6615b5e503144301c8e41f8f434&stat=instructions:u This a recommit ofe953ae5bbcand the subsequent fixescaa713559band06b90e2e9c. The above patchset caused some version of GCC to take eons to compile clang/lib/Basic/Targets/AArch64.cpp, as spotted inaa171833ab. The fix is to make BuiltinInfo tables a compilation unit static variable, instead of a private static variable. Differential Revision: https://reviews.llvm.org/D139881
68 lines
2.5 KiB
C++
68 lines
2.5 KiB
C++
//== PutenvWithAutoChecker.cpp --------------------------------- -*- C++ -*--=//
|
|
//
|
|
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
|
|
// See https://llvm.org/LICENSE.txt for license information.
|
|
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This file defines PutenvWithAutoChecker which finds calls of ``putenv``
|
|
// function with automatic variable as the argument.
|
|
// https://wiki.sei.cmu.edu/confluence/x/6NYxBQ
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "../AllocationState.h"
|
|
#include "clang/StaticAnalyzer/Checkers/BuiltinCheckerRegistration.h"
|
|
#include "clang/StaticAnalyzer/Core/BugReporter/BugType.h"
|
|
#include "clang/StaticAnalyzer/Core/Checker.h"
|
|
#include "clang/StaticAnalyzer/Core/CheckerManager.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CallDescription.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/CheckerContext.h"
|
|
#include "clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h"
|
|
|
|
using namespace clang;
|
|
using namespace ento;
|
|
|
|
namespace {
|
|
class PutenvWithAutoChecker : public Checker<check::PostCall> {
|
|
private:
|
|
BugType BT{this, "'putenv' function should not be called with auto variables",
|
|
categories::SecurityError};
|
|
const CallDescription Putenv{{"putenv"}, 1};
|
|
|
|
public:
|
|
void checkPostCall(const CallEvent &Call, CheckerContext &C) const;
|
|
};
|
|
} // namespace
|
|
|
|
void PutenvWithAutoChecker::checkPostCall(const CallEvent &Call,
|
|
CheckerContext &C) const {
|
|
if (!Putenv.matches(Call))
|
|
return;
|
|
|
|
SVal ArgV = Call.getArgSVal(0);
|
|
const Expr *ArgExpr = Call.getArgExpr(0);
|
|
const MemSpaceRegion *MSR = ArgV.getAsRegion()->getMemorySpace();
|
|
|
|
if (!isa<StackSpaceRegion>(MSR))
|
|
return;
|
|
|
|
StringRef ErrorMsg = "The 'putenv' function should not be called with "
|
|
"arguments that have automatic storage";
|
|
ExplodedNode *N = C.generateErrorNode();
|
|
auto Report = std::make_unique<PathSensitiveBugReport>(BT, ErrorMsg, N);
|
|
|
|
// Track the argument.
|
|
bugreporter::trackExpressionValue(Report->getErrorNode(), ArgExpr, *Report);
|
|
|
|
C.emitReport(std::move(Report));
|
|
}
|
|
|
|
void ento::registerPutenvWithAuto(CheckerManager &Mgr) {
|
|
Mgr.registerChecker<PutenvWithAutoChecker>();
|
|
}
|
|
|
|
bool ento::shouldRegisterPutenvWithAuto(const CheckerManager &) { return true; }
|