7d644e1215
C89 had a questionable feature where the compiler would implicitly declare a function that the user called but was never previously declared. The resulting function would be globally declared as extern int func(); -- a function without a prototype which accepts zero or more arguments. C99 removed support for this questionable feature due to severe security concerns. However, there was no deprecation period; C89 had the feature, C99 didn't. So Clang (and GCC) both supported the functionality as an extension in C99 and later modes. C2x no longer supports that function signature as it now requires all functions to have a prototype, and given the known security issues with the feature, continuing to support it as an extension is not tenable. This patch changes the diagnostic behavior for the -Wimplicit-function-declaration warning group depending on the language mode in effect. We continue to warn by default in C89 mode (due to the feature being dangerous to use). However, because this feature will not be supported in C2x mode, we've diagnosed it as being invalid for so long, the security concerns with the feature, and the trivial workaround for users (declare the function), we now default the extension warning to an error in C99-C17 mode. This still gives users an easy workaround if they are extensively using the extension in those modes (they can disable the warning or use -Wno-error to downgrade the error), but the new diagnostic makes it more clear that this feature is not supported and should be avoided. In C2x mode, we no longer allow an implicit function to be defined and treat the situation the same as any other lookup failure. Differential Revision: https://reviews.llvm.org/D122983
33 lines
1.2 KiB
C
33 lines
1.2 KiB
C
// RUN: %clang_analyze_cc1 %s -verify -Wno-error=implicit-function-declaration \
|
|
// RUN: -analyzer-checker=core \
|
|
// RUN: -analyzer-config core.CallAndMessage:ArgPointeeInitializedness=true
|
|
//
|
|
// Just exercise the analyzer on code that has at one point caused issues
|
|
// (i.e., no assertions or crashes).
|
|
|
|
static void f1(const char *x, char *y) {
|
|
while (*x != 0) {
|
|
*y++ = *x++;
|
|
}
|
|
}
|
|
|
|
// This following case checks that we properly handle typedefs when getting
|
|
// the RvalueType of an ElementRegion.
|
|
typedef struct F12_struct {} F12_typedef;
|
|
typedef void* void_typedef;
|
|
void_typedef f2_helper(void);
|
|
static void f2(void *buf) {
|
|
F12_typedef* x;
|
|
x = f2_helper();
|
|
memcpy((&x[1]), (buf), 1); // expected-warning{{call to undeclared library function 'memcpy' with type 'void *(void *, const void *}} \
|
|
// expected-note{{include the header <string.h> or explicitly provide a declaration for 'memcpy'}}
|
|
}
|
|
|
|
// AllocaRegion is untyped. Void pointer isn't of much help either. Before
|
|
// realizing that the value is undefined, we need to somehow figure out
|
|
// what type of value do we expect.
|
|
void f3(void *dest) {
|
|
void *src = __builtin_alloca(5);
|
|
memcpy(dest, src, 1); // expected-warning{{2nd function call argument is a pointer to uninitialized value}}
|
|
}
|