I'm trying to remove unused options from the `Analyses.def` file, then merge the rest of the useful options into the `AnalyzerOptions.def`. Then make sure one can set these by an `-analyzer-config XXX=YYY` style flag. Then surface the `-analyzer-config` to the `clang` frontend; After all of this, we can pursue the tablegen approach described https://discourse.llvm.org/t/rfc-tablegen-clang-static-analyzer-engine-options-for-better-documentation/61488 In this patch, I'm proposing flag deprecations. We should support deprecated analyzer flags for exactly one release. In this case I'm planning to drop this flag in `clang-16`. In the clang frontend, now we won't pass this option to the cc1 frontend, rather emit a warning diagnostic reminding the users about this deprecated flag, which will be turned into error in clang-16. Unfortunately, I had to remove all the tests referring to this flag, causing a mass change. I've also added a test for checking this warning. I've seen that `scan-build` also uses this flag, but I think we should remove that part only after we turn this into a hard error. Reviewed By: martong Differential Revision: https://reviews.llvm.org/D126215
157 lines
4.1 KiB
C
157 lines
4.1 KiB
C
// This test checks that intersecting ranges does not cause 'system is over constrained' assertions in the case of eg: 32 bits unsigned integers getting their range from 64 bits signed integers.
|
|
// RUN: %clang_analyze_cc1 -triple x86_64-pc-linux-gnu -analyzer-checker=core,debug.ExprInspection -verify %s
|
|
|
|
void clang_analyzer_warnIfReached(void);
|
|
|
|
void f1(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1 == 0) // because of foo range, index is in range [0; UINT_MAX]
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f2(unsigned long foo)
|
|
{
|
|
int index = -1;
|
|
if (index < foo) index = foo; // index equals ULONG_MAX
|
|
if (index + 1 == 0)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // no-warning
|
|
}
|
|
|
|
void f3(unsigned long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1 == 0)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f4(long foo)
|
|
{
|
|
int index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1 == 0)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f5(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index == -1)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f6(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index == -1)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f7(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index - 1 == 0) // Was not reached prior fix.
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f8(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1L == 0L)
|
|
clang_analyzer_warnIfReached(); // no-warning
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f9(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index - 1L == 0L) // Was not reached prior fix.
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f10(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1 == 0L)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f11(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1UL == 0L)
|
|
clang_analyzer_warnIfReached(); // no-warning
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f12(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index - 1UL == 0L) // Was not reached prior fix.
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f13(int foo)
|
|
{
|
|
unsigned short index = -1;
|
|
if (index < foo) index = foo;
|
|
if (index + 1 == 0)
|
|
clang_analyzer_warnIfReached(); // no-warning
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f14(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
long bar = foo;
|
|
if (index + 1 == 0)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|
|
|
|
void f15(long foo)
|
|
{
|
|
unsigned index = -1;
|
|
if (index < foo) index = foo;
|
|
unsigned int tmp = index + 1;
|
|
if (tmp == 0)
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
else
|
|
clang_analyzer_warnIfReached(); // expected-warning{{REACHABLE}}
|
|
}
|