0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
110 lines
3.6 KiB
C++
110 lines
3.6 KiB
C++
// RUN: %clang_cc1 %s -fblocks -triple x86_64-apple-darwin -std=c++11 -emit-llvm -o - | FileCheck %s
|
|
|
|
template <class T> void takeItByValue(T);
|
|
void takeABlock(void (^)());
|
|
|
|
namespace test_int {
|
|
void test() {
|
|
const int x = 100;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
// CHECK: call void @_Z13takeItByValueIiEvT_(i32 noundef 100)
|
|
}
|
|
}
|
|
|
|
namespace test_int_ref {
|
|
void test() {
|
|
const int y = 200;
|
|
const int &x = y;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
|
|
// TODO: there's no good reason that this isn't foldable.
|
|
// CHECK: call void @_Z13takeItByValueIiEvT_(i32 noundef {{%.*}})
|
|
}
|
|
}
|
|
|
|
namespace test_float {
|
|
void test() {
|
|
const float x = 1;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
// CHECK: call void @_Z13takeItByValueIfEvT_(float noundef 1.0
|
|
}
|
|
}
|
|
|
|
namespace test_float_ref {
|
|
void test() {
|
|
const float y = 100;
|
|
const float &x = y;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
|
|
// TODO: there's no good reason that this isn't foldable.
|
|
// CHECK: call void @_Z13takeItByValueIfEvT_(float noundef {{%.*}})
|
|
}
|
|
}
|
|
|
|
namespace test_complex_int {
|
|
void test() {
|
|
constexpr _Complex int x = 500;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
// CHECK: store { i32, i32 } { i32 500, i32 0 },
|
|
|
|
// CHECK: [[COERCE:%.*]] = alloca { i32, i32 }
|
|
// CHECK: store i32 500,
|
|
// CHECK-NEXT: store i32 0,
|
|
// CHECK-NEXT: [[CVAL:%.*]] = load i64, ptr [[COERCE]]
|
|
// CHECK-NEXT: call void @_Z13takeItByValueICiEvT_(i64 noundef [[CVAL]])
|
|
}
|
|
}
|
|
|
|
namespace test_complex_int_ref {
|
|
void test() {
|
|
const _Complex int y = 100;
|
|
const _Complex int &x = y;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
// CHECK: call void @_Z13takeItByValueICiEvT_(i64
|
|
}
|
|
}
|
|
|
|
namespace test_complex_int_ref_mutable {
|
|
_Complex int y = 100;
|
|
void test() {
|
|
const _Complex int &x = y;
|
|
takeABlock(^{ takeItByValue(x); });
|
|
// CHECK: [[R:%.*]] = load i32, ptr @_ZN28test_complex_int_ref_mutable1yE
|
|
// CHECK-NEXT: [[I:%.*]] = load i32, ptr getelementptr inbounds ({ i32, i32 }, ptr @_ZN28test_complex_int_ref_mutable1yE, i32 0, i32 1)
|
|
// CHECK-NEXT: [[RSLOT:%.*]] = getelementptr inbounds { i32, i32 }, ptr [[CSLOT:%.*]], i32 0, i32 0
|
|
// CHECK-NEXT: [[ISLOT:%.*]] = getelementptr inbounds { i32, i32 }, ptr [[CSLOT]], i32 0, i32 1
|
|
// CHECK-NEXT: store i32 [[R]], ptr [[RSLOT]]
|
|
// CHECK-NEXT: store i32 [[I]], ptr [[ISLOT]]
|
|
// CHECK-NEXT: [[CVAL:%.*]] = load i64, ptr [[CSLOT]],
|
|
// CHECK-NEXT: call void @_Z13takeItByValueICiEvT_(i64 noundef [[CVAL]])
|
|
}
|
|
}
|
|
|
|
namespace test_block_in_lambda {
|
|
void takeBlock(void (^block)());
|
|
|
|
// The captured variable has to be non-POD so that we have a copy expression.
|
|
struct A {
|
|
void *p;
|
|
A(const A &);
|
|
~A();
|
|
void use() const;
|
|
};
|
|
|
|
void test(A a) {
|
|
auto lambda = [a]() {
|
|
takeBlock(^{ a.use(); });
|
|
};
|
|
lambda(); // make sure we emit the invocation function
|
|
}
|
|
// CHECK-LABEL: define internal void @"_ZZN20test_block_in_lambda4testENS_1AEENK3$_0clEv"(
|
|
// CHECK: [[BLOCK:%.*]] = alloca [[BLOCK_T:<{.*}>]], align 8
|
|
// CHECK: [[THIS:%.*]] = load ptr, ptr
|
|
// CHECK: [[BLOCK_CAPTURED:%.*]] = getelementptr inbounds [[BLOCK_T]], ptr [[BLOCK]], i32 0, i32 5
|
|
// CHECK-NEXT: [[T1:%.*]] = getelementptr inbounds [[LAMBDA_T:%.*]], ptr [[THIS]], i32 0, i32 0
|
|
// CHECK-NEXT: call void @_ZN20test_block_in_lambda1AC1ERKS0_(ptr {{[^,]*}} [[BLOCK_CAPTURED]], ptr noundef nonnull align {{[0-9]+}} dereferenceable({{[0-9]+}}) [[T1]])
|
|
// CHECK-NEXT: call void @_ZN20test_block_in_lambda9takeBlockEU13block_pointerFvvE(ptr noundef [[BLOCK]])
|
|
// CHECK-NEXT: call void @_ZN20test_block_in_lambda1AD1Ev(ptr {{[^,]*}} [[BLOCK_CAPTURED]])
|
|
// CHECK-NEXT: ret void
|
|
}
|