0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
111 lines
3.2 KiB
C++
111 lines
3.2 KiB
C++
// RUN: %clang_cc1 %s -std=c++11 -triple=x86_64-apple-darwin10 -fvisibility=hidden -ftype-visibility=default -emit-llvm -o %t
|
|
// RUN: FileCheck %s < %t
|
|
// RUN: FileCheck -check-prefix=CHECK-GLOBAL %s < %t
|
|
|
|
// The two visibility options above are how we translate
|
|
// -fvisibility-ms-compat in the driver.
|
|
|
|
#define HIDDEN __attribute__((visibility("hidden")))
|
|
#define PROTECTED __attribute__((visibility("protected")))
|
|
#define DEFAULT __attribute__((visibility("default")))
|
|
|
|
namespace std {
|
|
class type_info;
|
|
};
|
|
|
|
namespace test0 {
|
|
struct A {
|
|
static void foo();
|
|
static void bar();
|
|
};
|
|
|
|
void A::foo() { bar(); }
|
|
// CHECK-LABEL: define hidden void @_ZN5test01A3fooEv()
|
|
// CHECK: declare void @_ZN5test01A3barEv()
|
|
|
|
const std::type_info &ti = typeid(A);
|
|
// CHECK-GLOBAL: @_ZTSN5test01AE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZTIN5test01AE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZN5test02tiE = hidden constant
|
|
}
|
|
|
|
namespace test1 {
|
|
struct HIDDEN A {
|
|
static void foo();
|
|
static void bar();
|
|
};
|
|
|
|
void A::foo() { bar(); }
|
|
// CHECK-LABEL: define hidden void @_ZN5test11A3fooEv()
|
|
// CHECK: declare hidden void @_ZN5test11A3barEv()
|
|
|
|
const std::type_info &ti = typeid(A);
|
|
// CHECK-GLOBAL: @_ZTSN5test11AE = linkonce_odr hidden constant
|
|
// CHECK-GLOBAL: @_ZTIN5test11AE = linkonce_odr hidden constant
|
|
// CHECK-GLOBAL: @_ZN5test12tiE = hidden constant
|
|
}
|
|
|
|
namespace test2 {
|
|
struct DEFAULT A {
|
|
static void foo();
|
|
static void bar();
|
|
};
|
|
|
|
void A::foo() { bar(); }
|
|
// CHECK-LABEL: define{{.*}} void @_ZN5test21A3fooEv()
|
|
// CHECK: declare void @_ZN5test21A3barEv()
|
|
|
|
const std::type_info &ti = typeid(A);
|
|
// CHECK-GLOBAL: @_ZTSN5test21AE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZTIN5test21AE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZN5test22tiE = hidden constant
|
|
}
|
|
|
|
namespace test3 {
|
|
struct A { int x; };
|
|
template <class T> struct B {
|
|
static void foo() { bar(); }
|
|
static void bar();
|
|
};
|
|
|
|
template void B<A>::foo();
|
|
// CHECK-LABEL: define weak_odr hidden void @_ZN5test31BINS_1AEE3fooEv()
|
|
// CHECK: declare void @_ZN5test31BINS_1AEE3barEv()
|
|
|
|
const std::type_info &ti = typeid(B<A>);
|
|
// CHECK-GLOBAL: @_ZTSN5test31BINS_1AEEE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZTIN5test31BINS_1AEEE = linkonce_odr constant
|
|
}
|
|
|
|
namespace test4 {
|
|
struct A { int x; };
|
|
template <class T> struct DEFAULT B {
|
|
static void foo() { bar(); }
|
|
static void bar();
|
|
};
|
|
|
|
template void B<A>::foo();
|
|
// CHECK-LABEL: define weak_odr void @_ZN5test41BINS_1AEE3fooEv()
|
|
// CHECK: declare void @_ZN5test41BINS_1AEE3barEv()
|
|
|
|
const std::type_info &ti = typeid(B<A>);
|
|
// CHECK-GLOBAL: @_ZTSN5test41BINS_1AEEE = linkonce_odr constant
|
|
// CHECK-GLOBAL: @_ZTIN5test41BINS_1AEEE = linkonce_odr constant
|
|
}
|
|
|
|
namespace test5 {
|
|
struct A { int x; };
|
|
template <class T> struct HIDDEN B {
|
|
static void foo() { bar(); }
|
|
static void bar();
|
|
};
|
|
|
|
template void B<A>::foo();
|
|
// CHECK-LABEL: define weak_odr hidden void @_ZN5test51BINS_1AEE3fooEv()
|
|
// CHECK: declare hidden void @_ZN5test51BINS_1AEE3barEv()
|
|
|
|
const std::type_info &ti = typeid(B<A>);
|
|
// CHECK-GLOBAL: @_ZTSN5test51BINS_1AEEE = linkonce_odr hidden constant
|
|
// CHECK-GLOBAL: @_ZTIN5test51BINS_1AEEE = linkonce_odr hidden constant
|
|
}
|