16d1a6486c
Fixes #55106 In HLSL bit shifts are defined to shift by shift size % type size. This contains the following changes: HLSL codegen bit shifts will be emitted as x << (y & (sizeof(x) - 1) and bitshift masking leverages the OpenCL pipeline for this. Tests were also added to validate this behavior. Before this change the following was being emitted: ; Function Attrs: noinline nounwind optnone define noundef i32 @"?shl32@@YAHHH@Z"(i32 noundef %V, i32 noundef %S) #0 { entry: %S.addr = alloca i32, align 4 %V.addr = alloca i32, align 4 store i32 %S, ptr %S.addr, align 4 store i32 %V, ptr %V.addr, align 4 %0 = load i32, ptr %V.addr, align 4 %1 = load i32, ptr %S.addr, align 4 %shl = shl i32 %0, %1 ret i32 %shl } After this change: ; Function Attrs: noinline nounwind optnone define noundef i32 @"?shl32@@YAHHH@Z"(i32 noundef %V, i32 noundef %S) #0 { entry: %S.addr = alloca i32, align 4 %V.addr = alloca i32, align 4 store i32 %S, ptr %S.addr, align 4 store i32 %V, ptr %V.addr, align 4 %0 = load i32, ptr %V.addr, align 4 %1 = load i32, ptr %S.addr, align 4 %shl.mask = and i32 %1, 31 %shl = shl i32 %0, %shl.mask ret i32 %shl } --------- Co-authored-by: Cooper Partin <coopp@ntdev.microsoft.com>
36 lines
1.2 KiB
HLSL
36 lines
1.2 KiB
HLSL
// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \
|
|
// RUN: dxil-pc-shadermodel6.3-library %s \
|
|
// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s
|
|
|
|
int shl32(int V, int S) {
|
|
return V << S;
|
|
}
|
|
|
|
// CHECK: define noundef i32 @"?shl32{{[@$?.A-Za-z0-9_]+}}"(i32 noundef %V, i32 noundef %S) #0 {
|
|
// CHECK-DAG: %[[Masked:.*]] = and i32 %{{.*}}, 31
|
|
// CHECK-DAG: %{{.*}} = shl i32 %{{.*}}, %[[Masked]]
|
|
|
|
int shr32(int V, int S) {
|
|
return V >> S;
|
|
}
|
|
|
|
// CHECK: define noundef i32 @"?shr32{{[@$?.A-Za-z0-9_]+}}"(i32 noundef %V, i32 noundef %S) #0 {
|
|
// CHECK-DAG: %[[Masked:.*]] = and i32 %{{.*}}, 31
|
|
// CHECK-DAG: %{{.*}} = ashr i32 %{{.*}}, %[[Masked]]
|
|
|
|
int64_t shl64(int64_t V, int64_t S) {
|
|
return V << S;
|
|
}
|
|
|
|
// CHECK: define noundef i64 @"?shl64{{[@$?.A-Za-z0-9_]+}}"(i64 noundef %V, i64 noundef %S) #0 {
|
|
// CHECK-DAG: %[[Masked:.*]] = and i64 %{{.*}}, 63
|
|
// CHECK-DAG: %{{.*}} = shl i64 %{{.*}}, %[[Masked]]
|
|
|
|
int64_t shr64(int64_t V, int64_t S) {
|
|
return V >> S;
|
|
}
|
|
|
|
// CHECK: define noundef i64 @"?shr64{{[@$?.A-Za-z0-9_]+}}"(i64 noundef %V, i64 noundef %S) #0 {
|
|
// CHECK-DAG: %[[Masked:.*]] = and i64 %{{.*}}, 63
|
|
// CHECK-DAG: %{{.*}} = ashr i64 %{{.*}}, %[[Masked]]
|