0f1c1be196
We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
221 lines
5.9 KiB
Plaintext
221 lines
5.9 KiB
Plaintext
// RUN: %clang_cc1 %s -triple=x86_64-apple-darwin10 -std=c++11 -emit-llvm -debug-info-kind=limited -o - | FileCheck %s
|
|
|
|
class S {
|
|
public:
|
|
S& operator = (const S&);
|
|
S (const S&);
|
|
S ();
|
|
};
|
|
|
|
struct CGRect {
|
|
CGRect & operator = (const CGRect &);
|
|
};
|
|
|
|
@interface I {
|
|
S position;
|
|
CGRect bounds;
|
|
}
|
|
|
|
@property(assign, nonatomic) S position;
|
|
@property CGRect bounds;
|
|
@property CGRect frame;
|
|
- (void)setFrame:(CGRect)frameRect;
|
|
- (CGRect)frame;
|
|
- (void) initWithOwner;
|
|
- (CGRect)extent;
|
|
- (void)dealloc;
|
|
@end
|
|
|
|
@implementation I
|
|
@synthesize position;
|
|
@synthesize bounds;
|
|
@synthesize frame;
|
|
|
|
// CHECK: define internal void @"\01-[I setPosition:]"
|
|
// CHECK: call noundef nonnull align {{[0-9]+}} dereferenceable({{[0-9]+}}) ptr @_ZN1SaSERKS_
|
|
// CHECK-NEXT: ret void
|
|
|
|
// Don't attach debug locations to the prologue instructions. These were
|
|
// leaking over from the previous function emission by accident.
|
|
// CHECK: define internal void @"\01-[I setBounds:]"({{.*}} {
|
|
// CHECK-NOT: !dbg
|
|
// CHECK: call void @llvm.dbg.declare
|
|
- (void)setFrame:(CGRect)frameRect {}
|
|
- (CGRect)frame {return bounds;}
|
|
|
|
- (void)initWithOwner {
|
|
I* _labelLayer;
|
|
CGRect labelLayerFrame = self.bounds;
|
|
labelLayerFrame = self.bounds;
|
|
_labelLayer.frame = labelLayerFrame;
|
|
}
|
|
|
|
- (void)dealloc
|
|
{
|
|
CGRect cgrect = self.extent;
|
|
}
|
|
- (struct CGRect)extent {return bounds;}
|
|
|
|
@end
|
|
|
|
// CHECK-LABEL: define{{.*}} i32 @main
|
|
// CHECK: call void @_ZN1SC1ERKS_(ptr {{[^,]*}} [[AGGTMP:%[a-zA-Z0-9\.]+]], ptr noundef nonnull align {{[0-9]+}} dereferenceable({{[0-9]+}}) {{%[a-zA-Z0-9\.]+}})
|
|
// CHECK: call void @objc_msgSend(ptr noundef {{%[a-zA-Z0-9\.]+}}, ptr noundef {{%[a-zA-Z0-9\.]+}}, ptr noundef [[AGGTMP]])
|
|
// CHECK-NEXT: ret i32 0
|
|
int main() {
|
|
I *i;
|
|
S s1;
|
|
i.position = s1;
|
|
return 0;
|
|
}
|
|
|
|
// CHECK-LABEL: define{{.*}} void @_Z1fP1A
|
|
// CHECK: call void @_ZN1XC1Ev(ptr {{[^,]*}} [[LVTEMP:%[a-zA-Z0-9\.]+]])
|
|
// CHECK: call void @_ZN1XC1ERKS_(ptr {{[^,]*}} [[AGGTMP:%[a-zA-Z0-9\.]+]], ptr noundef nonnull align {{[0-9]+}} dereferenceable({{[0-9]+}}) [[LVTEMP]])
|
|
// CHECK: call void @objc_msgSend({{.*}} ptr noundef [[AGGTMP]])
|
|
struct X {
|
|
X();
|
|
X(const X&);
|
|
~X();
|
|
};
|
|
|
|
@interface A {
|
|
X xval;
|
|
}
|
|
- (X)x;
|
|
- (void)setX:(X)x;
|
|
@end
|
|
|
|
void f(A* a) {
|
|
a.x = X();
|
|
}
|
|
|
|
// Ensure that pseudo-objecet expressions that require the RHS to be
|
|
// rewritten don't result in crashes or redundant emission of code.
|
|
struct B0 { long long x; };
|
|
struct B1 { long long x; }; B1 operator+(B1, B1);
|
|
struct B2 { B1 x; };
|
|
struct B3 { B3(); B1 x; operator B1(); };
|
|
@interface B
|
|
@property B0 b0;
|
|
@property B1 b1;
|
|
@property B2 b2;
|
|
@property B3 b3;
|
|
@end
|
|
|
|
int b_makeInt();
|
|
|
|
// Note that there's a promotion from int to long long, so
|
|
// the syntactic form of the RHS will be bogus.
|
|
void testB0(B *b) {
|
|
b.b0 = { b_makeInt() };
|
|
}
|
|
void testB1(B *b) {
|
|
b.b1 += { b_makeInt() };
|
|
}
|
|
// CHECK: define{{.*}} void @_Z6testB0P1B(ptr
|
|
// CHECK: [[BVAR:%.*]] = alloca ptr, align 8
|
|
// CHECK: [[TEMP:%.*]] = alloca [[B0:%.*]], align 8
|
|
// CHECK: [[X:%.*]] = getelementptr inbounds [[B0]], ptr [[TEMP]], i32 0, i32 0
|
|
// CHECK-NEXT: [[T0:%.*]] = call noundef i32 @_Z9b_makeIntv()
|
|
// CHECK-NEXT: [[T1:%.*]] = sext i32 [[T0]] to i64
|
|
// CHECK-NEXT: store i64 [[T1]], ptr [[X]], align 8
|
|
// CHECK: load ptr, ptr [[BVAR]]
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: ret void
|
|
|
|
// CHECK: define{{.*}} void @_Z6testB1P1B(ptr
|
|
// CHECK: [[BVAR:%.*]] = alloca ptr, align 8
|
|
// CHECK: load ptr, ptr [[BVAR]]
|
|
// CHECK-NOT: call
|
|
// CHECK: [[T0:%.*]] = call i64 @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: store i64 [[T0]],
|
|
// CHECK-NOT: call
|
|
// CHECK: [[T0:%.*]] = call noundef i32 @_Z9b_makeIntv()
|
|
// CHECK-NEXT: [[T1:%.*]] = sext i32 [[T0]] to i64
|
|
// CHECK-NEXT: store i64 [[T1]], ptr {{.*}}, align 8
|
|
// CHECK-NOT: call
|
|
// CHECK: [[T0:%.*]] = call i64 @_Zpl2B1S_
|
|
// CHECK-NOT: call
|
|
// CHECK: store i64 [[T0]],
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: ret void
|
|
|
|
// Another example of a conversion that needs to be applied
|
|
// in the semantic form.
|
|
void testB2(B *b) {
|
|
b.b2 = { B3() };
|
|
}
|
|
|
|
// CHECK: define{{.*}} void @_Z6testB2P1B(ptr
|
|
// CHECK: [[BVAR:%.*]] = alloca ptr, align 8
|
|
// CHECK: call void @llvm.dbg.declare(
|
|
// CHECK: call void @_ZN2B3C1Ev(
|
|
// CHECK-NEXT: [[T0:%.*]] = call i64 @_ZN2B3cv2B1Ev(
|
|
// CHECK-NOT: call
|
|
// CHECK: store i64 [[T0]],
|
|
// CHECK: load ptr, ptr [[BVAR]]
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: ret void
|
|
|
|
// A similar test to B, but using overloaded function references.
|
|
struct C1 {
|
|
int x;
|
|
friend C1 operator+(C1, void(&)());
|
|
};
|
|
@interface C
|
|
@property void (*c0)();
|
|
@property C1 c1;
|
|
@end
|
|
|
|
void c_helper();
|
|
void c_helper(int);
|
|
|
|
void testC0(C *c) {
|
|
c.c0 = c_helper;
|
|
c.c0 = &c_helper;
|
|
}
|
|
// CHECK: define{{.*}} void @_Z6testC0P1C(ptr
|
|
// CHECK: [[CVAR:%.*]] = alloca ptr, align 8
|
|
// CHECK: load ptr, ptr [[CVAR]]
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend({{.*}} @_Z8c_helperv
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend({{.*}} @_Z8c_helperv
|
|
// CHECK-NOT: call
|
|
// CHECK: ret void
|
|
|
|
void testC1(C *c) {
|
|
c.c1 += c_helper;
|
|
}
|
|
// CHECK: define{{.*}} void @_Z6testC1P1C(ptr
|
|
// CHECK: [[CVAR:%.*]] = alloca ptr, align 8
|
|
// CHECK: load ptr, ptr [[CVAR]]
|
|
// CHECK-NOT: call
|
|
// CHECK: [[T0:%.*]] = call i32 @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: store i32 [[T0]],
|
|
// CHECK-NOT: call
|
|
// CHECK: [[T0:%.*]] = call i32 @_Zpl2C1RFvvE({{.*}} @_Z8c_helperv
|
|
// CHECK-NOT: call
|
|
// CHECK: store i32 [[T0]],
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @llvm.memcpy
|
|
// CHECK-NOT: call
|
|
// CHECK: call void @objc_msgSend
|
|
// CHECK-NOT: call
|
|
// CHECK: ret void
|