Files
clang-p2996/clang/test/Driver/arm-implicit-it.s
Fangrui Song f39c399d9d [Driver] -###: exit with code 1 if hasErrorOccurred
The exit code for -### is inconsistent. Unrecognized options lead to
exit code 1, as expected. However, most others errors (including invalid
option value) lead to exit code 0, differing from GCC and most utilities.

This is a longstanding quirk of -###, and we didn't fix it because many
driver tests need adjustment.

Change -### to be similar to -fdriver-only -v and exit with code 1.

This requires fixing many driver tests, but the end result gives us
stronger tests.

* Existing `RUN: %clang -### ...` tests usually don't use `CHECK-NOT: error:` or `--implicit-check-not=error:`.
  If a change introduces an error, such a change usually cannot be detected.
* Many folks contributing new tests don't know `-fdriver-only -v`.
  To test no driver error/warning for new tests, they can use the familiar `-### -Werror`
  instead of `-fdriver-only -v -Werror`.

An incomplete list of prerequisite test improvement:

* 2f79bb1046: add -nogpulib to some AMDGPU tests
* 9155e517e6: add --cuda-path= (test w/ and w/o /usr/local/cuda)
* 80765ede5b: -mcpu=native may return either 0 or 1, depending on whether `--target=` specifies a native target
* abae53f43f: fix -fuse-ld=lld misuses (test w/o and w/o /usr/local/bin/ld.lld)
* ab68df505e: add -resource-dir= and -fvisibility=hidden
 to some -fsanitize=cfi tests
* d5ca1602f6: --rtlib=platform without --unwindlib= may fail if CLANG_DEFAULT_UNWINDLIB=unwindlib

Reviewed By: jhuber6, yaxunl, dblaikie

Differential Revision: https://reviews.llvm.org/D156363
2023-08-01 13:23:51 -07:00

25 lines
1.0 KiB
ArmAsm

// RUN: %clang -target armv7--none-eabi -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-DEFAULT
// RUN: %clang -target armv7--none-eabi -mimplicit-it=arm -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-ARM
// RUN: %clang -target armv7--none-eabi -mimplicit-it=thumb -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-THUMB
// RUN: %clang -target armv7--none-eabi -mimplicit-it=never -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-NEVER
// RUN: %clang -target armv7--none-eabi -mimplicit-it=always -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-ALWAYS
// RUN: not %clang --target=armv7--none-eabi -mimplicit-it=thisisnotavalidoption -### %s 2>&1 \
// RUN: | FileCheck %s -check-prefix CHECK-INVALID
// CHECK-DEFAULT-NOT: "-arm-implicit-it
// CHECK-ARM: "-arm-implicit-it=arm"
// CHECK-THUMB: "-arm-implicit-it=thumb"
// CHECK-NEVER: "-arm-implicit-it=never"
// CHECK-ALWAYS: "-arm-implicit-it=always"
// CHECK-INVALID: error: unsupported argument 'thisisnotavalidoption' to option '-mimplicit-it='