Files
clang-p2996/clang/test/FixIt/fixit.cpp
Aaron Ballman 0f1c1be196 [clang] Remove rdar links; NFC
We have a new policy in place making links to private resources
something we try to avoid in source and test files. Normally, we'd
organically switch to the new policy rather than make a sweeping change
across a project. However, Clang is in a somewhat special circumstance
currently: recently, I've had several new contributors run into rdar
links around test code which their patch was changing the behavior of.
This turns out to be a surprisingly bad experience, especially for
newer folks, for a handful of reasons: not understanding what the link
is and feeling intimidated by it, wondering whether their changes are
actually breaking something important to a downstream in some way,
having to hunt down strangers not involved with the patch to impose on
them for help, accidental pressure from asking for potentially private
IP to be made public, etc. Because folks run into these links entirely
by chance (through fixing bugs or working on new features), there's not
really a set of problematic links to focus on -- all of the links have
basically the same potential for causing these problems. As a result,
this is an omnibus patch to remove all such links.

This was not a mechanical change; it was done by manually searching for
rdar, radar, radr, and other variants to find all the various
problematic links. From there, I tried to retain or reword the
surrounding comments so that we would lose as little context as
possible. However, because most links were just a plain link with no
supporting context, the majority of the changes are simple removals.

Differential Review: https://reviews.llvm.org/D158071
2023-08-28 12:13:42 -04:00

449 lines
17 KiB
C++

// RUN: %clang_cc1 -pedantic -Wall -Wno-unused-but-set-variable -Wno-comment -verify -fcxx-exceptions -x c++ -std=c++98 -Wno-c++14-extensions %s
// RUN: cp %s %t-98
// RUN: not %clang_cc1 -pedantic -Wall -Wno-unused-but-set-variable -Wno-comment -fcxx-exceptions -fixit -x c++ -std=c++98 -Wno-c++14-extensions %t-98
// RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Wno-unused-but-set-variable -Werror -Wno-comment -fcxx-exceptions -x c++ -std=c++98 -Wno-c++14-extensions %t-98
// RUN: not %clang_cc1 -fsyntax-only -pedantic -fdiagnostics-parseable-fixits -x c++ -std=c++11 -Wno-c++14-extensions %s 2>&1 | FileCheck %s
// RUN: %clang_cc1 -pedantic -Wall -Wno-unused-but-set-variable -Wno-comment -verify -fcxx-exceptions -x c++ -std=c++11 -Wno-c++14-extensions %s
// RUN: cp %s %t-11
// RUN: not %clang_cc1 -pedantic -Wall -Wno-unused-but-set-variable -Wno-comment -fcxx-exceptions -fixit -x c++ -std=c++11 -Wno-c++14-extensions %t-11
// RUN: %clang_cc1 -fsyntax-only -pedantic -Wall -Wno-unused-but-set-variable -Werror -Wno-comment -fcxx-exceptions -x c++ -std=c++11 -Wno-c++14-extensions %t-11
/* This is a test of the various code modification hints that are
provided as part of warning or extension diagnostics. All of the
warnings will be fixed by -fixit, and the resulting file should
compile cleanly with -Werror -pedantic. */
struct C1 {
virtual void f();
static void g();
};
struct C2 : virtual public virtual C1 { }; // expected-error{{duplicate}}
virtual void C1::f() { } // expected-error{{'virtual' can only be specified inside the class definition}}
static void C1::g() { } // expected-error{{'static' can only be specified inside the class definition}}
template<int Value> struct CT { template<typename> struct Inner; }; // expected-note{{previous use is here}}
// FIXME: In C++11 this gets 'expected unqualified-id' which fixit can't fix.
// Probably parses as `CT<10> > 2 > ct;` rather than `CT<(10 >> 2)> ct;`.
#if __cplusplus < 201103L
CT<10 >> 2> ct; // expected-warning{{require parentheses}}
#endif
class C3 {
public:
C3(C3, int i = 0); // expected-error{{copy constructor must pass its first argument by reference}}
};
struct CT<0> { }; // expected-error{{'template<>'}}
template<> union CT<1> { }; // expected-error{{tag type}}
struct CT<2>::Inner<int> { }; // expected-error 2{{'template<>'}}
// Access declarations
class A {
protected:
int foo();
};
class B : public A {
#if __cplusplus >= 201103L
A::foo; // expected-error{{ISO C++11 does not allow access declarations}}
#else
A::foo; // expected-warning{{access declarations are deprecated}}
#endif
};
void f() throw(); // expected-note{{previous}}
void f(); // expected-error{{missing exception specification}}
namespace rdar7853795 {
struct A {
bool getNumComponents() const; // expected-note{{declared here}}
void dump() const {
getNumComponenets(); // expected-error{{use of undeclared identifier 'getNumComponenets'; did you mean 'getNumComponents'?}}
}
};
}
namespace rdar7796492 {
struct A { int x, y; A(); };
A::A()
: x(1) y(2) { // expected-error{{missing ',' between base or member initializers}}
}
}
// extra qualification on member
class C {
int C::foo(); // expected-error {{extra qualification}}
};
namespace rdar8488464 {
int x = 0;
int x1 &= 0; // expected-error {{invalid '&=' at end of declaration; did you mean '='?}}
int x2 *= 0; // expected-error {{invalid '*=' at end of declaration; did you mean '='?}}
int x3 += 0; // expected-error {{invalid '+=' at end of declaration; did you mean '='?}}
int x4 -= 0; // expected-error {{invalid '-=' at end of declaration; did you mean '='?}}
int x5 != 0; // expected-error {{invalid '!=' at end of declaration; did you mean '='?}}
int x6 /= 0; // expected-error {{invalid '/=' at end of declaration; did you mean '='?}}
int x7 %= 0; // expected-error {{invalid '%=' at end of declaration; did you mean '='?}}
int x8 <= 0; // expected-error {{invalid '<=' at end of declaration; did you mean '='?}}
int x9 <<= 0; // expected-error {{invalid '<<=' at end of declaration; did you mean '='?}}
int x10 >= 0; // expected-error {{invalid '>=' at end of declaration; did you mean '='?}}
int x11 >>= 0; // expected-error {{invalid '>>=' at end of declaration; did you mean '='?}}
int x12 ^= 0; // expected-error {{invalid '^=' at end of declaration; did you mean '='?}}
int x13 |= 0; // expected-error {{invalid '|=' at end of declaration; did you mean '='?}}
int x14 == 0; // expected-error {{invalid '==' at end of declaration; did you mean '='?}}
void f() {
int x = 0;
(void)x;
int x1 &= 0; // expected-error {{invalid '&=' at end of declaration; did you mean '='?}}
(void)x1;
int x2 *= 0; // expected-error {{invalid '*=' at end of declaration; did you mean '='?}}
(void)x2;
int x3 += 0; // expected-error {{invalid '+=' at end of declaration; did you mean '='?}}
(void)x3;
int x4 -= 0; // expected-error {{invalid '-=' at end of declaration; did you mean '='?}}
(void)x4;
int x5 != 0; // expected-error {{invalid '!=' at end of declaration; did you mean '='?}}
(void)x5;
int x6 /= 0; // expected-error {{invalid '/=' at end of declaration; did you mean '='?}}
(void)x6;
int x7 %= 0; // expected-error {{invalid '%=' at end of declaration; did you mean '='?}}
(void)x7;
int x8 <= 0; // expected-error {{invalid '<=' at end of declaration; did you mean '='?}}
(void)x8;
int x9 <<= 0; // expected-error {{invalid '<<=' at end of declaration; did you mean '='?}}
(void)x9;
int x10 >= 0; // expected-error {{invalid '>=' at end of declaration; did you mean '='?}}
(void)x10;
int x11 >>= 0; // expected-error {{invalid '>>=' at end of declaration; did you mean '='?}}
(void)x11;
int x12 ^= 0; // expected-error {{invalid '^=' at end of declaration; did you mean '='?}}
(void)x12;
int x13 |= 0; // expected-error {{invalid '|=' at end of declaration; did you mean '='?}}
(void)x13;
int x14 == 0; // expected-error {{invalid '==' at end of declaration; did you mean '='?}}
(void)x14;
if (int x = 0) { (void)x; }
if (int x1 &= 0) { (void)x1; } // expected-error {{invalid '&=' at end of declaration; did you mean '='?}}
if (int x2 *= 0) { (void)x2; } // expected-error {{invalid '*=' at end of declaration; did you mean '='?}}
if (int x3 += 0) { (void)x3; } // expected-error {{invalid '+=' at end of declaration; did you mean '='?}}
if (int x4 -= 0) { (void)x4; } // expected-error {{invalid '-=' at end of declaration; did you mean '='?}}
if (int x5 != 0) { (void)x5; } // expected-error {{invalid '!=' at end of declaration; did you mean '='?}}
if (int x6 /= 0) { (void)x6; } // expected-error {{invalid '/=' at end of declaration; did you mean '='?}}
if (int x7 %= 0) { (void)x7; } // expected-error {{invalid '%=' at end of declaration; did you mean '='?}}
if (int x8 <= 0) { (void)x8; } // expected-error {{invalid '<=' at end of declaration; did you mean '='?}}
if (int x9 <<= 0) { (void)x9; } // expected-error {{invalid '<<=' at end of declaration; did you mean '='?}}
if (int x10 >= 0) { (void)x10; } // expected-error {{invalid '>=' at end of declaration; did you mean '='?}}
if (int x11 >>= 0) { (void)x11; } // expected-error {{invalid '>>=' at end of declaration; did you mean '='?}}
if (int x12 ^= 0) { (void)x12; } // expected-error {{invalid '^=' at end of declaration; did you mean '='?}}
if (int x13 |= 0) { (void)x13; } // expected-error {{invalid '|=' at end of declaration; did you mean '='?}}
if (int x14 == 0) { (void)x14; } // expected-error {{invalid '==' at end of declaration; did you mean '='?}}
}
}
template <class A>
class F1 {
public:
template <int B>
class Iterator {
};
};
template<class T>
class F2 {
typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-error {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
};
template <class T>
void f(){
typename F1<T>:: /*template*/ Iterator<0> Mypos; // expected-error {{use 'template' keyword to treat 'Iterator' as a dependent template name}}
}
// Tests for &/* fixits
class AD {};
class BD: public AD {};
void test (BD &br) {
AD* aPtr;
BD b;
aPtr = b; // expected-error {{assigning to 'AD *' from incompatible type 'BD'; take the address with &}}
aPtr = br; // expected-error {{assigning to 'AD *' from incompatible type 'BD'; take the address with &}}
}
void foo1() const {} // expected-error {{non-member function cannot have 'const' qualifier}}
void foo2() volatile {} // expected-error {{non-member function cannot have 'volatile' qualifier}}
void foo3() const volatile {} // expected-error {{non-member function cannot have 'const volatile' qualifier}}
struct S { void f(int, char); };
int itsAComma,
itsAComma2 = 0,
oopsAComma(42), // expected-error {{expected ';' at end of declaration}}
AD oopsMoreCommas() {
static int n = 0, // expected-error {{expected ';' at end of declaration}}
static char c,
&d = c, // expected-error {{expected ';' at end of declaration}}
S s, // expected-error {{expected ';' at end of declaration}}
s.f(n, d);
AD ad, // expected-error {{expected ';' at end of declaration}}
return ad;
}
struct MoreAccidentalCommas {
int a : 5,
b : 7,
: 4, // expected-error {{expected ';' at end of declaration}}
char c, // expected-error {{expected ';' at end of declaration}}
double d, // expected-error {{expected ';' at end of declaration}}
MoreAccidentalCommas *next, // expected-error {{expected ';' at end of declaration}}
public:
int k, // expected-error {{expected ';' at end of declaration}}
friend void f(MoreAccidentalCommas) {}
int k2, // expected-error {{expected ';' at end of declaration}}
virtual void g(), // expected-error {{expected ';' at end of declaration}}
};
template<class T> struct Mystery;
template<class T> typedef Mystery<T>::type getMysteriousThing() { // \
expected-error {{function definition declared 'typedef'}} \
expected-warning {{implicit 'typename' is a C++20 extension}}
return Mystery<T>::get();
}
template<template<typename> Foo, // expected-error {{template template parameter requires 'class' after the parameter list}}
template<typename> typename Bar, // expected-warning {{template template parameter using 'typename' is a C++17 extension}}
template<typename> struct Baz> // expected-error {{template template parameter requires 'class' after the parameter list}}
void func();
namespace ShadowedTagType {
class Foo {
public:
enum Bar { X, Y };
void SetBar(Bar bar);
Bar Bar(); // expected-note 2 {{enum 'Bar' is hidden by a non-type declaration of 'Bar' here}}
private:
Bar bar_; // expected-error {{must use 'enum' tag to refer to type 'Bar' in this scope}}
};
void Foo::SetBar(Bar bar) { bar_ = bar; } // expected-error {{must use 'enum' tag to refer to type 'Bar' in this scope}}
}
#define NULL __null
char c = NULL; // expected-warning {{implicit conversion of NULL constant to 'char'}}
double dbl = NULL; // expected-warning {{implicit conversion of NULL constant to 'double'}}
namespace arrow_suggest {
template <typename T>
class wrapped_ptr {
public:
wrapped_ptr(T* ptr) : ptr_(ptr) {}
T* operator->() { return ptr_; }
private:
T *ptr_;
};
class Worker {
public:
void DoSomething();
};
void test() {
wrapped_ptr<Worker> worker(new Worker);
worker.DoSomething(); // expected-error {{no member named 'DoSomething' in 'arrow_suggest::wrapped_ptr<arrow_suggest::Worker>'; did you mean to use '->' instead of '.'?}}
}
} // namespace arrow_suggest
// Make sure fixing namespace-qualified identifiers functions properly with
// namespace-aware typo correction/
namespace redecl_typo {
namespace Foo {
void BeEvil(); // expected-note {{'BeEvil' declared here}}
}
namespace Bar {
namespace Foo {
bool isGood(); // expected-note {{'Bar::Foo::isGood' declared here}}
void beEvil();
}
}
bool Foo::isGood() { // expected-error {{out-of-line definition of 'isGood' does not match any declaration in namespace 'redecl_typo::Foo'; did you mean 'Bar::Foo::isGood'?}}
return true;
}
void Foo::beEvil() {} // expected-error {{out-of-line definition of 'beEvil' does not match any declaration in namespace 'redecl_typo::Foo'; did you mean 'BeEvil'?}}
}
// Test behavior when a template-id is ended by a token which starts with '>'.
namespace greatergreater {
template<typename T> struct S { S(); S(T); };
void f(S<int>=0); // expected-error {{a space is required between a right angle bracket and an equals sign (use '> =')}}
// FIXME: The fix-its here overlap so -fixit mode can't apply the second one.
//void f(S<S<int>>=S<int>());
struct Shr {
template<typename T> Shr(T);
template<typename T> void operator >>=(T);
};
template<template<typename>> struct TemplateTemplateParam; // expected-error {{requires 'class'}}
template <typename T> int t = 0;
void g() {
int p = 0;
(void)(t<int>==p); // expected-error {{use '> ='}}
(void)(t<int>>=p); // expected-error {{use '> >'}}
#if __cplusplus < 201103L
(void)(t<S<int>>>=p); // expected-error {{use '> >'}}
(Shr)t<S<int>>>>=p; // expected-error {{use '> >'}}
#endif
// FIXME: We correct this to 't<int> > >= p;' not 't<int> >>= p;'
//(Shr)t<int>>>=p;
// FIXME: The fix-its here overlap.
//(void)(t<S<int>>==p);
}
}
class foo {
static void test() {
(void)&i; // expected-error{{must explicitly qualify name of member function when taking its address}}
}
int i();
};
namespace dtor_fixit {
struct foo {
~bar() { } // expected-error {{undeclared identifier 'bar' in destructor name}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:6-[[@LINE-1]]:9}:"foo"
};
class bar { // expected-note {{found}}
~bar();
};
~bar::bar() {} // expected-error {{'~' in destructor name should be after nested name specifier}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:4}:""
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:9-[[@LINE-2]]:9}:"~"
namespace N {
typedef foo T;
template <typename T> struct X {};
}
void f(foo *p, N::X<int> *x) {
p->~undeclared(); // expected-error {{undeclared}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:9-[[@LINE-1]]:19}:"foo"
p->~bar(); // expected-error {{does not match}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:9-[[@LINE-1]]:12}:"foo"
// FIXME: This is a bad fixit; it'd be better to suggest replacing 'foo'
// with 'T'.
p->N::T::~foo(); // expected-warning {{requires the name after '::~' to be found in the same scope as the name before}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:12-[[@LINE-1]]:12}:"::foo"
typedef foo baz; // expected-note {{found}}
p->dtor_fixit::foo::~baz(); // expected-warning {{only found in lexical scope}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:8-[[@LINE-1]]:25}:""
// FIXME: This is a bad fixit; it'd be better to suggest adding the
// template arguments.
x->N::X<int>::~X(); // expected-warning {{same scope}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:17-[[@LINE-1]]:17}:"::X"
}
}
namespace PR5066 {
template<typename T> struct X {};
X<int *p> x; // expected-error {{type-id cannot have a name}}
}
namespace PR5898 {
class A {
public:
const char *str();
};
const char* foo(A &x)
{
return x.str.(); // expected-error {{unexpected '.' in function call; perhaps remove the '.'?}}
}
bool bar(A x, const char *y) {
return foo->(x) == y; // expected-error {{unexpected '->' in function call; perhaps remove the '->'?}}
}
}
namespace PR15045 {
class Cl0 {
public:
int a;
};
int f() {
Cl0 c;
return c->a; // expected-error {{member reference type 'Cl0' is not a pointer; did you mean to use '.'?}}
}
}
namespace curly_after_base_clause {
struct A { void f(); };
struct B : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
int i;
};
struct C : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
using A::f;
};
struct D : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
protected:
};
struct E : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
template<typename T> struct inner { };
};
struct F : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
F() { }
};
#if __cplusplus >= 201103L
struct G : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
constexpr G(int) { }
};
struct H : A // expected-error{{expected '{' after base class list}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:13-[[@LINE-1]]:13}:" {"
static_assert(true, "");
};
#endif
}
struct conversion_operator {
conversion_operator::* const operator int(); // expected-error {{put the complete type after 'operator'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:3-[[@LINE-1]]:32}:""
// CHECK: fix-it:"{{.*}}":{[[@LINE-2]]:44-[[@LINE-2]]:44}:" conversion_operator::* const"
};
struct const_zero_init {
int a;
};
const const_zero_init czi; // expected-error {{default initialization of an object of const type 'const const_zero_init'}}
// CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:26-[[@LINE-1]]:26}:"{}"
int use_czi = czi.a;
namespace dotPointerDestructor {
struct Bar {
~Bar();
};
void bar(Bar *o) {
o.~Bar(); // expected-error {{member reference type 'Bar *' is a pointer; did you mean to use '->'}}
} // CHECK: fix-it:"{{.*}}":{[[@LINE-1]]:4-[[@LINE-1]]:5}:"->"
}