853b13342a
When CMake on Windows is told to generate the build into a directory
whose real path has a different drive letter (e.g. due to a symlink),
the "clang/test/Lexer/case-insensitive-include-absolute.c" test fails.
That happens because because `trySimplifyPath()` in `PPDirectives.cpp`
finds out there's more than a case difference between the `#include`
path (containing `%/t`) and the real path, which prevents the diagnostic
to fire.
I thought this is only an issue on Windows due to the fact that LIT does
not drag the path to the build directory through `os.path.realpath()`
like it does on other systems (see `abs_path_preserve_drive()` in
"llvm/utils/lit/lit/util.py"). However, even after only using
`os.path.abspath()` on a Unix system, build generated into a symlinked
directory tests correctly. I assume there must be something else at
play, but I don't have the time to dig deeper.
The fix is is fairly straightforward: use the real path in the
`#include` (with `%{/t:real}`), which removes the non-case difference
and unblocks the diagnostic.
14 lines
577 B
C
14 lines
577 B
C
// REQUIRES: case-insensitive-filesystem
|
|
|
|
// RUN: rm -rf %t && split-file %s %t
|
|
// RUN: sed "s|DIR|%{/t:real}|g" %t/tu.c.in > %t/tu.c
|
|
// RUN: %clang_cc1 -fsyntax-only %t/tu.c 2>&1 | FileCheck %s -DDIR=%{/t:real}
|
|
|
|
//--- header.h
|
|
//--- tu.c.in
|
|
#import "DIR/Header.h"
|
|
// CHECK: tu.c:1:9: warning: non-portable path to file '"[[DIR]]/header.h"'; specified path differs in case from file name on disk [-Wnonportable-include-path]
|
|
// CHECK-NEXT: 1 | #import "[[DIR]]/Header.h"
|
|
// CHECK-NEXT: | ^~~~~~~~~~~~~~~~~~
|
|
// CHECK-NEXT: | "[[DIR]]/header.h"
|