We have a new policy in place making links to private resources something we try to avoid in source and test files. Normally, we'd organically switch to the new policy rather than make a sweeping change across a project. However, Clang is in a somewhat special circumstance currently: recently, I've had several new contributors run into rdar links around test code which their patch was changing the behavior of. This turns out to be a surprisingly bad experience, especially for newer folks, for a handful of reasons: not understanding what the link is and feeling intimidated by it, wondering whether their changes are actually breaking something important to a downstream in some way, having to hunt down strangers not involved with the patch to impose on them for help, accidental pressure from asking for potentially private IP to be made public, etc. Because folks run into these links entirely by chance (through fixing bugs or working on new features), there's not really a set of problematic links to focus on -- all of the links have basically the same potential for causing these problems. As a result, this is an omnibus patch to remove all such links. This was not a mechanical change; it was done by manually searching for rdar, radar, radr, and other variants to find all the various problematic links. From there, I tried to retain or reword the surrounding comments so that we would lose as little context as possible. However, because most links were just a plain link with no supporting context, the majority of the changes are simple removals. Differential Review: https://reviews.llvm.org/D158071
148 lines
5.4 KiB
C
148 lines
5.4 KiB
C
// RUN: %clang_cc1 -Wno-int-to-pointer-cast -Wno-pointer-to-int-cast -pedantic -fsyntax-only %s -verify -fblocks
|
|
|
|
extern int printf(const char *, ...);
|
|
|
|
typedef void (^CL)(void);
|
|
|
|
CL foo(void) {
|
|
short y;
|
|
short (^add1)(void) = ^{ return y+1; }; // expected-error {{incompatible block pointer types initializing 'short (^)(void)' with an expression of type 'int (^)(void)'}}
|
|
|
|
CL X = ^{
|
|
if (2)
|
|
return;
|
|
return 1; // expected-error {{return type 'int' must match previous return type 'void' when block literal has unspecified explicit return type}}
|
|
};
|
|
|
|
int (^Y) (void) = ^{
|
|
if (3)
|
|
return 1;
|
|
else
|
|
return; // expected-error {{return type 'void' must match previous return type 'int' when block literal has unspecified explicit return type}}
|
|
};
|
|
|
|
char *(^Z)(void) = ^{
|
|
if (3)
|
|
return "";
|
|
else
|
|
return (char*)0;
|
|
};
|
|
|
|
double (^A)(void) = ^ { // expected-error {{incompatible block pointer types initializing 'double (^)(void)' with an expression of type 'float (^)(void)'}}
|
|
if (1)
|
|
return (float)1.0;
|
|
else
|
|
if (2)
|
|
return (double)2.0; // expected-error {{return type 'double' must match previous return type 'float' when block literal has unspecified explicit return type}}
|
|
return 1; // expected-error {{return type 'int' must match previous return type 'float' when block literal has unspecified explicit return type}}
|
|
};
|
|
char *(^B)(void) = ^{
|
|
if (3)
|
|
return "";
|
|
else
|
|
return 2; // expected-error {{return type 'int' must match previous return type 'char *' when block literal has unspecified explicit return type}}
|
|
};
|
|
|
|
return ^{ return 1; }; // expected-error {{incompatible block pointer types returning 'int (^)(void)' from a function with result type 'CL' (aka 'void (^)(void)')}}
|
|
}
|
|
|
|
typedef int (^CL2)(void);
|
|
|
|
CL2 foo2(void) {
|
|
return ^{ return 1; };
|
|
}
|
|
|
|
typedef unsigned int * uintptr_t;
|
|
typedef char Boolean;
|
|
typedef int CFBasicHash;
|
|
|
|
#define INVOKE_CALLBACK2(P, A, B) (P)(A, B)
|
|
|
|
typedef struct {
|
|
Boolean (^isEqual)(const CFBasicHash *, uintptr_t stack_value_or_key1, uintptr_t stack_value_or_key2, Boolean is_key);
|
|
} CFBasicHashCallbacks;
|
|
|
|
int foo3(void) {
|
|
CFBasicHashCallbacks cb;
|
|
|
|
Boolean (*value_equal)(uintptr_t, uintptr_t) = 0;
|
|
|
|
cb.isEqual = ^(const CFBasicHash *table, uintptr_t stack_value_or_key1, uintptr_t stack_value_or_key2, Boolean is_key) {
|
|
return (Boolean)(uintptr_t)INVOKE_CALLBACK2(value_equal, (uintptr_t)stack_value_or_key1, (uintptr_t)stack_value_or_key2);
|
|
};
|
|
}
|
|
|
|
static int funk(char *s) {
|
|
if (^{} == ((void*)0))
|
|
return 1;
|
|
else
|
|
return 0;
|
|
}
|
|
void next(void);
|
|
void foo4(void) {
|
|
int (^xx)(const char *s) = ^(char *s) { return 1; }; // expected-error {{incompatible block pointer types initializing 'int (^)(const char *)' with an expression of type 'int (^)(char *)'}}
|
|
int (*yy)(const char *s) = funk; // expected-error {{incompatible function pointer types initializing 'int (*)(const char *)' with an expression of type 'int (char *)'}}
|
|
|
|
int (^nested)(char *s) = ^(char *str) { void (^nest)(void) = ^(void) { printf("%s\n", str); }; next(); return 1; };
|
|
}
|
|
|
|
typedef void (^bptr)(void);
|
|
|
|
bptr foo5(int j) {
|
|
__block int i;
|
|
if (j)
|
|
return ^{ ^{ i=0; }(); }; // expected-error {{returning block that lives on the local stack}}
|
|
return ^{ i=0; }; // expected-error {{returning block that lives on the local stack}}
|
|
return (^{ i=0; }); // expected-error {{returning block that lives on the local stack}}
|
|
return (void*)(^{ i=0; }); // expected-error {{returning block that lives on the local stack}}
|
|
}
|
|
|
|
int (*funcptr3[5])(long);
|
|
int sz8 = sizeof(^int (*[5])(long) {return funcptr3;}); // expected-error {{block cannot return array type}} expected-error {{incompatible pointer to integer conversion}}
|
|
int sz9 = sizeof(^int(*())()[3]{ }); // expected-error {{function cannot return array type}}
|
|
// expected-warning@-1 {{a function declaration without a prototype is deprecated in all versions of C}}
|
|
|
|
void foo6(void) {
|
|
int (^b)(int) __attribute__((noreturn));
|
|
b = ^ (int i) __attribute__((noreturn)) { return 1; }; // expected-error {{block declared 'noreturn' should not return}}
|
|
b(1);
|
|
int (^c)(void) __attribute__((noreturn)) = ^ __attribute__((noreturn)) { return 100; }; // expected-error {{block declared 'noreturn' should not return}}
|
|
}
|
|
|
|
|
|
void foo7(void)
|
|
{
|
|
const int (^BB) (void) = ^{ const int i = 1; return i; }; // OK - initializing 'const int (^)(void)' with an expression of type 'int (^)(void)'
|
|
|
|
const int (^CC) (void) = ^const int{ const int i = 1; return i; };
|
|
|
|
|
|
int i;
|
|
int (^FF) (void) = ^{ return i; }; // OK
|
|
int (^EE) (void) = ^{ return i+1; }; // OK
|
|
|
|
__block int j;
|
|
int (^JJ) (void) = ^{ return j; }; // OK
|
|
int (^KK) (void) = ^{ return j+1; }; // OK
|
|
|
|
__block const int k;
|
|
const int cint = 100;
|
|
|
|
int (^MM) (void) = ^{ return k; };
|
|
int (^NN) (void) = ^{ return cint; };
|
|
}
|
|
|
|
void (^blk)(void) = ^{
|
|
return (void)0; // expected-warning {{void block literal should not return void expression}}
|
|
};
|
|
|
|
enum Test8 { T8_a, T8_b, T8_c };
|
|
void test8(void) {
|
|
extern void test8_helper(int (^)(int));
|
|
test8_helper(^(int flag) { if (flag) return T8_a; return T8_b; });
|
|
}
|
|
void test8b(void) {
|
|
extern void test8_helper2(char (^)(int)); // expected-note {{here}}
|
|
test8_helper2(^(int flag) { if (flag) return T8_a; return T8_b; }); // expected-error {{passing 'enum Test8 (^)(int)' to parameter of type 'char (^)(int)'}}
|
|
}
|