Files
clang-p2996/clang/test/SemaCXX/cxx0x-defaulted-functions.cpp
Utkarsh Saxena 72ac7cac3f Handle explicitly defaulted consteval special members.
Followup patch for D128083

Previously, using a non-consteval constructor from an consteval constructor would code generates the consteval constructor.
Example
```
template <typename T>
struct S {
  T i;
  consteval S() = default;
};
struct Foo {
    Foo() {}
};
void func() {
  S<Foo> three; // incorrectly accepted by clang.
}
```

This happened because clang erroneously disregards `consteval` specifier for a `consteval explicitly defaulted special member functions in a class template` if it has dependent data members without a `consteval default constructor`.

According to
```
C++14 [dcl.constexpr]p6 (CWG DR647/CWG DR1358):
If the instantiated template specialization of a constexpr function
template or member function of a class template would fail to satisfy
the requirements for a constexpr function or constexpr constructor, that
specialization is still a constexpr function or constexpr constructor,
even though a call to such a function cannot appear in a constant
expression.
```

Therefore the `consteval defaulted constructor of a class template` should be considered `consteval` even if the data members' default constructors are not consteval.
Keeping this constructor `consteval` allows complaining while processing the call to data member constructors.
(Same applies for other special member functions).

This works fine even when we have more than one default constructors since we process the constructors after the templates are instantiated.

This does not address initialization issues raised in
[2602](https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#2602) and compiler divergence seen in https://godbolt.org/z/va9EMvvMe

Fixes: https://github.com/llvm/llvm-project/issues/51593

Differential Revision: https://reviews.llvm.org/D131479
2022-08-12 12:13:06 +02:00

289 lines
8.9 KiB
C++

// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -fcxx-exceptions -Wno-deprecated-builtins %s
void fn() = default; // expected-error {{only special member}}
struct foo {
void fn() = default; // expected-error {{only special member}}
foo() = default;
foo(const foo&) = default;
foo(foo&&) = default;
foo& operator = (const foo&) = default;
foo& operator = (foo&&) = default;
~foo() = default;
};
struct bar {
bar();
bar(const bar&);
bar(bar&&);
bar& operator = (const bar&);
bar& operator = (bar&&);
~bar();
};
bar::bar() = default;
bar::bar(const bar&) = default;
bar::bar(bar&&) = default;
bar& bar::operator = (const bar&) = default;
bar& bar::operator = (bar&&) = default;
bar::~bar() = default;
static_assert(__is_trivial(foo), "foo should be trivial");
static_assert(!__has_trivial_destructor(bar), "bar's destructor isn't trivial");
static_assert(!__has_trivial_constructor(bar),
"bar's default constructor isn't trivial");
static_assert(!__has_trivial_copy(bar), "bar has no trivial copy");
static_assert(!__has_trivial_assign(bar), "bar has no trivial assign");
void tester() {
foo f, g(f);
bar b, c(b);
f = g;
b = c;
}
template<typename T> struct S : T {
constexpr S() = default; // expected-note {{previous declaration is here}}
constexpr S(const S&) = default; // expected-note {{previous declaration is here}}
constexpr S(S&&) = default; // expected-note {{previous declaration is here}}
};
struct lit { constexpr lit() {} };
S<lit> s_lit; // ok
S<bar> s_bar; // ok
struct Friends {
// FIXME: these error may or may not be correct; there is an open question on
// the CWG reflectors about this.
friend S<bar>::S(); // expected-error {{non-constexpr declaration of 'S' follows constexpr declaration}}
friend S<bar>::S(const S&); // expected-error {{non-constexpr declaration of 'S' follows constexpr declaration}}
friend S<bar>::S(S&&); // expected-error {{non-constexpr declaration of 'S' follows constexpr declaration}}
};
namespace DefaultedFnExceptionSpec {
// DR1330: The exception-specification of an implicitly-declared special
// member function is evaluated as needed.
template<typename T> T &&declval();
template<typename T> struct pair {
pair(const pair&) noexcept(noexcept(T(declval<T>())));
};
struct Y;
struct X { X(); X(const Y&); };
struct Y { pair<X> p; };
template<typename T>
struct A {
pair<T> p;
};
struct B {
B();
B(const A<B>&);
};
// Don't crash here.
void f() {
X x = X();
(void)noexcept(B(declval<B>()));
}
template<typename T>
struct Error {
void f() noexcept(T::error);
Error() noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}} expected-error {{type 'char'}}
Error(const Error&) noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}}
Error(Error&&) noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}}
Error &operator=(const Error&) noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}} expected-error {{type 'double'}}
Error &operator=(Error&&) noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}}
~Error() noexcept(T::error); // expected-error {{type 'int' cannot be used prior to '::' because it has no members}} expected-error {{type 'char'}}
};
Error<char> c; // expected-note 2{{instantiation of}}
struct DelayImplicit {
Error<int> e; // expected-note 6{{instantiation of}}
};
Error<float> *e;
// An exception specification is needed if the exception specification for a
// a defaulted special member function that calls the function is needed.
// Use in an unevaluated operand still results in the exception spec being
// needed.
void test1(decltype(declval<DelayImplicit>() = DelayImplicit(DelayImplicit()))); // expected-note 4{{in evaluation of exception specification}}
void test2(decltype(declval<DelayImplicit>() = declval<const DelayImplicit>())); // expected-note {{in evaluation of exception specification}}
void test3(decltype(DelayImplicit(declval<const DelayImplicit>()))); // expected-note {{in evaluation of exception specification}}
// Any odr-use needs the exception specification.
void f(Error<double> *p) {
*p = *p; // expected-note {{instantiation of}}
}
}
namespace PR13527 {
struct X {
X() = delete; // expected-note {{here}}
X(const X&) = delete; // expected-note {{here}}
X(X&&) = delete; // expected-note {{here}}
X &operator=(const X&) = delete; // expected-note {{here}}
X &operator=(X&&) = delete; // expected-note {{here}}
~X() = delete; // expected-note {{here}}
};
X::X() = default; // expected-error {{redefinition}}
X::X(const X&) = default; // expected-error {{redefinition}}
X::X(X&&) = default; // expected-error {{redefinition}}
X &X::operator=(const X&) = default; // expected-error {{redefinition}}
X &X::operator=(X&&) = default; // expected-error {{redefinition}}
X::~X() = default; // expected-error {{redefinition}}
struct Y {
Y() = default;
Y(const Y&) = default;
Y(Y&&) = default;
Y &operator=(const Y&) = default;
Y &operator=(Y&&) = default;
~Y() = default;
};
Y::Y() noexcept = default; // expected-error {{definition of explicitly defaulted}}
Y::Y(const Y&) noexcept = default; // expected-error {{definition of explicitly defaulted}}
Y::Y(Y&&) noexcept = default; // expected-error {{definition of explicitly defaulted}}
Y &Y::operator=(const Y&) noexcept = default; // expected-error {{definition of explicitly defaulted}}
Y &Y::operator=(Y&&) noexcept = default; // expected-error {{definition of explicitly defaulted}}
Y::~Y() = default; // expected-error {{definition of explicitly defaulted}}
}
namespace PR27699 {
struct X {
X();
};
X::X() = default; // expected-note {{here}}
X::X() = default; // expected-error {{redefinition of 'X'}}
}
namespace PR14577 {
template<typename T>
struct Outer {
template<typename U>
struct Inner1 {
~Inner1();
};
template<typename U>
struct Inner2 {
~Inner2();
};
};
template<typename T>
Outer<T>::Inner1<T>::~Inner1() = delete; // expected-error {{nested name specifier 'Outer<T>::Inner1<T>::' for declaration does not refer into a class, class template or class template partial specialization}} expected-error {{only functions can have deleted definitions}}
template<typename T>
Outer<T>::Inner2<T>::~Inner2() = default; // expected-error {{nested name specifier 'Outer<T>::Inner2<T>::' for declaration does not refer into a class, class template or class template partial specialization}}
}
extern "C" { // expected-note {{extern "C" language linkage specification begins here}}
template<typename _Tp> // expected-error {{templates must have C++ linkage}}
void PR13573(const _Tp&) = delete;
}
namespace PR15597 {
template<typename T> struct A {
A() noexcept(true) = default;
~A() noexcept(true) = default;
};
template<typename T> struct B {
B() noexcept(false) = default;
~B() noexcept(false) = default;
};
A<int> a;
B<int> b;
}
namespace PR27941 {
struct ExplicitBool {
ExplicitBool &operator=(bool) = default; // expected-error{{only special member functions may be defaulted}}
int member;
};
int fn() {
ExplicitBool t;
t = true;
}
}
namespace dependent_classes {
template <bool B, typename X, typename Y>
struct conditional;
template <typename X, typename Y>
struct conditional<true, X, Y> { typedef X type; };
template <typename X, typename Y>
struct conditional<false, X, Y> { typedef Y type; };
template<bool B> struct X {
X();
// B == false triggers error for = default.
using T = typename conditional<B, const X &, int>::type;
X(T) = default; // expected-error {{only special member functions}}
// Either value of B creates a constructor that can be default
using U = typename conditional<B, X&&, const X&>::type;
X(U) = default;
};
X<true> x1;
X<false> x2; // expected-note {{in instantiation}}
template <typename Type>
class E {
explicit E(const int &) = default;
};
template <typename Type>
E<Type>::E(const int&) {} // expected-error {{definition of explicitly defaulted function}}
}
namespace P1286R2 {
struct X {
X();
};
struct A {
struct B {
B() noexcept(A::value) = default;
X x;
};
decltype(B()) b;
static constexpr bool value = true;
};
A::B b;
static_assert(noexcept(A::B()), "");
}
namespace GH56456 {
template <typename T>
using RC=T const&;
template <typename T>
using RV=T&;
template <typename T>
using RM=T&&;
struct A {
A(RC<A>) = default;
A(RM<A>) = default;
auto operator=(RC<A>) -> RV<A> = default;
auto operator=(RM<A>) -> RV<A> = default;
};
struct B {
B (RC<B>) = delete;
B (RM<B>) = delete;
auto operator = (RC<B>) -> RV<B> = delete;
auto operator = (RM<B>) -> RV<B> = delete;
};
}