63afcbbeea
There was a bug in Clang where it couldn't choose which overload candidate was more specialized if it was comparing a member-function to a non-member function. Previously, this was detected as an ambiguity, now Clang chooses correctly. This patch fixes the bug by fully implementing CWG2445 and moving the template transformation described in `[temp.func.order]` paragraph 3 from `isAtLeastAsSpecializedAs()` to `Sema::getMoreSpecializedTemplate()` so we have the transformed parameter list during the whole comparison. Also, to be able to add the correct type for the implicit object parameter `Sema::getMoreSpecializedTemplate()` has new parameters for the object type. Fixes #74494, fixes #82509
61 lines
1.6 KiB
C++
61 lines
1.6 KiB
C++
// RUN: %clang_cc1 -fsyntax-only -verify %s
|
|
// RUN: %clang_cc1 -std=c++23 -verify -fsyntax-only %s
|
|
|
|
enum copy_traits { movable = 1 };
|
|
|
|
template <int>
|
|
struct optional_ctor_base {};
|
|
template <typename T>
|
|
struct ctor_copy_traits {
|
|
// this would produce a c++98-compat warning, which would erroneously get the
|
|
// no-matching-function-call error's notes attached to it (or suppress those
|
|
// notes if this diagnostic was suppressed, as it is in this case)
|
|
static constexpr int traits = copy_traits::movable;
|
|
};
|
|
template <typename T>
|
|
struct optional : optional_ctor_base<ctor_copy_traits<T>::traits> {
|
|
template <typename U>
|
|
constexpr optional(U&& v);
|
|
};
|
|
struct A {};
|
|
struct XA {
|
|
XA(const A&);
|
|
};
|
|
struct B {};
|
|
struct XB {
|
|
XB(const B&);
|
|
XB(const optional<B>&);
|
|
};
|
|
struct YB : XB {
|
|
using XB::XB;
|
|
};
|
|
void InsertRow(const XA&, const YB&); // expected-note {{candidate function not viable: no known conversion from 'int' to 'const XA' for 1st argument}}
|
|
void ReproducesBugSimply() {
|
|
InsertRow(3, B{}); // expected-error {{no matching function for call to 'InsertRow'}}
|
|
}
|
|
|
|
#if __cplusplus >= 202302L
|
|
namespace overloadCheck{
|
|
template<typename T>
|
|
concept AlwaysTrue = true;
|
|
|
|
struct S {
|
|
int f(AlwaysTrue auto) { return 1; }
|
|
void f(this S&&, auto) {}
|
|
|
|
void g(auto) {}
|
|
int g(this S&&,AlwaysTrue auto) {return 1;}
|
|
|
|
int h(AlwaysTrue auto) { return 1; } //expected-note {{previous definition is here}}
|
|
int h(this S&&,AlwaysTrue auto) { // expected-error {{class member cannot be redeclared}}
|
|
return 1;
|
|
}
|
|
};
|
|
|
|
int main() {
|
|
int x = S{}.f(0);
|
|
int y = S{}.g(0);
|
|
}
|
|
}
|
|
#endif
|